Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp279230rdb; Thu, 8 Feb 2024 05:59:37 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWra6zgc3bB4UTbdI53lQk7ZN6vGXG1g2ZtEEfv+6yWryEgoGC78zVE4hxNNnCIud7G36EuYARr9ggXlgjeY+Rrpq3tXlOsjgBLrllmyA== X-Google-Smtp-Source: AGHT+IGAEjykTLr9+xBzFHCFs24bXx0135s7W6dBy/tqL5KFo1UahNjkZPYePLy4x6gYnmNLqmXq X-Received: by 2002:a05:6512:39cd:b0:511:6255:7fae with SMTP id k13-20020a05651239cd00b0051162557faemr5714066lfu.6.1707400776839; Thu, 08 Feb 2024 05:59:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707400776; cv=pass; d=google.com; s=arc-20160816; b=Q7hYcg1xZhVg5DooihDYEsGFLjB9s9KEkch9I6VR6uYZKfT8Ubk9VEOnaCR+6cekCk b4c7Dm/NcPM6cG9plM94e7/i8sks18bTeG/w3aSiJeck6xw7H0727ywRREZ0LgifZokl yHknPqFozk47xxomRGx9DwIwSDmJ7PyuY5+k4jaNR9viFluMyjWe/QiQKLkMLoFqAUVT D95KY1dSDgefAsS2cP6Ap/tfpa848d50M8lSHwE6Nvu+84zd0fLt67KZuu1ICw8mauCT GcNwLJ7+cshHFu59v8FOy0aZMo1PxBDybAQHezo4hrOmvsiSjS7hAuIUQfHyyMFmkzuz VYQg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3wZJzeE4VGpO+Fnoh2fgqe2zVVRfTJqjDzlLiAVIt3M=; fh=llnpVqCFwwCd+LZV6nIqIDsVWyOdno60KSpVwxR5ncA=; b=WkUt5b0kQHTvxj3/jn5/2CcSWnj0A+2a/TKB3I58VnOrwQ1ZK0cTuTmUXebOVSoO0Z uFaGVdCYSVbdCMsoDQcX0Q9P5B5dy/TRZdLuH+apBRFEnXEC/M05kuaGAs/MRYrfV3Kc gd3+tPPHqrK/xmbtLmnOucFhgnmNkfglJKBF8px0Isw4DEfCTYNNuJw7k78vIx5i73Hj xVEDD/LBobXrvwQ7DMt47F05wo5Trfz7gpzqw3NuXkZWdnN7rA7ju4iti+WBlRjbcnvm 5Xx6X9JljqOws5qeWDQJnGmqhXSZRVSJmJU+wGw7uRlLwPPIf5miBho7Fqq+JIFPC18r y+vw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KHL6Pxb7; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-58204-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58204-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCVWmQ+fX0ucrp2STzlS7z7DEhgkD3LPaNXrvNGM7BtVyJInS3dyuq+/JWMdQREEA/D++EFkAOPJJAyx93/hGchhQdBeYNObL6Dcm7X7oA== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id t13-20020a1709066bcd00b00a37ba665229si62203ejs.870.2024.02.08.05.59.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 05:59:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58204-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KHL6Pxb7; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-58204-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58204-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 733A31F2BBA4 for ; Thu, 8 Feb 2024 13:59:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2F6A778696; Thu, 8 Feb 2024 13:59:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KHL6Pxb7" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 517F9763E8; Thu, 8 Feb 2024 13:59:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707400765; cv=none; b=cvTjratomk9HrHtz3mQ/1SrFlySn7VAL+DjT7qkBnYin240qwKU2sSbKAlHisFwt7S5FR1gmcSe844edOOwyopvM+i8HyMC9YSkU2kKj7g7C6cb5Hdrpmzgx+SgHPBQBqNClgaxD1qT8HZ/4eUziZtEHJaefG/E6nnHyp/E+6JA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707400765; c=relaxed/simple; bh=go3VhlXk6Fnh3yPxAQWPPFT8Rbt755seTs3WL9Bzo/I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JtkUn8uxFmEiBFt0ZymloMlvNc/NDq8BU47PL84XoS0W2Zw/X+ikpTNKijNmh2UNe4nOwQu64GeTOE2pspa/5Q9Wd969FrRdrH0Mai3tRH6X8bQiO3MyA4nJgmSdGeR67xnd3xD5OcCHnaNMw1pf2rTI76BI9lggxnwC03h+hXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KHL6Pxb7; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18EECC433C7; Thu, 8 Feb 2024 13:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707400763; bh=go3VhlXk6Fnh3yPxAQWPPFT8Rbt755seTs3WL9Bzo/I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KHL6Pxb7RWXQABZTb2zfXe6Z5RP/2/5HU4UvBJ5fwNlhCcM7IDHBXvWzExYUOCEpx vHQGQvt3BNctGm408Y8OgrWlcwhfnrNb2wTRxw2GGWxxf6CFbgxMjnadqmKijKB67C 1nyeYrZr3AEyeELypVSNDkNSPmwm0zknYaJN28mjInlVMZOo6awC/KZK2RFYjc51NC zzG/FPobvPqX2AhacXgI5aBCdrtiFQGPNmG2LeicAQs59Zj9nwmXkSoaxu8JV7w5qF CrxC5NYUVnU97YR/taok71AqcoXtypuFYuFBLsEq8tQNchI0/rmmGkaS0L9uaTTXbN PI5/07xvt9fBw== Date: Thu, 8 Feb 2024 13:59:18 +0000 From: Lee Jones To: Dmitry Rokosov Cc: Pavel Machek , Martin Kurbanov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, kernel@salutedevices.com, Greg Kroah-Hartman Subject: Re: [PATCH v1 1/2] leds: aw200xx: support for hw pattern controllers Message-ID: <20240208135918.GQ689448@google.com> References: <20231207125938.175119-1-mmkurbanov@salutedevices.com> <20231207125938.175119-2-mmkurbanov@salutedevices.com> <20231221161011.GO10102@google.com> <20240129141927.4shshli37fb3cwen@CAB-WSD-L081021> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240129141927.4shshli37fb3cwen@CAB-WSD-L081021> On Mon, 29 Jan 2024, Dmitry Rokosov wrote: > Hello Pavel, > > On Sat, Jan 27, 2024 at 12:21:48AM +0100, Pavel Machek wrote: > > Hi! > > > > > > This led-controller supports 3 pattern controllers for auto breathing or > > > > group dimming control. Each pattern controller can work in auto > > > > breathing or manual control mode. All breathing parameters including > > > > rising/falling slope, on/off time, repeat times, min/max brightness > > > > and so on are configurable. > > > > > > > > Signed-off-by: Martin Kurbanov > > > > --- > > > > .../testing/sysfs-class-led-driver-aw200xx | 108 +++ > > > > Documentation/leds/leds-aw200xx.rst | 274 ++++++++ > > > > drivers/leds/leds-aw200xx.c | 649 ++++++++++++++++++ > > > > 3 files changed, 1031 insertions(+) > > > > create mode 100644 Documentation/leds/leds-aw200xx.rst > > > > > > This interface is bananas. Exposing an entire register interface to > > > sysfs does not sit will with me at all. When we add support to a sysfs > > > class, we usually require it to be generic and work across all devices. > > > Adding device specific interfaces is generally decried and to be > > > avoided. Don't forget, once we commit something to sysfs, it becomes > > > ABI and we have to support it forever. > > > > If you do git grep hw_pattern, you should get pointers to qcom-lpg > > driver that solves similar problem, with interface that should be > > acceptable. > > Thank you for pointing that out. Yes, it's a very similar situation to > ours. > > But I haven't observed the merging of this driver. Was it encountering > similar issues with the sysfs interface? `git grep` kinda implies that it's merged. -- Lee Jones [李琼斯]