Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp283820rdb; Thu, 8 Feb 2024 06:04:45 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWuc6zONBEyZ1AyoVcu9YswBWu1nfj7Cw9WY+ky5NUBG2a6AKS2SGeyIymum+DKABEnIpAwBfK8PJlaBkXOix4m04lyf07qHU5RZ15gRQ== X-Google-Smtp-Source: AGHT+IEWPPE7/flZY1ojT/2eLOFRpIFYNvx49N8ASVIjV6xEf/5LudUz13Lf2hqc8tQJq7Oti3MR X-Received: by 2002:a05:6902:1b02:b0:dc6:d158:98f0 with SMTP id eh2-20020a0569021b0200b00dc6d15898f0mr9474661ybb.52.1707401084918; Thu, 08 Feb 2024 06:04:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707401084; cv=pass; d=google.com; s=arc-20160816; b=GtX0beMU/BiwyByl1BurkSusZmtzW9KZyda8agNh+S/mLfTW0YW5LrA8Or2I3lsEMp VVONlzaluDhY8CVwZk9/O9nfkXTNuGiUwgox4NFTkcftfqXejk7AA6FOtz4OUvm0jWUu zbDF/89ZmFEC55/DQi5nLVHuPniUx9FEugd+Qv7q0s7e82tdwsqou4sHIGZnj0M/58eG UMtbMFu0/wGzz0JpRMzSm2Q1amSz/w6sYvORx40wkoR0Mc4U2wUQ3zKTVpC4lh7ilEPh 64jJKYuJJK5kWlDzccWbm9/SD+R2hRQd5s8gQiWpUBEHk7rdgi921i3ZpkocBh1ebrw7 ltaQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=x8IxW/JYVA4Yh8SX5tJLSjKWOOKbdKRv6niQCFHUDy0=; fh=54iEPInRaXsyF/F/kqZQC1xeacgYNsoRCl14uQDU58Q=; b=cN1oXfPkNsNDWzc1t7z13R+CR9uwO9zy30IxNSrBc07MNVDdfnfyB2ENUYwEeu8Yrz Gnd9uVB64G5DYv2SriJY0GkGyImme5xXnviyC8SdyUZqncfx93EIWmDXdlM5cKmoatle hcZk8AYIGuU6mBTvF67gqVdJv7fkz7AnUvfAdC9Te7/3OwDgvFMpl+exACQijnMm1VDo j6OvZJjEhntAm9qNq/EyMJYPQzmzAT0LGqYP81wF9kUhibKSaL0K6bxcNzbgmNDZMT3Y SeQLJjUOl45ojaFMHZhWSIDVEP2x40ybmPgxSOUKJCLgsy4pbujguTcpWPx0RJDzfRpi YV0Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=X7U4hszY; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-58211-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58211-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUfIdCvqH6SBQVhvh5QxIMinKFIzFvBA0X3Z4qpxADoeEALW4d16XEXx9VxAVeouKTgMaGk4H2BBQcEnbDvfr69Uqqea5EizZhtNnQnHQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id v136-20020a25c58e000000b00dc747af398csi162142ybe.326.2024.02.08.06.04.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 06:04:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58211-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=X7U4hszY; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-58211-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58211-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9D0611C20F64 for ; Thu, 8 Feb 2024 14:04:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7D82B78B40; Thu, 8 Feb 2024 14:04:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X7U4hszY" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6BCB7640A; Thu, 8 Feb 2024 14:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707401076; cv=none; b=J7qQKflWvqlrclfFBi4Jy8VLYF+RYTl1Cw+QincI2bVu00pWmHT4ZFTcPJeiieK0tP9dm4zi0Z7j331+v6RRqsO3WtqONxpIv1PjWeObexRxonxZzUtOVAcwOlAVZ35veL/o0/4QtT61QWibE9ufEKnFED362D6HhKBMzfrNK7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707401076; c=relaxed/simple; bh=2hms3TPwr8f/X4oq2c4MaDQ1qmoGBSzkbH2R7hmgcsQ=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=n5bLHOPPitnZ3UahOx/vPTIpuHQf+bjnQtQmUQpOueIPaGrZd0bKbg2nhD8ajifPBmRbDA6w6lrK1B50iZ0zXCndOk51fa6YgPqOKxZzGEJmZKDET0miSxfxVjC4K4WMXtu+3aC9WCXJbCpl6uLpP57dLlTjEPhIH+InW6dAhv0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X7U4hszY; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD8CEC433F1; Thu, 8 Feb 2024 14:04:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707401076; bh=2hms3TPwr8f/X4oq2c4MaDQ1qmoGBSzkbH2R7hmgcsQ=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=X7U4hszYYIGuPdTJiWEfdww+3wccTo4vUAcwy/kRbUjPmJRy8C0bAttEpTo66YDsI KcJtQufUqI6EGMANuhxHo2Hua1CbyXozK8VwL4Z4/z/aH/LiiEg65OS5TnUze4z4up 3ufLPaHOuPFzVceNuQfWkApK2h0SAyKo7N0fuVtUdqHMT33kYXIwqC9EmqczjD0WNN acG19aft04xQdpM9z3b0C4ShtpWPqMQMU//1z4LDORfk75zMDbQefcaXtI9KmBv9dI 6uSsvXPIoz8/NE+JbYAUrqyo6DEPAEY8EeXImy1klrWh93iu5AzvK8WY+w6cUUD0tY 7Q/xtCg2c8Kwg== From: Lee Jones To: Pavel Machek , Lee Jones , Andrew Lunn , "David S. Miller" , Jakub Kicinski , Heiner Kallweit , Daniel Golle , Li Zetao , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Marangi Cc: stable@vger.kernel.org In-Reply-To: <20240203235413.1146-1-ansuelsmth@gmail.com> References: <20240203235413.1146-1-ansuelsmth@gmail.com> Subject: Re: (subset) [PATCH] leds: trigger: netdev: Fix kernel panic on interface rename trig notify Message-Id: <170740107363.1051506.1320961736541911295.b4-ty@kernel.org> Date: Thu, 08 Feb 2024 14:04:33 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.12.3 On Sun, 04 Feb 2024 00:54:01 +0100, Christian Marangi wrote: > Commit d5e01266e7f5 ("leds: trigger: netdev: add additional specific link > speed mode") in the various changes, reworked the way to set the LINKUP > mode in commit cee4bd16c319 ("leds: trigger: netdev: Recheck > NETDEV_LED_MODE_LINKUP on dev rename") and moved it to a generic function. > > This changed the logic where, in the previous implementation the dev > from the trigger event was used to check if the carrier was ok, but in > the new implementation with the generic function, the dev in > trigger_data is used instead. > > [...] Applied, thanks! [1/1] leds: trigger: netdev: Fix kernel panic on interface rename trig notify commit: db36d7d45d191879ec4dd1535fbf04ee4ac28711 -- Lee Jones [李琼斯]