Received-SPF: pass (google.com: domain of linux-kernel+bounces-58237-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 8 Feb 2024 10:34:14 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: ankita@nvidia.com, maz@kernel.org, oliver.upton@linux.dev,
	james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com,
	reinette.chatre@intel.com, surenb@google.com, stefanha@redhat.com,
	brauner@kernel.org, will@kernel.org, mark.rutland@arm.com,
	alex.williamson@redhat.com, kevin.tian@intel.com,
	yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org,
	andreyknvl@gmail.com, wangjinchao@xfusion.com, gshan@redhat.com,
	ricarkol@google.com, linux-mm@kvack.org, lpieralisi@kernel.org,
	rananta@google.com, ryan.roberts@arm.com, aniketa@nvidia.com,
	cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com,
	vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com,
	jhubbard@nvidia.com, danw@nvidia.com, kvmarm@lists.linux.dev,
	mochs@nvidia.com, zhiw@nvidia.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v6 2/4] mm: introduce new flag to indicate wc safe
Message-ID: <20240208143414.GJ10476@nvidia.com>
References: <20240207204652.22954-1-ankita@nvidia.com>
 <20240207204652.22954-3-ankita@nvidia.com>
 <ZcTRH1rzfPbuQ_qj@arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZcTRH1rzfPbuQ_qj@arm.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?bNZrM9xEU6WI1x70e3Hi91k1B36LyjdRDON1CkDSIlWMwsB1TSBilHWLVRjK?=
 =?us-ascii?Q?AZUEJrgzmeKzRYBWv1W/rPyDmMWIAeut0aDo9dnJb3JwZ501H32MmtSmJk5a?=
 =?us-ascii?Q?HCNbM2d552NyGlZ0x8sGo01aDd5YL9b4B6wEUNDJWDss/5g2BAo5ml/aiOJ9?=
 =?us-ascii?Q?Ge5VW0rVnSbNblN7/200pFW0TcfDcUHfU+8BOHKLcILmgTIl41pVohPfcuzI?=
 =?us-ascii?Q?xXMnQoNV7G5XqZsGwKC7B/YwTeq9m9cuJ2XTyUcg2q+ZVm3CR6stq5qTQvXS?=
 =?us-ascii?Q?LfriJ29VELnkcBy15TjHwkZ8HsXSJXml4Fk9X/12ueKzW5qx47JRNXyB59zw?=
 =?us-ascii?Q?O4do0P3buYrZ+aer9IQNn0YCSsZWx1sHO7ahcUEMoS6QF8LYPO3H3aHsHELU?=
 =?us-ascii?Q?lKPF54XOnyz2MLoI/tAfUdJJWf1DaDpryoSpnD1GEIG4Z0/SJNAAeham4BYT?=
 =?us-ascii?Q?s90QkMzI31lK1SKqUCVH2yZR7MyQNpX0pnVw/AjVg6zvXFCMV3OypNoSev9w?=
 =?us-ascii?Q?owMB9bci+g7Ey3tW5dfv+cDS2vkBGhUwsm0KY7SKufzSBEvfUlCSq0KrmMc6?=
 =?us-ascii?Q?i1UaAi27O0Zf88GiRo0t5DeXLxstCABoUc0PGupxv9M8KEcts1zUnm7WxPe9?=
 =?us-ascii?Q?YP+AU7puk9p1cPVUOxosEt1d5WCjiGamxyj914WZajo4b4s5wQx7IYC7Rqvt?=
 =?us-ascii?Q?GlgwAPdl2lLYYIIrJCk9C+wwreAVg6YOj1XYAJoxA3cSumVjWnesRtqSd25t?=
 =?us-ascii?Q?rm1b5Ij7ursoaXka1lEbrCAv0U9Cer9d/rgDLhRndAMyeSLjlZMtqveQOLby?=
 =?us-ascii?Q?61FiDhRJmoNRFSxxBneNaXpEVeMEYiddGIn3ZV5jVb3D5vREcvrxonBdRaxb?=
 =?us-ascii?Q?QcuH5EZBB73/id2fE9JnlFOyvGr1ftxizxxis6Ug4msh9ahDHqfGd7qlq/Ws?=
 =?us-ascii?Q?Nhr/8U9whxzxrCHbvcQ98Z2SzpPXwTbI26DqKzciMVD+bqFkP/cTVmBwsZU8?=
 =?us-ascii?Q?Y00MXkpcqwxt1fUAKDB/ghIOc4JphrnygB22mHYoG8F+cscZ+Hgc8mzKgN8g?=
 =?us-ascii?Q?Ox0VuM+eGOOkKWj34CUrAXnhEfqynkiIYyNMhMquDvXA3+qBcvqibZCp6xNA?=
 =?us-ascii?Q?ROHMWHiM73tasVoChj4Cin1Ft0tanODvj18XCGjyL/IlukaR0fqc7M4vSoX8?=
 =?us-ascii?Q?c5pq9FODp85Q7+xC1APP4NIB9PTFl9pmT6Bb4/ePSgiNhmcXxxAFygQ1xVpR?=
 =?us-ascii?Q?F8v1P+rLOXygMy6p2+/MuKRDc3Q3XNYtE6XMsWaECKY5mGnowP7bgOKDLJBo?=
 =?us-ascii?Q?ZXczubaQObPchNjNeTQ44AhBXoXMvF8EEonqmAHcBS/nK0jofPXmbS48OMTe?=
 =?us-ascii?Q?KkQOUW/nZIHrqGM4GMrP6MqpoxXbXBXUmZ0Y2KzbO55jn/5yJKUKGpIrgDJ+?=
 =?us-ascii?Q?a3rrLKWyHRAXiYLizlW3uD/6l7p6xl0+b5gKnNvJfzdv3fRNjE+QtmhE7NEy?=
 =?us-ascii?Q?vtA+wjxkKuCkCiGcSOcktqNn/aMncuYA8b5cmJz0UAGAiCRKof5Nr4c6mjSv?=
 =?us-ascii?Q?bmGKcb+29fayRdYGK+DL8juRyMghPaBhmM6nlzea?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62252bd5-c86b-4b29-27b2-08dc28b306af
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 14:34:15.7511
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: scbb7YXhBWFTvqlTFNPNCkCK4/uucn/uup/xLrFQqZ7lMbUuB2TkE1c/9MaM1woC
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5932

On Thu, Feb 08, 2024 at 01:03:27PM +0000, Catalin Marinas wrote:
> On Thu, Feb 08, 2024 at 02:16:50AM +0530, ankita@nvidia.com wrote:
> > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > index f5a97dec5169..884c068a79eb 100644
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> > @@ -391,6 +391,20 @@ extern unsigned int kobjsize(const void *objp);
> >  # define VM_UFFD_MINOR		VM_NONE
> >  #endif /* CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */
> >  
> > +/*
> > + * This flag is used to connect VFIO to arch specific KVM code. It
> > + * indicates that the memory under this VMA is safe for use with any
> > + * non-cachable memory type inside KVM. Some VFIO devices, on some
> > + * platforms, are thought to be unsafe and can cause machine crashes if
> > + * KVM does not lock down the memory type.
> > + */
> > +#ifdef CONFIG_64BIT
> > +#define VM_VFIO_ALLOW_WC_BIT	39
> > +#define VM_VFIO_ALLOW_WC	BIT(VM_VFIO_ALLOW_WC_BIT)
> > +#else
> > +#define VM_VFIO_ALLOW_WC	VM_NONE
> > +#endif
> 
> Adding David Hildenbrand to this thread as well since we briefly
> discussed potential alternatives (not sure we came to any conclusion).

FWIW, with my mm hat on:

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

But I'm interested if David has an alternative. We don't have a
shortage of bits here so I'm not sure it is worth much fuss.

Jason