Received-SPF: pass (google.com: domain of linux-kernel+bounces-58307-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 08 Feb 2024 15:51:31 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
From: Rob Herring <robh@kernel.org>
To: Dharma Balasubiramani <dharma.b@microchip.com>
Cc: alexandre.belloni@bootlin.com, conor+dt@kernel.org, 
 linux-kernel@vger.kernel.org, tglx@linutronix.de, 
 nicolas.ferre@microchip.com, linux-arm-kernel@lists.infradead.org, 
 robh+dt@kernel.org, claudiu.beznea@tuxon.dev, devicetree@vger.kernel.org, 
 krzysztof.kozlowski+dt@linaro.org
In-Reply-To: <20240208092015.263210-1-dharma.b@microchip.com>
References: <20240208092015.263210-1-dharma.b@microchip.com>
Message-Id: <170740748922.3230402.17318224112819715619.robh@kernel.org>
Subject: Re: [PATCH] dt-bindings: interrupt-controller: Convert Atmel AIC
 to json-schema


On Thu, 08 Feb 2024 14:50:15 +0530, Dharma Balasubiramani wrote:
> Convert the Atmel AIC binding document to DT schema format using
> json-schema.
> 
> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
> ---
> Note: I get the following warnings on latest kernel but not in 6.7.
> Should I be worried?
> 
> usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR [FILE_OR_DIR ...]]
> yamllint: error: one of the arguments FILE_OR_DIR - is required
> 
>  .../interrupt-controller/atmel,aic.txt        | 43 ---------
>  .../interrupt-controller/atmel,aic.yaml       | 88 +++++++++++++++++++
>  2 files changed, 88 insertions(+), 43 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/atmel,aic.txt
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.example.dtb: /example-1/dma-controller@ffffec00: failed to match any schema with compatible: ['atmel,at91sam9g45-dma']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240208092015.263210-1-dharma.b@microchip.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.