Received-SPF: pass (google.com: domain of linux-kernel+bounces-58299-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <af4d5f3a-b514-47f9-9a8c-54d7bfd565f2@theobroma-systems.com>
Date: Thu, 8 Feb 2024 16:46:18 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 2/6] serial: 8250: Support separate rs485 rx-enable
 GPIO
To: Christoph Niedermaier <cniedermaier@dh-electronics.com>,
 Lino Sanfilippo <LinoSanfilippo@gmx.de>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Heiko Stuebner <heiko@sntech.de>
Cc: Rob Herring <robh@kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
 "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
 "linux-arm-kernel@lists.infradead.org"
 <linux-arm-kernel@lists.infradead.org>,
 "linux-rockchip@lists.infradead.org" <linux-rockchip@lists.infradead.org>,
 "quentin.schulz@theobroma-systems.com"
 <quentin.schulz@theobroma-systems.com>,
 Heiko Stuebner <heiko.stuebner@cherry.de>
References: <20240126-dev-rx-enable-v5-0-5d934eda05ca@theobroma-systems.com>
 <20240126-dev-rx-enable-v5-2-5d934eda05ca@theobroma-systems.com>
 <098216ce-50b3-43e4-ad1a-42228c58b761@gmx.de>
 <37522087-d3ac-4cc7-b11b-c844d36206ba@theobroma-systems.com>
 <3d31b17ffd4a4f02aaaa1b6c33a09009@dh-electronics.com>
Content-Language: en-US
From: Farouk Bouabid <farouk.bouabid@theobroma-systems.com>
In-Reply-To: <3d31b17ffd4a4f02aaaa1b6c33a09009@dh-electronics.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NDIvYmI1VmVpVkkrclptYWYrMnVaU3Z6bFlPOWE4UDFrZFkwL3hZNytNdGwv?=
 =?utf-8?B?bkRISFNFUWhvajVKZWJFcEFpR2dUWGZ0MWNNNnBPSVNEb2JvcEcvMk9LYVRU?=
 =?utf-8?B?YzBCWWc4SjN5V0xjNjRSS3FEM1ZBeExOYlpva0pKVFd3Z21ZUVg3T3N2azlD?=
 =?utf-8?B?cGM1Ny9aWEFvSVFkbitNVkhDZG1YTHBiOEVwanZTOEhYOHNpeER4Q2M0d3hZ?=
 =?utf-8?B?M29HbTdDRW9uU1d6NHpWZVZKSFM0ejY0TXBBU2RRZGdkWWpFMHRaczEyQU85?=
 =?utf-8?B?b29UQjZmWjhEQWlDaENUZkRhWkhFOWNwRElUMyt4STBjWmlKVTJQOGNkeU1W?=
 =?utf-8?B?WGh6czBIeDhnNFJMbkNrRVVkalRsQW9ZL3VidnZHcXRXb0cvZEUxYW13TW93?=
 =?utf-8?B?ZjFueFRsdGdxb2p1a2JVWjZzRGdBNkNRa2cvdWNzeEtFbWN0WEc2UU9qdlZk?=
 =?utf-8?B?d2pmN0ZXN3phUHZTY1VYMXVvb3NNVWQxY2FyNlhyV09janQ4S04vV0k0em1R?=
 =?utf-8?B?UzhCMVRKZDN4Vlg5TE1pNDd0OUVDV3lSeGxNVFpzOUVFQThzNnJGY1V3ZkRV?=
 =?utf-8?B?U3dMbDl0QnlQU29leE4rTUJ0bXdjOStXbDVLdFB3SC92dC91R25wY0hZV2hV?=
 =?utf-8?B?dzR3N1g5d1NBMmRUZE9wM3B1OHlwTFI4SXorMjhtVCtnaU0zdFhzVDVOelNv?=
 =?utf-8?B?clRsL1g2V0xrWEE3UlNLT2pRRnpUdzJNUmZBT2wwcFFwWWhTakJNWVNwMThE?=
 =?utf-8?B?WVg0SUFhME10Nm5BYkpZZUtNVFlsdmJrWmlEbHloeGhxQi9DaXlZdXg2RVA2?=
 =?utf-8?B?dVpraUtEWEg2VVJReGJuMmNKcXdPbUttdEFmVEVNN3pQM1RqOU1hc3U2WkUz?=
 =?utf-8?B?S1hRUDA2MlR2R0pXWStXVjBlaDcvVWdITWw2Y3NtZGdPVUNUTDg1SitQVXpE?=
 =?utf-8?B?OXpKUHZiNXBsQlRDOG9HR1M0V1d5TFI5Q2ZiWUVsVjNTODdYNmFNdDA4U3FH?=
 =?utf-8?B?cklRZHdRdys5UEtmUnB5cWhyNjdZc29mdlg1TklkZGFRZnJPcDcxV3FEamN4?=
 =?utf-8?B?WnB1OVVHeHFHc0J4MUlJWnlNZzh2bU83SGdYZzhRZ1hlYTJBSkJrb2VtbFho?=
 =?utf-8?B?MlN0NlY2dVRrUWxVVjNFWk0wUXpSZlByNjQyZXNWUUsyVWpwZjU0TGN0QUdw?=
 =?utf-8?B?aG1uNDdHd0ZybWViSGpDV09tMytPVjFJb3RlcFFQMDdIOVB3OUlva3FZdHJJ?=
 =?utf-8?B?VUh2bFhlTDlUREt1Z2hqdnc1QzJEbGM3RDlrM3plaVVJRFJVb2YrOEg4NUVO?=
 =?utf-8?B?aXM0aE9tZkQ3VHk1RXZXZVMxL1I4bCtPS0lwU0IwZDFRTnlIOW5YTVlncHNX?=
 =?utf-8?B?VEFvUEd3VEo4eGJ1ZmlWT1RYTGZUOVJnTFgyMHNVRHhGMTFPM3VINnlHb1Qw?=
 =?utf-8?B?bHFOaS9yZ2RqSElwNS9DSmdodGlGM1c4c1habFhyV3JudEtIaUdSUE9FWlFx?=
 =?utf-8?B?YjJ0dDdBN3hCNUN1aWJ0TUdaOHY4OGhTSy9GMUJzOUE3Z1M5WXh4SnN2b2Y3?=
 =?utf-8?B?WW5HUk5ZSWJ0eXJpUlRoZW9kRE5OMDQvM2I4SXVRUU5BUDdSNXlta3ovamNv?=
 =?utf-8?B?dk1FUmw2aklpU1FQdGd1OTlNTzBGdWJXbURTTFdoS2V4OXh4SkEyTjJNVVBr?=
 =?utf-8?B?cHQrSUNiM2l4T1hRNE1ubjY1MlZHRU9BQTlIc1FjZzBYN3p1QXd4VzQzZEoy?=
 =?utf-8?B?emNVRUVQKzFONmJ6MGltaHhudmhhalFnVVdrZGJlcW9JSlZPL2YrbjhzZnFw?=
 =?utf-8?B?OWp6TDVRa0dkNjR0NzQyblVydXFNTXcrMU1wRjdPMDFwSndvSHRvWlZVMzN3?=
 =?utf-8?B?Zk1mOXhCK0VSSnhFTzJ6T1JTRXdpN015aHJMQllOSXVscFVUQUtWaHZBQUZR?=
 =?utf-8?B?aWZmYUQwRVZjVkF6THlGR2RjV2JjUHVCRGphZHBBMFZsaGw3SS9sVUpFRlRy?=
 =?utf-8?B?SUNNelNIcHBCandnNCs1V0lsK2REZEpMd3IvWjljYzR6U2dwVlhuKzB1T0po?=
 =?utf-8?B?TFZEYmhsLzY4UkRMUW12clNVN0VWOGh3UmRVQ3JkaFVDd3NSVlRVbUluanJi?=
 =?utf-8?B?d0pSRUhqWWJKYmZwVlRmTDZZc285MzNIeU1GeTdWSTFGQUR4STAyTHJyRmpK?=
 =?utf-8?Q?2eJLYCCxO8+urHuimQJcyA4=3D?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 260b75b6-bb47-44a7-1c4e-08dc28bd1879
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6382.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 15:46:20.5934
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2NTsCoofuF+v/q+gMH06P14jC6fQ89U3evfbKGllhUzJXBc2NIzsWen8MAkWTJUuCci4V2OWy7YEmlS9bLM7kCUljY/ka/sAeoX/uaKDXq1bxFsdVYXUs8nhlzL+Bbpc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7621

Hi Christoph,


On 30.01.24 13:29, Christoph Niedermaier wrote:
> [Einige Personen, die diese Nachricht erhalten haben, erhalten häufig keine E-Mails von cniedermaier@dh-electronics.com. Weitere Informationen, warum dies wichtig ist, finden Sie unter https://aka.ms/LearnAboutSenderIdentification ]
>
> From: Farouk Bouabid
> Sent: Monday, January 29, 2024 9:57 AM
>
> Hi,
>
>> On 26.01.24 20:58, Lino Sanfilippo wrote:
>>> [Some people who received this message don't often get email from linosanfilippo@gmx.de. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>>
>>> Hi,
>>>
>>> On 26.01.24 18:27, Farouk Bouabid wrote:
>>>> From: Heiko Stuebner <heiko.stuebner@cherry.de>
>>>>
>>>> The RE signal is used to control the duplex mode of transmissions,
>>>> aka receiving data while sending in full duplex mode, while stopping
>>>> receiving data in half-duplex mode.
>>>>
>>>> On a number of boards the !RE signal is tied to ground so reception
>>>> is always enabled except if the UART allows disabling the receiver.
>>>> This can be taken advantage of to implement half-duplex mode - like
>>>> done on 8250_bcm2835aux.
>>>>
>>>> Another solution is to tie !RE to RTS always forcing half-duplex mode.
>>>>
>>>> And finally there is the option to control the RE signal separately,
>>>> like done here by introducing a new rs485-specific gpio that can be
>>>> set depending on the RX_DURING_TX setting in the common em485 callbacks.
>>>>
>>> we just added the rx_during_tx_gpio to the serial core.
>>> Why cant you use this GPIO for your purpose?
>>>
>>> Regards,
>>> Lino.
>> What we are trying to implement is a gpio that emulates the RTS signal
>> itself as we do not have a dedicated RTS signal that can be controlled
>> through MCR. The rx during tx state in our case is a fixed state of
>> "NO_RX_WHILE_TX"
> Why can't the property rts-gpios be used here for this purpose?


Yes that indeed serves our purpose. Thank you for the suggestion.


Regards

Farouk

>
>
> Regards
> Christoph