Received-SPF: pass (google.com: domain of linux-kernel+bounces-58168-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Thu, 8 Feb 2024 15:42:28 +0200 (EET)
To: "David E. Box" <david.e.box@linux.intel.com>
cc: Netdev <netdev@vger.kernel.org>, 
    sathyanarayanan.kuppuswamy@linux.intel.com, 
    LKML <linux-kernel@vger.kernel.org>, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 1/8] platform/x86/intel/sdsi: Set message size during
 writes
In-Reply-To: <20240201010747.471141-2-david.e.box@linux.intel.com>
Message-ID: <0d83b5fc-03ff-b96d-a55a-57ee954fed26@linux.intel.com>
References: <20240201010747.471141-1-david.e.box@linux.intel.com> <20240201010747.471141-2-david.e.box@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-425400672-1707399748=:1104"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-425400672-1707399748=:1104
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Wed, 31 Jan 2024, David E. Box wrote:

> New mailbox commands will support sending multi packet writes and updated
> firmware now requires that the message size be written for all commands
> along with the packet size. Since the driver doesn't perform writes large=
r
> than the packet size, set the message size to the same value.
>=20
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> ---
>  drivers/platform/x86/intel/sdsi.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/int=
el/sdsi.c
> index 556e7c6dbb05..a70c071de6e2 100644
> --- a/drivers/platform/x86/intel/sdsi.c
> +++ b/drivers/platform/x86/intel/sdsi.c
> @@ -252,6 +252,7 @@ static int sdsi_mbox_cmd_write(struct sdsi_priv *priv=
, struct sdsi_mbox_info *in
>  =09=09  FIELD_PREP(CTRL_SOM, 1) |
>  =09=09  FIELD_PREP(CTRL_RUN_BUSY, 1) |
>  =09=09  FIELD_PREP(CTRL_READ_WRITE, 1) |
> +=09=09  FIELD_PREP(CTRL_MSG_SIZE, info->size) |
>  =09=09  FIELD_PREP(CTRL_PACKET_SIZE, info->size);
>  =09writeq(control, priv->control_addr);

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

--8323328-425400672-1707399748=:1104--