Received-SPF: pass (google.com: domain of linux-kernel+bounces-58495-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 8 Feb 2024 17:50:51 +0000
From: Conor Dooley <conor@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Miguel Ojeda <ojeda@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Robin van der Gracht <robin@protonic.nl>,
	Paul Burton <paulburton@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH v1 14/15] dt-bindings: auxdisplay: Add Maxim MAX6958/6959
Message-ID: <20240208-chute-bacteria-75425bd34dc9@spud>
References: <20240208165937.2221193-1-andriy.shevchenko@linux.intel.com>
 <20240208165937.2221193-15-andriy.shevchenko@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="FlNSfptlnrt2zUyd"
Content-Disposition: inline
In-Reply-To: <20240208165937.2221193-15-andriy.shevchenko@linux.intel.com>


--FlNSfptlnrt2zUyd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 08, 2024 at 06:58:57PM +0200, Andy Shevchenko wrote:
> Add initial device tree documentation for Maxim MAX6958/6959.

Why "initial"? Are there elements this display that you've not
documented yet?=20

> +title: MAX6958/6959 7-segment LED display controller with keyscan

> +properties:
> +  compatible:
> +    const: maxim,max6959

Where's the max6958's compatible? I don't see it in your driver either.
It seems that the max6959 has some interrupt capabilities that are not
available on the max6958, so a dedicated compatible seems suitable to
me.


Cheers,
Conor.

--FlNSfptlnrt2zUyd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZcUUewAKCRB4tDGHoIJi
0n2pAPwI2dXVgeT2w9eJ8Mx8aPl+Sfz7Ni3EVvM/VZ5G9VRSmAEAwijosMmSBHzh
rwVD8fmHHxZDKjGRCUw7Y2qo3JeTGgU=
=rCYS
-----END PGP SIGNATURE-----

--FlNSfptlnrt2zUyd--