Received-SPF: pass (google.com: domain of linux-kernel+bounces-58474-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <3281ec05-60cb-4fa2-8562-afa93e770159@amd.com>
Date: Thu, 8 Feb 2024 11:41:24 -0600
User-Agent: Mozilla Thunderbird
Subject: [PATCH 1/2] x86/MCE: Extend size of the MCE Records pool
To: "Luck, Tony" <tony.luck@intel.com>, "x86@kernel.org" <x86@kernel.org>,
 "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Cc: "bp@alien8.de" <bp@alien8.de>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "yazen.ghannam@amd.com" <yazen.ghannam@amd.com>,
 Avadhut Naik <avadhut.naik@amd.com>
References: <20240207225632.159276-1-avadhut.naik@amd.com>
 <20240207225632.159276-2-avadhut.naik@amd.com>
 <SJ1PR11MB6083E1876B8CFBA76F1B3806FC442@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Language: en-US
From: "Naik, Avadhut" <avadnaik@amd.com>
In-Reply-To: <SJ1PR11MB6083E1876B8CFBA76F1B3806FC442@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Ty8wL0FZSGplSGt2TWczMG5KYnJ3Z0EvQ0pZQVhiSFFJQ3JwUGpweUJoVGpZ?=
 =?utf-8?B?WHdKb1V0SU16cmZCeFo5MkZnOTV2dERQb3A5bldqQnhYRGJ6QkhYVEV3dDJ2?=
 =?utf-8?B?S2JEYStSYzM0TFFtK1QwdnJaVVBjVzJBdGhLK1BOR3pqWGxCZlpSWTE4QjlZ?=
 =?utf-8?B?OXVjMG1QN1JxNDg2dmVad3NWZWVYRmZUbTNTS2hyelMzelUrQTVadzA4Zml0?=
 =?utf-8?B?dWVHa2NmSVl3V0RZRXJ1cnkzNExjZXpyRld0WDRLZERFM3dMcG8zUDhjUm1U?=
 =?utf-8?B?eEQ1RUtKVlFtd0dNZEpzZE9NVEZydDN6ZGlsTFdFVjREYitKQy9yZENTS1lW?=
 =?utf-8?B?NGc0MEtmdVF5OVlzRy80MmFJU0ZYemZ5MkJIT1dHSVpHcmJiNU9nNzMvQWJo?=
 =?utf-8?B?c0ZvR0t0MlVuWTJxak4xdDVERnNmYWZVOElrNlFkaW45WmNiY3U4M29TNHNU?=
 =?utf-8?B?V2lSbDUzNmgxOENHd21Gb3hMVThtQ1Q5cnN3bnBLUkVEUDhEUG5hSXd1L1Ex?=
 =?utf-8?B?UVNteHc2OTNFRUdVNTREckRUSHhvNFRPb2dXbG5kSy9PTldHSlhQSndFeXkw?=
 =?utf-8?B?UFlGd2kwSmVZeklBZVNVdDR0K1JTWUt6Qzd6K2s3dnhuelp5ZW9aVi9aSVRU?=
 =?utf-8?B?UjVXL2hmeHVJMXZwQUVEa1F3RlFSdktiYnVzeHBYeCtmVyt6NmJNSWJaajRV?=
 =?utf-8?B?bXFXak1aeE1ZaStzb0VGUWNZSjRrRkVsVDd6SVJHZW9EWlRVMk4ydmN5N1hr?=
 =?utf-8?B?K2dZQWNzL1QrYnNUMDNiWGJmMUtSeWdhQUQwZWkxYUs5SjZDTkhlSStGY2lk?=
 =?utf-8?B?QkhzS09CbUM4SmhIQ3Eya2laWGNibDBYb3VHSFRjbGVmQzNnbk5YcWp3aHdr?=
 =?utf-8?B?c3htQW4zM29XNlF3czdBTjVoYy9uR2Nad1B1cmpIVmduRmFDZEsrY2NORjIw?=
 =?utf-8?B?Wm00dTNCc2lrdTU1MHM1Z2JmNGx2RGJEa2FZcEJGY0ZTR1ZTeFMycE5Pa2FG?=
 =?utf-8?B?ZGs4U0dZS3RKMmFHNE9SVEdsSXJOb2lJMXQxWGFWMlZScmUyOHI0MXFzeTBn?=
 =?utf-8?B?UHJWQ3FZSmxhODhLenBjWk4rR3ZpOTQwYktFTVgrbkRnOFNwZTZDc1RVU3Jo?=
 =?utf-8?B?RXM4ZHdUT2FmUHQwcUVqbVdXN2I3ZFdManpNQ21Nc20xRmRCSW5HVTRlVSty?=
 =?utf-8?B?b09TUHhUazZwWnBZSmVMS2txRjFxRlVSNEdWZUFNQ2V5UlNIc245dEg5WlQ1?=
 =?utf-8?B?WUM3L0tEaXM1ZkRHY3BDaTFzaGNFN1pvUi9CNG5tR3FEWUFUVFRzN2RVWjVG?=
 =?utf-8?B?YzArcXJZbkVWUTVabmcwQ0pUNnMzNU5QY1JvOE9EY1l4cWJ5aXpjYTlVSmZK?=
 =?utf-8?B?S3Fkb3NDcE54L205S2ZNdmNZS3Q4UldicG9wSXYrQWdKTkhpVjA0di94ZGNW?=
 =?utf-8?B?eXpkNXNhbkNIS3psbFB2akxqdXZ5c29RdFgzZ2xCc0l5STNCc1VmSlBjN2g1?=
 =?utf-8?B?ajVGeEJWYWxjTWZxMlJhcFlFYXNCZGNzOTE1KzRmcllCUm5pRjBZekYyUmxj?=
 =?utf-8?B?cXY2TkN3N1lOVTRVd29PTHMzb1c2VGdGYzdFaVdSUzFRY3RzTFV3UU9NNVBo?=
 =?utf-8?B?NHZhR3JQK285V3kyMmtDZzZTMjQrTkN2VHhYK1hBb0NnKzhCTDlnWldNZ0U0?=
 =?utf-8?B?UGM5N0dTbDRPNFFMOGNJVjVYS3QxMFBpZGYrdHVESGNvdEJENzljdFlBZTcv?=
 =?utf-8?B?UHJjeit5M2NGb1ZVSS9kZXdLL09nTlVwSFV3NjdHRmZEeFlpSzYvcjVtTGsr?=
 =?utf-8?B?YjBJVzlESndmUlVuNnBQYUxGQTZWb0pSOEh0Zm9iVUE2UWtuVWVVaVVBd3E4?=
 =?utf-8?B?a1dJSEZzdG0zVU1PSWM4WHJ1dTNIc1ZxM1pKaUZ0OWt4QittR1ljT0ozWmNB?=
 =?utf-8?B?VFhyK2JFbnd1YWN3NExIOWtQd2tyVHRrME96U0hOYjVxRk9rckdhcGh2VXQv?=
 =?utf-8?B?dC9IUlYveW1Nd1lIdkhmNWhNNnBtQ1o5Z09rRElwK0NWRXNGOHkwKzZaNDZo?=
 =?utf-8?B?QTViLzNwcFNNNjRRc2Rmcm51ZGtRcHlRaDZrTzBvdDFGcG1XWUp6dHZPdTNn?=
 =?utf-8?Q?4sg/W5JqPyPB/GR55YavL8LzC?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86f35735-82d8-4837-0b0a-08dc28cd2c8c
X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8403.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 17:41:26.2891
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +exFG5QNjrF8+ZDVmNSkI7ciafZQqk2CItn64EzSCusSSl7Dn67b8jJ5lusl9KKG8fMpfkMDQ92hXefmDFZc4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5804

Hi

On 2/7/2024 18:02, Luck, Tony wrote:
>> +#define CPU_GEN_MEMSZ	256
>  
> What is this define?
> 
> Why isn't this "sizeof(struct mce)"?
> 
> Or 2* that if you are trying to reserve enough space for two records per CPU.
> 
That's the memory in bytes reserved for each logical CPU in the
extended MCE Records pool. By current size of struct mce that
equates to around 2 records.

Will change it to (2 * sizeof(struct mce)) though. Feels more
accurate. Thanks for the suggestion!

Do you have any additional concerns/comments on this patchset?

> -Tony

-- 
Thanks,
Avadhut Naik