Received-SPF: pass (google.com: domain of linux-kernel+bounces-58478-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240207223639.3139601-1-irogers@google.com>
In-Reply-To: <20240207223639.3139601-1-irogers@google.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Thu, 8 Feb 2024 09:44:07 -0800
Message-ID: <CAM9d7chBixXozCQztM2WKGbfs_8C70vy6ROzKpwLSqq-upz5iQ@mail.gmail.com>
Subject: Re: [PATCH v2 0/6] maps memory improvements and fixes
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
	Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, Song Liu <song@kernel.org>, 
	Miguel Ojeda <ojeda@kernel.org>, Liam Howlett <liam.howlett@oracle.com>, 
	Colin Ian King <colin.i.king@gmail.com>, K Prateek Nayak <kprateek.nayak@amd.com>, 
	Artem Savkov <asavkov@redhat.com>, Changbin Du <changbin.du@huawei.com>, 
	Masami Hiramatsu <mhiramat@kernel.org>, Athira Rajeev <atrajeev@linux.vnet.ibm.com>, 
	Yang Jihong <yangjihong1@huawei.com>, Tiezhu Yang <yangtiezhu@loongson.cn>, 
	James Clark <james.clark@arm.com>, Leo Yan <leo.yan@linaro.org>, 
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, 
	bpf@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Ian,

On Wed, Feb 7, 2024 at 2:37=E2=80=AFPM Ian Rogers <irogers@google.com> wrot=
e:
>
> First 6 patches from:
> https://lore.kernel.org/lkml/20240202061532.1939474-1-irogers@google.com/
>
> v2. Fix NO_LIBUNWIND=3D1 build issue.
>
> Ian Rogers (6):
>   perf maps: Switch from rbtree to lazily sorted array for addresses
>   perf maps: Get map before returning in maps__find
>   perf maps: Get map before returning in maps__find_by_name
>   perf maps: Get map before returning in maps__find_next_entry
>   perf maps: Hide maps internals
>   perf maps: Locking tidy up of nr_maps

Now I see a perf test failure on the vmlinux test:

$ sudo ./perf test -v vmlinux
  1: vmlinux symtab matches kallsyms                                 :
--- start ---
test child forked, pid 4164115
/proc/{kallsyms,modules} inconsistency while looking for
"[__builtin__kprobes]" module!
/proc/{kallsyms,modules} inconsistency while looking for
"[__builtin__kprobes]" module!
/proc/{kallsyms,modules} inconsistency while looking for
"[__builtin__ftrace]" module!
Looking at the vmlinux_path (8 entries long)
Using /usr/lib/debug/boot/vmlinux-6.5.13-1rodete2-amd64 for symbols
perf: Segmentation fault
Obtained 16 stack frames.
/perf(+0x1b7dcd) [0x55c40be97dcd]
/perf(+0x1b7eb7) [0x55c40be97eb7]
/lib/x86_64-linux-gnu/libc.so.6(+0x3c510) [0x7f33d7a5a510]
/perf(+0x1c2e9c) [0x55c40bea2e9c]
/perf(+0x1c43f6) [0x55c40bea43f6]
/perf(+0x1c4649) [0x55c40bea4649]
/perf(+0x1c46d3) [0x55c40bea46d3]
/perf(+0x1c7303) [0x55c40bea7303]
/perf(+0x1c70b5) [0x55c40bea70b5]
/perf(+0x1c73e6) [0x55c40bea73e6]
/perf(+0x11833e) [0x55c40bdf833e]
/perf(+0x118f78) [0x55c40bdf8f78]
/perf(+0x103d49) [0x55c40bde3d49]
/perf(+0x103e75) [0x55c40bde3e75]
/perf(+0x1044c0) [0x55c40bde44c0]
/perf(+0x104de0) [0x55c40bde4de0]
test child interrupted
---- end ----
vmlinux symtab matches kallsyms: FAILED!


Thanks,
Namhyung