Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp484023rdb; Thu, 8 Feb 2024 11:21:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFIZGQC9mvoy6w4oTk4AscWRFodH+y+XXVWsLN9URStJXkuOM9MA7NQPkUNRWTs4sULPtaC X-Received: by 2002:a05:6a00:1a:b0:6e0:4e40:3bee with SMTP id h26-20020a056a00001a00b006e04e403beemr173653pfk.25.1707420108335; Thu, 08 Feb 2024 11:21:48 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707420108; cv=pass; d=google.com; s=arc-20160816; b=kqyoW5ZvptAEdCfhkEnS7aiIJA2hRPa1f1MJCqwtqSwYOxgvZjBtPGYD/l8LevDiW0 /HKrlc/OekOJnvsl7rpQkLIq76TYR10LkjM7PFFnzVK2uhdDwJVyH0MifCRfMN82vwES btVPRfx+j0REnmEvsxZqAVLDcZk6/0ZsogS6JyDKg0Nv7y1roOVNyDPIntclE5CPHQi+ sTIToFY1SbMm2s7iRBGsuN82PKAemPVQ8xp6FCfd/v5sEN5uexjBBaUfOsYuaMX6/K0E GOwB8630AjW8RLaO9nlc+mCzP/MnctT297z/4qd0E1UhhF2J8noo535fxRMAfJS3mnRS HVwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=202GKaA8C1i5cx4LlHBZXcPKNf6nXe/ES82zbqrpd+0=; fh=nlljinSm492EA0Tt59TPD4ZXZbN1t6FbmSUG8VejWDk=; b=OZ23YjFJQAxQbXxeAf5cha1H+f/goh/um4Y39YBJ5QbmzhwG5F84cZWJJVyb8A6f2A 9NZkTp6EEiotex4bxsfxEvc2NxP4enPKZxG/9LI3UqIAJ85z31RnKWqFFHpzNijv+xpL dTE+AD8Wt45BF/r4gsGYeiJM2A6d1vA+dHiWF4bYVMzGHJpbMg/GXoHNwDim5E16C9yp G9E5L2EaO0tLJK9Q9DX1nhsE007zRi9jP71dX4PmJxxTwatI0Ghf+k9VBPiclEmY1jMe DPbPlQIG9QwmfDSuZe6xvOhrP5kGW/3pp4XvDJOOMHNoAdc2lJ7M4EZr4BYE91nyyuBA NMrg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="YV61E/ar"; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-58598-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58598-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com X-Forwarded-Encrypted: i=2; AJvYcCVO2BY7RvOKxkIJwfnp+H1SsnvXqH5/7kuHblahpkfjDRGm73rqggid615mkcSFD+t1lYA+AjrZjMkwufIZ3ynOjAT/OryTrc/TFRfKuw== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id lb12-20020a056a004f0c00b006e0733b3429si132478pfb.340.2024.02.08.11.21.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 11:21:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58598-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="YV61E/ar"; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-58598-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58598-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DC9D528EE4C for ; Thu, 8 Feb 2024 19:07:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B2F2A288CF; Thu, 8 Feb 2024 19:07:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YV61E/ar" Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C6CD25601; Thu, 8 Feb 2024 19:07:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707419242; cv=none; b=hEhN33kDsnNUtUKFEDeVDdrD6KsMoZEAjR6+JXInJMtvwJn5vaKECSLsIG1I9UfkhrieCgOoV9ZgjKhpF5EpnIM/EUceb/+wUcg5zkbEWzoWc+IcOrPUndCzc2MCjPSmgwREkX+Y/hBz6jQrhk7Sjiv9FwfiSj1UtxG5phwbGOQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707419242; c=relaxed/simple; bh=AZ6nQb+M1vD/2zX5upW9ouxqeYE6QGKcCE/8DY0UebQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Wst6HFgdfQKja+5yM+pEqcU4pN9446gke8AYKiCpQiEUmYMRF8GAJfMjecXX7J2Q1RoN/c9WI5nAFtVVM8ZROsSPovZdopksDQTO5uTlx0ZmbyzzVhBrHMiQXp1yX/aW56HgiQ2Kzoidhrou8yqeG91v3CmJkYU7Gnm/2XeJyJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YV61E/ar; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3bd4e6a7cb0so45045b6e.3; Thu, 08 Feb 2024 11:07:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707419240; x=1708024040; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=202GKaA8C1i5cx4LlHBZXcPKNf6nXe/ES82zbqrpd+0=; b=YV61E/ara/kkIUYAtCwjGjxniHntVcIzrVYz5b4hqEJ4ZmRn+FZaUIRTqPgIU/+GrP QcandcyNGWP9rhwxWDSDTtH29qD+MLjipibhJQ7wivhwc/fRQdm0fT7ocenbU33HQphj 8mPuMPIZuXFE/d0ifYto7fQYq9PAU3n5LcOACf9HikgMoBILfJmD56deF8DeF2pOFjeS Z8AMeknTM+aQMqRgnKVs3O9N5TnunnvYmZeizDBGPTOixieEBQ68OPrZ0LzL1AZYAUh7 /oO105E6pnBuWn1cpcfzUpNDGsZni8qpT6Wx7Hi9lnPV9xnzbRgJ4xuMAvRckCNUii3O kOkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707419240; x=1708024040; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=202GKaA8C1i5cx4LlHBZXcPKNf6nXe/ES82zbqrpd+0=; b=BQ0NSpkz58zjBywW7gUcFBIBK6A5XX7QOhulBvH0DvFNnLrQm5E6hj8ycxQRs4Qftd 5DipMG97Z4wOdziS44KSMRPIY8TeucGNNIaoZd+g7v0uWHFmMm/3WrargbNVaY94sPY1 4qGhrSMJRWvUtfDJX8oIT0g2DC8Q8feEKvUNaUdZ7HTpnaTs5h48j8W0940leArl7XGY +iEDs2wHluJi2kjI4rNjclTxNVJ4QdyjnxbxDZCqonjdLkL+w7MGMoSUs80zv3CZiKbi glrT6b1K9vNlPaSSK6ZMtXFb5FoHR8EeOVVz3wTRZiJXhpYC3UzZbDW3IgxgnWfg1otT w2Cw== X-Gm-Message-State: AOJu0YxjxD7vgis1xDDHhb31uxoONYTHzilTEOPbQXEM7tP0v0TSrmPG d9oq63k6UCZ7sB8NFNZoCflti5Ic1m33OvSIawIr95qndEglGRA8OUUrNoXiNgtIltVfKMfifmP BPqFegD9mazxdbt6C0ulYvDe+zp0= X-Received: by 2002:a05:6808:1524:b0:3bf:f3a2:cd8f with SMTP id u36-20020a056808152400b003bff3a2cd8fmr279809oiw.41.1707419240598; Thu, 08 Feb 2024 11:07:20 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240130091300.2968534-1-tj@kernel.org> In-Reply-To: From: Allen Date: Thu, 8 Feb 2024 11:07:09 -0800 Message-ID: Subject: Re: [PATCHSET wq/for-6.9] workqueue: Implement BH workqueue and convert several tasklet users To: Tejun Heo Cc: torvalds@linux-foundation.org, mpatocka@redhat.com, linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev, msnitzer@redhat.com, ignat@cloudflare.com, damien.lemoal@wdc.com, bob.liu@oracle.com, houtao1@huawei.com, peterz@infradead.org, mingo@kernel.org, netdev@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Feb 8, 2024 at 8:56=E2=80=AFAM Tejun Heo wrote: > > On Wed, Feb 07, 2024 at 11:02:37AM -0800, Allen wrote: > > https://github.com/allenpais/for-6.9-bh-conversions > > > > I am holding on to the patch that converts drivers/media/*, as I haven= 't found > > a right way to replace tasklet_[disable/enable] api's. The rest should = be ready > > in a day or two. > > Yeah, we'll need to add something to workqueue to support that. As for th= e > rest, looking at the code, I think tasklet_kill() should be converted to > cancel_work_sync(), not flush_work(). > Ah, Thanks for pointing that out. I will update it and get that fixed. Thanks for the review. --=20 - Allen