Received-SPF: pass (google.com: domain of linux-kernel+bounces-58622-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 8 Feb 2024 16:29:58 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf tools: Remove misleading comments on map functions
Message-ID: <ZcUrtpnj7jx9X2kd@x1>
References: <20240208181025.1329645-1-namhyung@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240208181025.1329645-1-namhyung@kernel.org>

On Thu, Feb 08, 2024 at 10:10:25AM -0800, Namhyung Kim wrote:
> When it converts sample IP to or from objdump-capable one, there's a
> comment saying that kernel modules have DSO_SPACE__USER.  But commit
> 02213cec64bb ("perf maps: Mark module DSOs with kernel type") changed
> it and makes the comment confusing.  Let's get rid of it.

Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>

- Arnaldo
 
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/util/map.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
> index cf5a15db3a1f..14a5ea70d81e 100644
> --- a/tools/perf/util/map.c
> +++ b/tools/perf/util/map.c
> @@ -553,10 +553,6 @@ u64 map__rip_2objdump(struct map *map, u64 rip)
>  	if (dso->rel)
>  		return rip - map__pgoff(map);
>  
> -	/*
> -	 * kernel modules also have DSO_TYPE_USER in dso->kernel,
> -	 * but all kernel modules are ET_REL, so won't get here.
> -	 */
>  	if (dso->kernel == DSO_SPACE__USER)
>  		return rip + dso->text_offset;
>  
> @@ -585,10 +581,6 @@ u64 map__objdump_2mem(struct map *map, u64 ip)
>  	if (dso->rel)
>  		return map__unmap_ip(map, ip + map__pgoff(map));
>  
> -	/*
> -	 * kernel modules also have DSO_TYPE_USER in dso->kernel,
> -	 * but all kernel modules are ET_REL, so won't get here.
> -	 */
>  	if (dso->kernel == DSO_SPACE__USER)
>  		return map__unmap_ip(map, ip - dso->text_offset);
>  
> -- 
> 2.43.0.687.g38aa6559b0-goog