Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp492851rdb; Thu, 8 Feb 2024 11:40:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IFyGQWXNrRfUopNeYIiODDQn63C9cdCXnMC6sfPw3M+Uy1khUyhabt6lanpLhHBm1ehePxK X-Received: by 2002:a17:902:e80e:b0:1d9:f342:54c6 with SMTP id u14-20020a170902e80e00b001d9f34254c6mr6023861plg.2.1707421227971; Thu, 08 Feb 2024 11:40:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707421227; cv=pass; d=google.com; s=arc-20160816; b=lzpcL88ObgoShy8tYijfp9q3rnbrwCEU8YngCFmZssmqrqk5kvLvGPnyJOoh68kPM3 3CJdY/0T7Yi9PwbEnD9HNJdlp8OsxLQNFznDG3mskjwbwTstBN4BLIpJoaeFH1swDyGC kuZe3h/Ztr0n1bHx9ZelyZOZdO5iWfHIn1s0sQ12zqcCmUlNo5gRgTEbPQf+AinjK+Fp eX12lxtdAaSxKfe+kY1iwhpyQsZ24pvNwRf/f/iZzQpuozI/u4TU6mumeWGZXi0j3uWA HNl/1rbj9+YuLnpHs8zJZWt2mlja9DarteATsHdzEPfet8B8V9iHqpg8kuLBwxr+iJQe wGOw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=uQ9ZvCPxOXDHlqGQaVlrxREOk6cQTpNHPWgCRf8e/qY=; fh=wkRSUe8/H0DGTb7r7fejperQGOh1derU2D0zz5OFO4M=; b=qSig7ivxZhP5noJ86LLRWMf2rnsv8sjoHuDd7Mtq4E5mLdnDVIxstNttE9PHG7AMBJ G8cMLoBs0lsRB5ON2OisuyNYGHPLHe/K4s+EJucDerAujxXWSphQ/wyqAtAz9JoMUdTy ryO5FbV24PK+/N6c6jvx80AzhA4Cj7IYx2zu9HnzlHF0zcjNErWQSznnDCEoKT2K07LO zY71EfdmfEik7Wo4JJY7OXFvfIwQq4A5nCik8+z80sz3xKia98TSWJXrZDu6regk6R7y EUPZGEJOKfmh7TnNU+86hS2dJ5piWq8Jm5PTFD+Ow45c+U2fgyXhj/0oYB1H/ZZDESTH oPFA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CLHn4PJW; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-58623-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58623-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Forwarded-Encrypted: i=2; AJvYcCWjMWosH4IYY1sOiB4Hn86kyzzWfXrsokQsMQc2eVZzSO7qzULf+KVgVjzIKK7yTPKIThGRWjSiPdq7RE0XJ+4FcCdep9fZMnHjYtIusw== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id bn10-20020a056a02030a00b005d8b6894062si316688pgb.653.2024.02.08.11.40.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 11:40:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58623-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CLHn4PJW; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-58623-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58623-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 52BF0295468 for ; Thu, 8 Feb 2024 19:31:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 70398381C7; Thu, 8 Feb 2024 19:31:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CLHn4PJW" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2951376E4 for ; Thu, 8 Feb 2024 19:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707420677; cv=none; b=sui56bG/yuCBAMZbDTqhNBJcsgx9zVvZm2rwVQqpcsR6FgqyDqsdXBx4Va0ykw31R8l6jRN5ZJO1vSJEx1OCJkJY9zoxAHKXU5506xE0CGmbMqxAZAhKbC6QO8S0WW/REmYoPe2M0csF34xxymjoXRu06BVdUhA/KLyN/Npn9vg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707420677; c=relaxed/simple; bh=JTnL6CBuzBPqsrfYa0gkSIbWG2+BlvSoeYR5H7CNbok=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kNjT5hr6hwS28NJyu0KpvjMtqcc5iAp64tdvrbFDQ028w1x1dyAWBDmDZAUWfTpaE7SxURS7e3+nrCN0zf55ZvWUeM3Csuz5wUe14LWmuZSOpVd/pVUFgfpa+hCVthi4t1pXrJgZDAUT8ZM5/l6wpog35M5tZZyIK3CxBaViZOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CLHn4PJW; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707420674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uQ9ZvCPxOXDHlqGQaVlrxREOk6cQTpNHPWgCRf8e/qY=; b=CLHn4PJWHww9/k/TSvL/9l6Swn+XYMf0fXSOD3vs5hezOtl4Bl4HUCryQzYVl+Kic9cskH duZJBTcQ/XyLZT2FytMvAYhUMdaZVfLnpYmRM1BZP/y4T+rGhGoNOd7PuzbNWOO9lcpnAK 67aotvbzD4IqdeS3eADgetEYHVxhZoU= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-1242pt5sPl-ox0AJX4MFyw-1; Thu, 08 Feb 2024 14:31:12 -0500 X-MC-Unique: 1242pt5sPl-ox0AJX4MFyw-1 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-558b04cb660so212058a12.3 for ; Thu, 08 Feb 2024 11:31:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707420671; x=1708025471; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uQ9ZvCPxOXDHlqGQaVlrxREOk6cQTpNHPWgCRf8e/qY=; b=rwgUsDomc7V83ub6XSLR3276I5an2zL+apDkIc05rfQmU1fBAuKvChRA0LWHId4eU9 VogaBVulNPC+3KYBFlY2RIfFkhJvt+cNq8jm79HiwgD3i5PWmRFArmy0oqJ2EKshvOPr tp1hgrICgp5Ro7sJNnJXpveZ5lm4nzzmgHJHDn0TogIm1mV0NGsrQd/GKCDztHT73HgR w8HL+80Uk/L+5JOBl0ypFmWzehHTz5EaP0FeuugFOARPHMO59gYEyrtlhY7xde8F3TFi BcrbuZkPvECZEwt4tkvUnzhYFV/GVAKdjxQWnbGND5NY/w+bNt9keVbXQBuU9VX3+1GN B8ug== X-Gm-Message-State: AOJu0YyQ6pHVIK+GsjpqMFOs5WJdTo3SnWOYvpEZXYjtROzX/rztEYac ZU/GPgrwi8QFCppp1fNDpaH8UCGuGOblZVoAoEK2hhTNuJmY89EJDl0ZxZVto5WsUMi1Px4XiMn 3wimX/ZCVgIqIdf7oyU80uXKK4V4dJipnaZWXJczuP6urGuqgELJiEuy/0G9e6dpIHnLYRw== X-Received: by 2002:aa7:cf95:0:b0:55f:ec52:73c4 with SMTP id z21-20020aa7cf95000000b0055fec5273c4mr149356edx.34.1707420671056; Thu, 08 Feb 2024 11:31:11 -0800 (PST) X-Received: by 2002:aa7:cf95:0:b0:55f:ec52:73c4 with SMTP id z21-20020aa7cf95000000b0055fec5273c4mr149344edx.34.1707420670739; Thu, 08 Feb 2024 11:31:10 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXcg+MkJnBi7LuWObXkd21CPr5jg44VOWU2Tp6hczV31yWw/visww1h4gsVEhYRIbrjDNlJ66aHv626fudQWiW4lziVNxrQPY32V+YTnr8Hf1XinfvXKd3q1nnMXytRG6FYkC15kTmd/TfYEmUkDRhe1rdLYFgJMkYhWVXXSHXuUAViYGHCvR/OQ/937C8v44WkZRKc Received: from [192.168.0.9] (ip-109-43-177-145.web.vodafone.de. [109.43.177.145]) by smtp.gmail.com with ESMTPSA id n22-20020a05640206d600b0055ff708dee3sm41793edy.11.2024.02.08.11.31.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Feb 2024 11:31:10 -0800 (PST) Message-ID: Date: Thu, 8 Feb 2024 20:31:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] KVM: selftests: x86: Use TAP interface in the userspace_msr_exit test To: Sean Christopherson Cc: Paolo Bonzini , kvm@vger.kernel.org, Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20231005143839.365297-1-thuth@redhat.com> <20231005143839.365297-8-thuth@redhat.com> Content-Language: en-US From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26/01/2024 20.32, Sean Christopherson wrote: > On Thu, Oct 05, 2023, Thomas Huth wrote: >> Use the kselftest_harness.h interface in this test to get TAP >> output, so that it is easier for the user to see what the test >> is doing. >> >> Note: We're not using the KVM_ONE_VCPU_TEST() macro here (but the >> generic TEST() macro from kselftest_harness.h) since each of the >> tests needs a different guest code function. > > I would much rather we add a KVM framework that can deal with this, i.e. build > something that is flexible from the get-go. Allowing tests to set the entry point > after vCPU is fairly straightforward (patch below, compile tested only on x86). > > With that, my vote would be to have KVM_ONE_VCPU_TEST_SUITE() *always* pass NULL > for the entry point, and instead always require sub-tests to pass the guest code > to KVM_ONE_VCPU_TEST(). I think having the sub-test explicitly specify its guest > code will be helpful for developers reading the code. Yes, I agree that sounds quite a bit nicer. I'll give it a try... Thomas