Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp506191rdb; Thu, 8 Feb 2024 12:07:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IEHq3S/QzqkmYcckZGuQiSVluQxlqRlPBQKvVhV78i2IhRe+4KrLPirG76n38J0hQbRbhqK X-Received: by 2002:a05:6a20:8f07:b0:19e:99ee:3b23 with SMTP id b7-20020a056a208f0700b0019e99ee3b23mr707888pzk.51.1707422865922; Thu, 08 Feb 2024 12:07:45 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUtV3IRReBBgkZMfq1nHKBuNYpEiTx60beke/PL+O6f/0yjUZq2TNOBmFJBOHS5hduJiC1w51iw2nS0mIc19sSzIsBvILQdjWo0aovlHQ== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id ka13-20020a056a00938d00b006ddc80e5366si237543pfb.86.2024.02.08.12.07.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 12:07:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58646-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=BatepFwE; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-58646-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58646-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 917712898FE for ; Thu, 8 Feb 2024 20:07:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7F2F2383A9; Thu, 8 Feb 2024 20:07:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BatepFwE" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4587C37711 for ; Thu, 8 Feb 2024 20:07:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707422859; cv=none; b=JZeT/FTJtGfiprnAdJh7KJEe5t1oWA8Lz6hT9Ww1COejiCrTKeueSw4MlTZElo+URenZkUI4LAgOv6sD/6iV7hgP3XXlqwSphpC40LAi8JPJA+nBvGwmSzRJn6+fbJp2WfhSIiq7nsDWrOCTII+tsPxHuObRV71kFnKjcB5XaJc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707422859; c=relaxed/simple; bh=jEFILA4AOQFKP5N74g+wybLTvwBqH/t+DpqAbP4ze7w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LCuPlhN2RfYvNcjAoRKg3edZ22dVv+1mYPfPEsg+OoYPQQbcC7btjZd8h4sBgGxQ1XXR9YZWufBV1/KL/7IjmV+ETfNJDnF0TJbIc0YOH/4tKKGJheb5cGSYQ9PuX91WyC9u4NyihPUxydhE19JfrD1bHilZ95RWRLjTs+AdK6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BatepFwE; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707422858; x=1738958858; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jEFILA4AOQFKP5N74g+wybLTvwBqH/t+DpqAbP4ze7w=; b=BatepFwE/5EMDIIUvc1oScRNASq4mwjchjmvL5CIlFmGYFhKbqmcDV42 IM4qO2wioX5+vPK9Zqu6iEMMeQYeJ+NLIiVs2Gu/GOJVroVFdSv/z1aqv HQxQ5Mt+TzHsC21ZB+1Rp3DhlcLLFyywsFu7pKAZtg/qeIlnn3p+nvZBq UoCTLMH5cDVXp58E4LgRCQxXENb4cs4KAn0QjbsMiS5kmRtNjnb7zA5Hj rwkhZutChhJF56oX9YgJUilY/Hi+DkL0GuFqJ/DOcMZUjDExPDSSU55Iq 9eR43IM902lyo9oXBSxfVLkwjO63gKxAHGbXgVNVM7f321dT3qxdwWLIM w==; X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="1463070" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="1463070" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 12:07:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="6388559" Received: from udig-mobl1.ger.corp.intel.com (HELO intel.com) ([10.246.32.229]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 12:07:35 -0800 Date: Thu, 8 Feb 2024 21:07:32 +0100 From: Andi Shyti To: Lucas De Marchi Cc: Yury Norov , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andy Shevchenko , Jani Nikula , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Jani Nikula Subject: Re: [PATCH v3 3/3] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_* Message-ID: References: <20240208074521.577076-1-lucas.demarchi@intel.com> <20240208074521.577076-4-lucas.demarchi@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240208074521.577076-4-lucas.demarchi@intel.com> Hi Lucas, .. > +#define REG_GENMASK(__high, __low) GENMASK_U32(__high, __low) > +#define REG_GENMASK64(__high, __low) GENMASK_U64(__high, __low) > +#define REG_GENMASK16(__high, __low) GENMASK_U16(__high, __low) > +#define REG_GENMASK8(__high, __low) GENMASK_U8(__high, __low) I was hoping to use directly GENMASK_U*() functions. Andi