Received-SPF: pass (google.com: domain of linux-kernel+bounces-58658-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 8 Feb 2024 15:20:50 -0500
From: Frank Li <Frank.li@nxp.com>
To: Conor Dooley <conor@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>, imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: pci: layerscape-pci: Convert to yaml
 file
Message-ID: <ZcU3ohEg5Z1ky+/W@lizhi-Precision-Tower-5810>
References: <20240207062403.304367-1-Frank.Li@nxp.com>
 <20240207-yoga-mobility-90a728f6342c@spud>
 <ZcPCn8q7viB/qcOH@lizhi-Precision-Tower-5810>
 <20240208-jarring-frolic-8d4c9b409127@spud>
 <ZcUs16+Z+I4m4q00@lizhi-Precision-Tower-5810>
 <20240208-revoke-doorman-5ba34f39c743@spud>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240208-revoke-doorman-5ba34f39c743@spud>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?RcHzwHFCcHFkeI6+IsugqByqoDwZ3heK5UMUtD/rycf68WrRXd8SBTZouxQy?=
 =?us-ascii?Q?H5tcgwXf3FnszuxbrjF9b918NhAkMA093l/mwxqY5zSfZX7AgyMLOKMxBAZP?=
 =?us-ascii?Q?V1LOHcpKDmjja+TGEPICaXcj4w111KiNrxLFwZYEpiHNHCPLv8Re8rMDnM1I?=
 =?us-ascii?Q?+lzwj+kUFygF0kuxsVM8wgiCO2ZDP6rVjzJpGGytxke00lB5dpuSGU8uetxM?=
 =?us-ascii?Q?xUeZ5SWFYPFB9nqxaBmGesVLWrKl/C/14fwmqoIEWh97pxFUqffUiddbPVdB?=
 =?us-ascii?Q?aN/uIJ5zpY9ZThGWbOKummTUFMM3ox/sVSE2mrRpUOlPGUQeyfoZrRWudN1e?=
 =?us-ascii?Q?WClTe5jrM1hwF8y/D6uxHL1G0AbWDTBi/nATsjYtt0HaEkOKSBRdjWzM2hIu?=
 =?us-ascii?Q?6oXxi590iW9SoavUT406crGiuC8Vu9u0B5xkvmsZ7Hl75jflKLp4BaQMMkSR?=
 =?us-ascii?Q?nHFuTz1y38cbcQia9nSqhQFeJobZIFALyyvbvRDDqm6GT5DqOIteVhOwu0gW?=
 =?us-ascii?Q?Uera0pWFUgzZgNHpsNZ4KgIJc8rCzDyUCA98Ef83N8bfsAhc9GZfPJosWhJG?=
 =?us-ascii?Q?bxcU+z699pIj/gvm5HR2Kmo/DwdOiUprkbK7dc/tRN2PYAw7b91B6wXeV8AT?=
 =?us-ascii?Q?/lzmeKJ10v3cVjdUYj+sv7nJaxevVSMNgyvuU3NSWdmaFUv7uk+1bmvlUX9/?=
 =?us-ascii?Q?etZjlBoKcXsN3gmAkjYxEa3tEA6hDWR7qkGorlYRvpJvuH4m0x1vB0imEfLT?=
 =?us-ascii?Q?5CAJ35qLaf6SFvPDxGtHokF59xU5MfCaED46cNvZKdtDS+ciCYzhPK9tqTyG?=
 =?us-ascii?Q?6xZ7LCVtWpYGGFZcPbeyvlSjSeJf5jx4lXvbKg8f0DKkZKZCS9X/W1ZTdw5e?=
 =?us-ascii?Q?HCdV7wox9/IqAJTmlh0O5NT5m72SPoSPSSH89KQyCKDTJ/zL/9TyqQePHPdT?=
 =?us-ascii?Q?vNQ6CZSxU2yB5uIo3dFuC1ChiSsJz3Zq5q0cQ5jDuyNM20vmV+NS1exUSrzX?=
 =?us-ascii?Q?qEYs/drtETWG7RZv9FC2RWcqASeFN51zIO/hI8jo8REhbEQk/ZPJ8fWaKauU?=
 =?us-ascii?Q?r8ZoLBYyhZJNVhG0mf6+Iw2T0OqlqX6fRQFOo8qX2tesTr5Vt/935/eHm2WW?=
 =?us-ascii?Q?AWU4pa8eUV5L9RV4hMDdHVwLFRMP+MGNRbl8uunKuySkxLmpM/cwso3HXx9Z?=
 =?us-ascii?Q?l5XbepMoVdUpFek4lt24F9VNOLgojTuj5JeP5bjgcl8gDH1jTgtNP8S2I9sO?=
 =?us-ascii?Q?tAapgcCmu1ioR7guqXr54HtCc4lZ8HF0hOzNqwXXYKXbVb2QONB7Cvsebm5i?=
 =?us-ascii?Q?Jn4+ZtwVWIwfTj+qArpyUZluYvwIpR/79FQsPqVdq5pGZ1T28a6kJSIcMiTg?=
 =?us-ascii?Q?d3fhLjPLFFuCKozyrL4yyG2Xuud/GRIL1sz0V/SDSE0lLc1c3K+cre4syp44?=
 =?us-ascii?Q?91ab2RAhH5QxTrZRqpX4TlBQhs6xnh73e4XEGkkpRDg8Toijy7Lq+Vz0I1zH?=
 =?us-ascii?Q?q1pAGGQb5Ap94LD3bIzMEtGtnueyPaJKPKz8WMaivNxYocuFkwwx3sb5tHdT?=
 =?us-ascii?Q?xxrVvI/nYTEV3CaPtfzRU3N+2BqsX9Uu0KQoHAgx?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 648423bd-3437-4c70-74f9-08dc28e3758f
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 20:20:57.5804
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D/yErgZ/dGQHIEwqixoXUmOOwSnJolSYPoIThhRu8km8SoPsHWpY4pNf/LW2wdNxN75cgzdZf4I+ZSvB2CdYvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8402

On Thu, Feb 08, 2024 at 07:44:59PM +0000, Conor Dooley wrote:
> On Thu, Feb 08, 2024 at 02:34:47PM -0500, Frank Li wrote:
> > On Thu, Feb 08, 2024 at 07:12:47PM +0000, Conor Dooley wrote:
> > > On Wed, Feb 07, 2024 at 12:49:19PM -0500, Frank Li wrote:
> > > > On Wed, Feb 07, 2024 at 05:17:55PM +0000, Conor Dooley wrote:
> > > > > On Wed, Feb 07, 2024 at 01:24:02AM -0500, Frank Li wrote:
> 
> > > > > > +
> > > > > > +  This controller derives its clocks from the Reset Configuration Word (RCW)
> > > > > > +  which is used to describe the PLL settings at the time of chip-reset.
> > > > > > +
> > > > > > +  Also as per the available Reference Manuals, there is no specific 'version'
> > > > > > +  register available in the Freescale PCIe controller register set,
> > > > > > +  which can allow determining the underlying DesignWare PCIe controller version
> > > > > > +  information.
> > > > > > +
> > > > > > +properties:
> > > > > > +  compatible:
> > > > > > +    enum:
> > > > > > +      - fsl,ls2088a-pcie-ep
> > > > > > +      - fsl,ls1088a-pcie-ep
> > > > > > +      - fsl,ls1046a-pcie-ep
> > > > > > +      - fsl,ls1028a-pcie-ep
> > > > > > +      - fsl,lx2160ar2-pcie-ep
> > > > > 
> > > > > Where did the fallback compatible go?
> > > > 
> > > > So far, no fallback compatible needed now. each devices already have its
> > > > compatible string.
> > > 
> > > It used to exist though, have you checked that u-boot or *bsd etc do not
> > > use the fallback compatible? You also need to mention your justification
> > > for removing it in the commit message.
> > 
> > This commit just convert binding doc from txt to yaml. I just make sure
> > which equal to what descript in txt.
> 
> The text binding does have a fallback compatible though:
>   EP mode:
> 	"fsl,ls1028a-pcie-ep", "fsl,ls-pcie-ep"
> So this is a change compared to the text binding, without any
> justification for it being okay to do.

Okay, I see what your concern. I think old txt is wrong. Or try to work
as it, but actually not. 

> 
> > If there are someting wrong in "uboot"
> > or "bsd", we can fixed it later.
> 
> If other bits of software are using the fallback, you cannot remove it.
> 
> > I checked driver code. exited dts tree
> > under kernel, which use unexited fallback compatible string
> > "fsl, lx-pcie-ep", which should be removed at dts file.
> 
> What do you mean by "unexisted"? It was in the text binding, so it is
> perfectly fine to have it in the dts. Given it has users, I don't think
> you should be removing the fallback without a very good justification.
> 

No driver parse "fsl,lx-pcie-ep". I can keep it as equal as old txt file
and remove later if need.

> > > > > > +  reg:
> > > > > > +    maxItems: 2
> > > > > > +
> > > > > > +  reg-names:
> > > > > > +    items:
> > > > > > +      - const: regs
> > > > > > +      - const: addr_space
> > > > > 
> > > > > The example uses "regs" and "config". Where did addr_space come from?
> > > > 
> > > > Example just show pcie-host part. Not show pcie-ep part.
> > > > pcie-ep part need 'addr_space'.
> > > 
> > > Okay. Again, please mention where this is coming from.
> > 
> > Ideally it comes from snsp,dwc-pcie-ep.yaml. but it is use 'dbi' instead
> > of 'regs'. It needs extra effort to make driver code algin common
> > snps,dwc-pcie-ep.yaml, and update exist all dts files.
> > 
> > I think it will be deleted soon. 
> 
> What I am looking for here is you to explain in the commit message that
> the endpoint driver in linux and the dts have always used "addr_space".
> Checking that there's not a u-boot or *bsd that uses "config" would also
> be very helpful.

I confused. Actually this two part PCIE-RC and PCIE-EP.
PCIE-RC using 'config'
PCIE-EP using 'addr_spcae'

I check old txt file, which have not mention it. I can remove it.

Frank
> 
> Thanks,
> Conor.
>