Received-SPF: pass (google.com: domain of linux-kernel+bounces-58723-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 8 Feb 2024 13:32:33 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Dan Williams
	<dan.j.williams@intel.com>, Arnd Bergmann <arnd@arndb.de>, Dave Chinner
	<david@fromorbit.com>
CC: <linux-kernel@vger.kernel.org>, Mathieu Desnoyers
	<mathieu.desnoyers@efficios.com>, Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>, Vishal Verma
	<vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>, Matthew Wilcox
	<willy@infradead.org>, Russell King <linux@armlinux.org.uk>,
	<linux-arch@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
	<linux-fsdevel@vger.kernel.org>, <linux-mm@kvack.org>,
	<linux-xfs@vger.kernel.org>, <dm-devel@lists.linux.dev>,
	<nvdimm@lists.linux.dev>, <linux-s390@vger.kernel.org>, Alasdair Kergon
	<agk@redhat.com>, Mike Snitzer <snitzer@kernel.org>, Mikulas Patocka
	<mpatocka@redhat.com>
Subject: RE: [PATCH v4 02/12] nvdimm/pmem: Treat alloc_dax() -EOPNOTSUPP
 failure as non-fatal
Message-ID: <65c5487174fbd_afa4294e7@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240208184913.484340-1-mathieu.desnoyers@efficios.com>
 <20240208184913.484340-3-mathieu.desnoyers@efficios.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240208184913.484340-3-mathieu.desnoyers@efficios.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ES1ho+1IvecBJGh91RYFO6LDE7k5wucevZlYUhEc1QQ+uskPPNrjZ6mgmt5z?=
 =?us-ascii?Q?A7evKljokx709+UnDAT3OdXzWFdwovZPkJ9Iou3MABpS3lp7f2Gb42cMDICy?=
 =?us-ascii?Q?ZowUBN/lYO32HYKEwHEsoo6+6OEgmUpExUpBsztIySrapOqOUBt7Dk+XR72L?=
 =?us-ascii?Q?G6tlWfiSRl+jVNXZQnPN1wHUBk/xUK/SCcfvIOf1t5DAI52oeHcASAxWxNQz?=
 =?us-ascii?Q?vUJpuF8RA8q7yr6vb4Hom7sa/99IJ05SEIuhgBg3UmUEwV0r7jfnr5uhK2cP?=
 =?us-ascii?Q?XyWGh7MXDgX4qPjp9MzI1i7v4L4gk0mU2smYRK+UqHXZsN8ax0PpMmyR7MVj?=
 =?us-ascii?Q?a9DYmzb+mz5nqI7ZL85ymXIiZStjLdI6ycoJ18EwfSIx85+LexIIRQv0BuHr?=
 =?us-ascii?Q?nH/BBVo47RslZCnyVZBl9/iXJAMMkNjopT+nwmQon+jYg4fhs0cpDIMjqBFs?=
 =?us-ascii?Q?RX0Wq3sXDIAwrjHcA3i+701B6qRggS1Tl7zvxffnPjHeEqYSqbmXtZ/hOmkO?=
 =?us-ascii?Q?83nl9424xVXhEye2rRcVRWcqr+TDCnORYzgTbZidTXaGzV2sufm2gUsVD2Fd?=
 =?us-ascii?Q?taP9Cvfygc1MbLN2cDx+M1tpiqGLe9T1w/QYMFu9eI+/GrWmm8C6Xq0OD5Ox?=
 =?us-ascii?Q?y+JeoFQqEWcH+xRF76le9wwY/vwWg4cj2iZqtJLBUJRxWEq28IdCSCGJs8wc?=
 =?us-ascii?Q?w1OWqDN/7ebrd3lNE1Z9OniQ0cRUqqpHqwKqbgI3a9/LC+sbjQVFPNSMh1UE?=
 =?us-ascii?Q?PJNgomoWOB85/g5H2MHtrdEzjUbrx6q2BkKT1r5x/uivNYtBEyanBt0PG6X7?=
 =?us-ascii?Q?K1wI66t6vVuMyv1QSp7BNqecICD6MaACUfqe0cmP5PXcAoLnstY2T2jKdKIC?=
 =?us-ascii?Q?dJCLBIR0m62/3/VysjZAKGjpdch0duL5Ws6AKJ2MAg53O1Aux7N7MlBKFXmW?=
 =?us-ascii?Q?6qyX97J7aOptKlKQ2qzS/79jrqxtIj4HsH+ImMvZIcSS0j1Oa51L5uQJj8Pb?=
 =?us-ascii?Q?3CEl5WhESdGxXcpVWRkISctDy6sQiUhszVJ7ZeXYiEsnDGz4GcCW0kmSRsDd?=
 =?us-ascii?Q?0No7q7vrPWFi0zL5cgZT75SkW4ZcZRlBXccbWAU+r0VfSJPea79DeyB7oHBa?=
 =?us-ascii?Q?2yGZT5tFyIZyT7yUsikATRPsoKjr3sCf1LcvD16p5eozUDwSDrJPT3TRx1qs?=
 =?us-ascii?Q?nIzTIckJ9lNc5fQgJvSf0H6en7wfQ4Io0O5fHI74jcmCUblljRzdR0HYRqCS?=
 =?us-ascii?Q?Ux2KNxAFkgxOT6VLBPlG7FV1Z8d7gf92rIoGRwE+WZhqRIbE/FhJKtMda4dQ?=
 =?us-ascii?Q?+PLaRX35ooGBexdtvROYnR9lleRp23CMRJ49ZdTy7Wyj/KhINKn4KCqd8MuZ?=
 =?us-ascii?Q?5a/LOajnKOa3qzCCIuq5ivSv220MQ+BPSGG5g7aSt8x1kF+y+ottp5gitGAD?=
 =?us-ascii?Q?dkY+hgDpygkKIA778qLD788qM+TG1YElej/3t1nBR4bIuG4nXvSyh2+xLgOu?=
 =?us-ascii?Q?lffTlJ9ANxhAIMkH/ViUnmI27TyewFF+lDkIfg7DHjQ4aL3pr+Gxpn7AxIt5?=
 =?us-ascii?Q?bli9eMxZzbCA//4gokoU1EGkK1HnQR0HmNHrN7haSXT/SeC79K1zJvfD82Qc?=
 =?us-ascii?Q?wg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cd8ef2f4-9f32-4449-b1ad-08dc28ed780e
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 21:32:36.7730
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4rHqjtNUW8yd+IJILhq1gH57dx3nLCa9UahVSWMbUI6aoo+mZhOuqjqXMWt9USrXpxKVFL7bEoNlORNaZAdUqd4NCHeHhFfSyemX4CfYQ/8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7271
X-OriginatorOrg: intel.com

Mathieu Desnoyers wrote:
> In preparation for checking whether the architecture has data cache
> aliasing within alloc_dax(), modify the error handling of nvdimm/pmem
> pmem_attach_disk() to treat alloc_dax() -EOPNOTSUPP failure as non-fatal.
> 
> For the transition, consider that alloc_dax() returning NULL is the
> same as returning -EOPNOTSUPP.
> 
> Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches")
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Cc: Alasdair Kergon <agk@redhat.com>
> Cc: Mike Snitzer <snitzer@kernel.org>
> Cc: Mikulas Patocka <mpatocka@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: linux-arch@vger.kernel.org
> Cc: linux-cxl@vger.kernel.org
> Cc: linux-fsdevel@vger.kernel.org
> Cc: linux-mm@kvack.org
> Cc: linux-xfs@vger.kernel.org
> Cc: dm-devel@lists.linux.dev
> Cc: nvdimm@lists.linux.dev
> ---
>  drivers/nvdimm/pmem.c | 26 ++++++++++++++------------
>  1 file changed, 14 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 9fe358090720..f1d9f5c6dbac 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -558,19 +558,21 @@ static int pmem_attach_disk(struct device *dev,
>  	disk->bb = &pmem->bb;
>  
>  	dax_dev = alloc_dax(pmem, &pmem_dax_ops);
> -	if (IS_ERR(dax_dev)) {
> -		rc = PTR_ERR(dax_dev);
> -		goto out;
> +	if (IS_ERR_OR_NULL(dax_dev)) {

alloc_dax() should never return NULL. I.e. the lead in before this patch
should fix this misunderstanding:

diff --git a/include/linux/dax.h b/include/linux/dax.h
index b463502b16e1..df2d52b8a245 100644
--- a/include/linux/dax.h
+++ b/include/linux/dax.h
@@ -86,11 +86,7 @@ static inline void *dax_holder(struct dax_device *dax_dev)
 static inline struct dax_device *alloc_dax(void *private,
                const struct dax_operations *ops)
 {
-       /*
-        * Callers should check IS_ENABLED(CONFIG_DAX) to know if this
-        * NULL is an error or expected.
-        */
-       return NULL;
+       return ERR_PTR(-EOPNOTSUPP);
 }
 static inline void put_dax(struct dax_device *dax_dev)
 {

> +		rc = IS_ERR(dax_dev) ? PTR_ERR(dax_dev) : -EOPNOTSUPP;

Then this ternary can be replaced with just a check of which PTR_ERR()
value is being returned.