Received-SPF: pass (google.com: domain of linux-kernel+bounces-58730-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 8 Feb 2024 13:37:46 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Dan Williams
	<dan.j.williams@intel.com>, Arnd Bergmann <arnd@arndb.de>, Dave Chinner
	<david@fromorbit.com>
CC: <linux-kernel@vger.kernel.org>, Mathieu Desnoyers
	<mathieu.desnoyers@efficios.com>, Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>, Vishal Verma
	<vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>, Matthew Wilcox
	<willy@infradead.org>, Russell King <linux@armlinux.org.uk>,
	<linux-arch@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
	<linux-fsdevel@vger.kernel.org>, <linux-mm@kvack.org>,
	<linux-xfs@vger.kernel.org>, <dm-devel@lists.linux.dev>,
	<nvdimm@lists.linux.dev>, <linux-s390@vger.kernel.org>, Alasdair Kergon
	<agk@redhat.com>, Mike Snitzer <snitzer@kernel.org>, Mikulas Patocka
	<mpatocka@redhat.com>
Subject: RE: [PATCH v4 05/12] virtio: Treat alloc_dax() -EOPNOTSUPP failure
 as non-fatal
Message-ID: <65c549aa701cb_afa42943d@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240208184913.484340-1-mathieu.desnoyers@efficios.com>
 <20240208184913.484340-6-mathieu.desnoyers@efficios.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240208184913.484340-6-mathieu.desnoyers@efficios.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PxebArmx3FaRa8AEFKB4ae6QibrEI73EJPI8j5kOA3sOkcQZTyfLcc8wgChS?=
 =?us-ascii?Q?WnxqkngjUIbQD0XKNlQvLs7B69jv1+w7KPJTvmfU3OZE331SPSMC5ID2QOpO?=
 =?us-ascii?Q?DGRbbVKjbusS/G8ga3EgEqq+YuIfYTUlTm8vR+OtdZ0Xrkc/cSk2GxTjn9kW?=
 =?us-ascii?Q?EI0PgSwteme0GzCI201y/zDrc4INqQ7F/R45XhBUc82wvEYgISH4ReFSXCpk?=
 =?us-ascii?Q?Y1qeUoWt4Jn+HtlXhJMEfyC52kePRCH1hDcQ2Xvw+JBMBGSLb2jtmPYYf4C+?=
 =?us-ascii?Q?ZeIF9HOjSeJ2dfZACX9HMu14ChRZQXNFFwREWiJ0Z3N1f0MGA17NzAfOskJw?=
 =?us-ascii?Q?Np+nOw1Y9uG5G5Guiqxr0AHwbY3rN+1W1i9Lthz+AEj3GgIrz7ws8I15cT2C?=
 =?us-ascii?Q?DyyKb8Gf/+kz86jP2azKW6G0S4GBt9Z30yXHHSMy3G3hXw3RHyRC90j6dFMi?=
 =?us-ascii?Q?46/JWPo/rXkvFe+YQQweNkX0BKU6JgVxAjjkiZOfH0Pbnz6zYXLcR3X/t8pL?=
 =?us-ascii?Q?0xD9GSRHKQQ5RFJPOc+g4XH257bjQ2L/EkKQVKrW+XQuG8oHIPysY4JEVnsf?=
 =?us-ascii?Q?utvhWsuf/0CkDIX2S42iB31yPAx1z/jG6Jm+bg2sb/Kh2KoMRunm1i3BZ7hi?=
 =?us-ascii?Q?0RgImjYQ+brthKvJ67BRnd3rkPeNTSh7IAju2zCfo+izlTjMBeBYRBzjSrBu?=
 =?us-ascii?Q?jjzJr7YEMLsrxGBQdbO6kbvXX2VJwAJXZziKp9+jH6UYZedRLc+VYaEuD56j?=
 =?us-ascii?Q?IO1YUmdnKDuaogRNXkVqiu1l0lDGGp/DuhBu4XqUi5PGCCBXlBQ96L5fJS5W?=
 =?us-ascii?Q?M2DMdbCv98FPZlI1VfRxF0pZb5dGeEskx9q5mhM9yKHVohlSJzpmp3DVngea?=
 =?us-ascii?Q?xwNwhCb6Cs2tS0zlYwmr5q4TJ+lmoHctcNQLr0XZwL2CVI84jbzpN6Az+tvb?=
 =?us-ascii?Q?UD9AbQ9Uykdpgt3rVV+8fgZH6HwZz+HI5pERVLTxlp2U3DrRXnz1qIi1rwnY?=
 =?us-ascii?Q?2D+kZHy0xHajTXSLT00B4reixVgS95q/BvQ6Ny2ODLlUrQVzGEmShkK8/9UQ?=
 =?us-ascii?Q?IjcaXH80qm8zr5tF75deBgPG0Oi466xe2S74b4/fOi6UczAHBFo4cR4ot7Ch?=
 =?us-ascii?Q?q+nc23ro9fPAcXSOGz1dsNZxkSg0Vq01g91fjmJyScYCkig6lwBtCzuh18bu?=
 =?us-ascii?Q?MjT6cH4h3ncQS8sRClVA3UbrzjfI7rpKaqfkDfC1wrtmX3sxLb5DlupPYCVz?=
 =?us-ascii?Q?fLWbN21KF+Pd2cpt0wNaoDzei5R7bjzWFZC8vuL2N1iJnMF4tJdcI1S9C339?=
 =?us-ascii?Q?ZcZ26CP8MI6Au2CqMBFRvJBhRYh8GGJGmTlZNSWRB8cdcTok3qxQPMcldrLS?=
 =?us-ascii?Q?Ep8l+dotmeXXbMdL1QQtIhTa+H8b2/dzmNwH1ax4J33xTQjb0zuF/x6CRJm2?=
 =?us-ascii?Q?IE1JOnaLz7oHHHyKCamjdUHBu5QFtlUrtdg+/mhlcJ1tP+2ovaRl0T2OgPqO?=
 =?us-ascii?Q?AgLAThVqzLSZRYyOaZGPm1E8kBf0kapXTn7tQlufMt2vpieCrZ0kNPurnHLo?=
 =?us-ascii?Q?pSmjanaNMKhLGIuv4S/9l68dB7Svtu5pArKxvRqmYpUstRAc+cTR1a3v5hOm?=
 =?us-ascii?Q?SQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c080037-6626-4b2c-b158-08dc28ee328d
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 21:37:49.6424
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZRCDhrFc+cmfPRXT/OwsfIflxsixqxAlO0F4NPAceWmVbu3S6l1UtYyupUcNqKmWy3CXC8diP3q6XMl8Vmstzt8u1lzYzFLeXt0jfH22JYg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5567
X-OriginatorOrg: intel.com

Mathieu Desnoyers wrote:
> In preparation for checking whether the architecture has data cache
> aliasing within alloc_dax(), modify the error handling of virtio
> virtio_fs_setup_dax() to treat alloc_dax() -EOPNOTSUPP failure as
> non-fatal.
> 
> For the transition, consider that alloc_dax() returning NULL is the
> same as returning -EOPNOTSUPP.
> 
> Co-developed-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches")
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Cc: Alasdair Kergon <agk@redhat.com>
> Cc: Mike Snitzer <snitzer@kernel.org>
> Cc: Mikulas Patocka <mpatocka@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: linux-arch@vger.kernel.org
> Cc: linux-cxl@vger.kernel.org
> Cc: linux-fsdevel@vger.kernel.org
> Cc: linux-mm@kvack.org
> Cc: linux-xfs@vger.kernel.org
> Cc: dm-devel@lists.linux.dev
> Cc: nvdimm@lists.linux.dev
> ---
>  fs/fuse/virtio_fs.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
> index 5f1be1da92ce..621b1bca2d55 100644
> --- a/fs/fuse/virtio_fs.c
> +++ b/fs/fuse/virtio_fs.c
> @@ -16,6 +16,7 @@
>  #include <linux/fs_context.h>
>  #include <linux/fs_parser.h>
>  #include <linux/highmem.h>
> +#include <linux/cleanup.h>
>  #include <linux/uio.h>
>  #include "fuse_i.h"
>  
> @@ -795,8 +796,11 @@ static void virtio_fs_cleanup_dax(void *data)
>  	put_dax(dax_dev);
>  }
>  
> +DEFINE_FREE(cleanup_dax, struct dax_dev *, if (!IS_ERR_OR_NULL(_T)) virtio_fs_cleanup_dax(_T))

This IS_ERR_OR_NULL is ok because dax_dev is initialized to NULL, but
maybe this could just be IS_ERR() and then initialize @dax_dev to
ERR_PTR(-EOPNOTSUPP)?