Received-SPF: pass (google.com: domain of linux-kernel+bounces-58744-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 8 Feb 2024 13:55:13 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Dan Williams
	<dan.j.williams@intel.com>, Arnd Bergmann <arnd@arndb.de>, Dave Chinner
	<david@fromorbit.com>
CC: <linux-kernel@vger.kernel.org>, Mathieu Desnoyers
	<mathieu.desnoyers@efficios.com>, Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>, Vishal Verma
	<vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>, Matthew Wilcox
	<willy@infradead.org>, Russell King <linux@armlinux.org.uk>,
	<linux-arch@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
	<linux-fsdevel@vger.kernel.org>, <linux-mm@kvack.org>,
	<linux-xfs@vger.kernel.org>, <dm-devel@lists.linux.dev>,
	<nvdimm@lists.linux.dev>, <linux-s390@vger.kernel.org>, Alasdair Kergon
	<agk@redhat.com>, Mike Snitzer <snitzer@kernel.org>, Mikulas Patocka
	<mpatocka@redhat.com>
Subject: RE: [PATCH v4 09/12] nvdimm/pmem: Cleanup alloc_dax() error handling
Message-ID: <65c54dc181e01_afa429468@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240208184913.484340-1-mathieu.desnoyers@efficios.com>
 <20240208184913.484340-10-mathieu.desnoyers@efficios.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240208184913.484340-10-mathieu.desnoyers@efficios.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PEGGVD14ZI5v/Ou3GOmlN3zyAZADo07RqDca+rt4ePhY1IHw6+UJrPuwn1f7?=
 =?us-ascii?Q?ZYdmFRU3YtTspdetBWn5JCgmIsY/fhoIPp/gKHE/BIzkHYLgz0IetezXls6r?=
 =?us-ascii?Q?C5187SjCsOE2DR+NPi3jsecWLr0dlOFdB1AusmenTZ1sGuyb6kVeynlnpkbP?=
 =?us-ascii?Q?SiuASDuB3H284RqaQKILUCr7UwbZOFDbyugA/JGwPIgTvh5/rsPW7XTP8vKk?=
 =?us-ascii?Q?lcREf8ijSy/MbIUnJTRyugd5eVURXjvxvvcbL3loTfiacBTesqDIZQUGAJPl?=
 =?us-ascii?Q?aSUIHZC6mObfW7yjIGX503uGt3/HWy+7q8o/z9/2vnlxDHy/q9aDafFqoCa1?=
 =?us-ascii?Q?6GCA1oBIq0w9Pn4foMpJlcwtpjtgpc6UjvdPp4sxeY4O14HETXi6Zps40n8s?=
 =?us-ascii?Q?nmIfhZd2jMm8SDEsZNoOD/HJZWbgurwLnCQIDRTRlkdXCrvrnEDVnJ+QcHCt?=
 =?us-ascii?Q?6PJQHvmBN1xsKLeIfDXtYyAUfvOrVZdnQTtkotRPU9oVyV/ttsfHRx8l1MWq?=
 =?us-ascii?Q?tqUPZwVAHXQH5eQa8yRs+x8TJMmT1lCRtJPqT897AaKCSSYzstsbTnU3Aq+l?=
 =?us-ascii?Q?qYXeK2axHkbluHr6CJNCCJT3x+gi0oUMsKN8nNJ4tFLP+SnKFVO1os2YEKDV?=
 =?us-ascii?Q?ZPJso6eVu0CdaCXJzHdw6L6lo2STjx5VODKUHF0MGrLYnjWIXXuT3BI9DDqb?=
 =?us-ascii?Q?RhjuSkgB7KFfVj90aL4uwDr6Q0kyoqhdm5C5c/I3xXJUK/pOL3M93LGorvUm?=
 =?us-ascii?Q?tFfcJFhxZdqCB0orHm6QIbE6SRTnIJM3c5+N8IZwuXEJPX+SwU6bRt/6Kc2y?=
 =?us-ascii?Q?rDEkIoGNGGD8fkYyySTViBZomaSE10QRSTR+EzRemG0uHGFPAQC8mdbr2cnW?=
 =?us-ascii?Q?Il7p3YAma4OikBh3z7ou9qb7W+nv6PolvLTb5Y/24/CWGM8RSCCw/qbInY7T?=
 =?us-ascii?Q?BPrQVbKJ279aIqcHTqRMmnuyzKwd37hyhDd4sKvWmx7l00uoiCcZJfVH7pTc?=
 =?us-ascii?Q?PXZJWLH8j3AVsHQFaK01aZPHJHR9Iqt+HMbsDrla4nKnrjTREph35SrguoCN?=
 =?us-ascii?Q?emE9iVJmHm5qaXCiwdpuseZzC+1VAYjgu5CuVu3C0JJQl/8lXS3WL4QI5FaM?=
 =?us-ascii?Q?yDC3Kt/qeTeDPok9wjwRi5dnVAbrfEhLje1P7M5qhrFBXz+e3VX7JaQhslm/?=
 =?us-ascii?Q?SpaOlb+6YW8v8ZxEzZT2bjCK4SL/5DSgBz/vEpSiHw+7wXUY4sRB76m3A2yH?=
 =?us-ascii?Q?li9hNw4Gn/9XPro0wu/UAjvkfOqM5qLGBNDToXrI1dX9EhsGfnkfU1/j08mZ?=
 =?us-ascii?Q?l6DuFCqj8gCC26x+T3mjUyazAKSKl2Cmwa0Il543/YEm9vNEdpZlYTsvTrfg?=
 =?us-ascii?Q?9q5hByRXOFrhIbsZans+UeV5JN5OcLcDQ/V2KDJ8oUP8NGf8xERPLM6tUTJQ?=
 =?us-ascii?Q?BtZ2jw9q6DhvYx3HqEYf+I+Z6JSX3k1qQ4N4tOhQ0NQBoXlmVITzpz1RB9V6?=
 =?us-ascii?Q?bL4de+IxI74On3S1KisPGDkPfUKMG48rNLxrPaJ1ro5VdoM65lT2oMaFsXaQ?=
 =?us-ascii?Q?YJgK9MIX2ghNXCZtuix0CkjGkXFWqUV6FtYffOUZu4H65qQkZGT4a1lVVj0E?=
 =?us-ascii?Q?eA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 93d364ca-aca3-4b50-cd44-08dc28f0a262
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 21:55:16.2538
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2CBEgT6rHaVYLwqRDeBIlpzdNBqZuZhqxDXZ6cBc0PMIZmO8hZBzwmn5KL4GWKm9zKITG7cyd+ePcDWRM36daqzChT62vOs1eE/b+YyeiZs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4771
X-OriginatorOrg: intel.com

Mathieu Desnoyers wrote:
> Now that alloc_dax() returns ERR_PTR(-EOPNOTSUPP) rather than NULL,
> the callers do not have to handle NULL return values anymore.
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Cc: Alasdair Kergon <agk@redhat.com>
> Cc: Mike Snitzer <snitzer@kernel.org>
> Cc: Mikulas Patocka <mpatocka@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: linux-arch@vger.kernel.org
> Cc: linux-cxl@vger.kernel.org
> Cc: linux-fsdevel@vger.kernel.org
> Cc: linux-mm@kvack.org
> Cc: linux-xfs@vger.kernel.org
> Cc: dm-devel@lists.linux.dev
> Cc: nvdimm@lists.linux.dev
> ---
>  drivers/nvdimm/pmem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index f1d9f5c6dbac..e9898457a7bd 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -558,8 +558,8 @@ static int pmem_attach_disk(struct device *dev,
>  	disk->bb = &pmem->bb;
>  
>  	dax_dev = alloc_dax(pmem, &pmem_dax_ops);
> -	if (IS_ERR_OR_NULL(dax_dev)) {
> -		rc = IS_ERR(dax_dev) ? PTR_ERR(dax_dev) : -EOPNOTSUPP;
> +	if (IS_ERR(dax_dev)) {
> +		rc = PTR_ERR(dax_dev);

Oh... I see you cleanup what I was talking about later in the series.

For my taste I don't like to see tech-debt added and then removed later
in the series. The whole series would appear to get smaller by removing
the alloc_dax() returning NULL case from the beginning, and then doing
the EOPNOTSUPP fixups.

..repeat this comment for patch 10, 11, 12.