Received-SPF: pass (google.com: domain of linux-kernel+bounces-58728-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 8 Feb 2024 13:36:00 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Dan Williams
	<dan.j.williams@intel.com>, Arnd Bergmann <arnd@arndb.de>, Dave Chinner
	<david@fromorbit.com>
CC: <linux-kernel@vger.kernel.org>, Mathieu Desnoyers
	<mathieu.desnoyers@efficios.com>, Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>, Vishal Verma
	<vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>, Matthew Wilcox
	<willy@infradead.org>, Russell King <linux@armlinux.org.uk>,
	<linux-arch@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
	<linux-fsdevel@vger.kernel.org>, <linux-mm@kvack.org>,
	<linux-xfs@vger.kernel.org>, <dm-devel@lists.linux.dev>,
	<nvdimm@lists.linux.dev>, <linux-s390@vger.kernel.org>, Alasdair Kergon
	<agk@redhat.com>, Mike Snitzer <snitzer@kernel.org>, Mikulas Patocka
	<mpatocka@redhat.com>
Subject: RE: [PATCH v4 04/12] dcssblk: Handle alloc_dax() -EOPNOTSUPP failure
Message-ID: <65c549405cee8_afa429495@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240208184913.484340-1-mathieu.desnoyers@efficios.com>
 <20240208184913.484340-5-mathieu.desnoyers@efficios.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240208184913.484340-5-mathieu.desnoyers@efficios.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LQorjk9IE1YsjmQUrOHbVGIZ3JZfna5XFZ4592qhOr3Obrx6L02ucKAHT8KT?=
 =?us-ascii?Q?TU8Oheip/+SJ8RR8/doi08RjXI1oh+hu/D9yi5dBUKE4HQLY59enYFE1kVsc?=
 =?us-ascii?Q?Jd7qgim6jRk9wt/q4DHx/uftsVHt80UqHzwtdf6vDprHIpx1lwsFL45RTWgB?=
 =?us-ascii?Q?2CojNLQiL+zJNL39F7PMf0GnQ0xBpmfQXgSSwrafrWq696Jn80BvK5VIY/HJ?=
 =?us-ascii?Q?kS5UCly5FQZoogqnQaikehM/A4yqLzEedX5zEkPtafZbhS/TJGupuJmWfSFl?=
 =?us-ascii?Q?lRzurbWTqpLzjr9Fm+9MkPGgt7IzFBV9JWJV9csT+XbOCXLma5SGQSlOULQj?=
 =?us-ascii?Q?5CfCwj9TxLD10Qq/WwY7EqtLwEeRVQ38B2kC7KDhvkDwBuMQr9nmRN4p9+wG?=
 =?us-ascii?Q?9FQLaOHTq+N6pnDCR43N1XrRpxzMjTzhx07o/DK9iQoIvJyaZHVhkLNQlmRq?=
 =?us-ascii?Q?E5X52wM6yVlhG0OzK6Cu/PGwyRWneWegl7fqPLR9rYgVmvN1WpABzw9HhZ8h?=
 =?us-ascii?Q?gBU9cKf8kZcGUnXmPpZy1JVAtMbxajqwX2jdCjEuZLq1D8+bPb2kLx9vI04J?=
 =?us-ascii?Q?5Kta9PmoSQ6X1RDC74Vel6VQamn0MjNVyopHKdstRZuDQ8NXMiUXvh0DtOcH?=
 =?us-ascii?Q?mtl26DH3MrSgMj5gXHQaKdWCsX4nIAtEnvBYLsrmdPouL8IVkOcYvITPFk0s?=
 =?us-ascii?Q?fcxUDUQOKOv7D4BqubyU/9euy+xF2UkkAY7f4N++lM8lWcfSDA+QD/DTv/uS?=
 =?us-ascii?Q?YlJJK8t6ALg37CsGVi0VcBKy+ElA4pn9m8Ntvzp5/cmxs0UWOJjBUjA+OcQc?=
 =?us-ascii?Q?n0h2cRcfuISuVzegtzy7X/vCMGO3wgF3wqmsVKDHteqJK3bxBvV0v1DnRKv5?=
 =?us-ascii?Q?hUfiDIq7d9zewOQpfPPkx4zmwpkBEWrWMUO3UNaBVGNtLzfquDf9o4fXvBwo?=
 =?us-ascii?Q?K4YJuCIq3PHKQdub11a2puavfx9iZvo/+ptnXIpedk+q9iMZeYv1J2d1c3uD?=
 =?us-ascii?Q?LQGOgdgASJpjTxufKExU7iC/alfLamtr/3f6N7t47hr0Z0nJ/GdBbLCk8YEZ?=
 =?us-ascii?Q?9oCSDzrnRpP0PFiF+bRpYqC80tOCmu8Y18P2AYExQMhGluDJ/MEcwfYJdjw4?=
 =?us-ascii?Q?S67xqXjhEVNeZrAENarHqnnwZ6bSygy10D5ximtWW0VOy1DUJ7KE6Juz45xO?=
 =?us-ascii?Q?qYE+sWuCtCwaIjjuDY9yJwiDv4bxiZDPB88xxipGAdrKqOxznvPLsNpWRIxZ?=
 =?us-ascii?Q?nooKEvVSEYsDyFJ4O7M7pXsHjYOSTBYoV20bsH8rNmOBlIcwAm5qMbFEpECT?=
 =?us-ascii?Q?ymRWs3JIry/c/NtbYLfH5mvGlRJ5v8wmQjqfTHsL1KBZdX1f1JXR6GYNRlWG?=
 =?us-ascii?Q?LMGn+Qg1dgsskMzfkYh0bOKZON0urQ1RPm6zp9QanbsgiqdqppAq8PLNq9cQ?=
 =?us-ascii?Q?vkmHmbE+RDWA1PCLa+wwRJJGtzcuZ1O9Vo8lHuYE027Nw/2lQAXK14o02oUw?=
 =?us-ascii?Q?cjHBz/820qV2RxUJJEzLS3A96HhxtsVvJ5Qbikb2gY7wb28t16hiZktBM+Hq?=
 =?us-ascii?Q?p3PzqpIo7umRm1mDA88aXsft7fSmBlWHqQAwJnT7pvojpveLBF5j+Qc0U3yR?=
 =?us-ascii?Q?gg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b4875fa7-f08d-4ddd-5349-08dc28edf320
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 21:36:03.2292
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GoEXWC8XeIBYHEjI6MTHEBluru665ThSH6AmdRy2aVt2ZK2Wo/K/0JoOIIy+IQsmlkXORmFiq2Qc7/yrzUaAdwlKEAOX6p6n+iEFfqPB2+8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5567
X-OriginatorOrg: intel.com

Mathieu Desnoyers wrote:
> In preparation for checking whether the architecture has data cache
> aliasing within alloc_dax(), modify the error handling of dcssblk
> dcssblk_add_store() to handle alloc_dax() -EOPNOTSUPP failures.
> 
> Considering that s390 is not a data cache aliasing architecture,
> and considering that DCSSBLK selects DAX, a return value of -EOPNOTSUPP
> from alloc_dax() should make dcssblk_add_store() fail.
> 
> For the transition, consider that alloc_dax() returning NULL is the
> same as returning -EOPNOTSUPP.
> 
> Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches")
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Cc: Alasdair Kergon <agk@redhat.com>
> Cc: Mike Snitzer <snitzer@kernel.org>
> Cc: Mikulas Patocka <mpatocka@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: linux-arch@vger.kernel.org
> Cc: linux-cxl@vger.kernel.org
> Cc: linux-fsdevel@vger.kernel.org
> Cc: linux-mm@kvack.org
> Cc: linux-xfs@vger.kernel.org
> Cc: dm-devel@lists.linux.dev
> Cc: nvdimm@lists.linux.dev
> Cc: linux-s390@vger.kernel.org
> ---
>  drivers/s390/block/dcssblk.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c
> index 4b7ecd4fd431..a3010849bfed 100644
> --- a/drivers/s390/block/dcssblk.c
> +++ b/drivers/s390/block/dcssblk.c
> @@ -549,6 +549,7 @@ dcssblk_add_store(struct device *dev, struct device_attribute *attr, const char
>  	int rc, i, j, num_of_segments;
>  	struct dcssblk_dev_info *dev_info;
>  	struct segment_info *seg_info, *temp;
> +	struct dax_device *dax_dev;
>  	char *local_buf;
>  	unsigned long seg_byte_size;
>  
> @@ -677,13 +678,13 @@ dcssblk_add_store(struct device *dev, struct device_attribute *attr, const char
>  	if (rc)
>  		goto put_dev;
>  
> -	dev_info->dax_dev = alloc_dax(dev_info, &dcssblk_dax_ops);
> -	if (IS_ERR(dev_info->dax_dev)) {
> -		rc = PTR_ERR(dev_info->dax_dev);
> -		dev_info->dax_dev = NULL;
> +	dax_dev = alloc_dax(dev_info, &dcssblk_dax_ops);
> +	if (IS_ERR_OR_NULL(dax_dev)) {
> +		rc = IS_ERR(dax_dev) ? PTR_ERR(dax_dev) : -EOPNOTSUPP;

Just another "ditto" on alloc_dax() returning NULL so that the ternary
can be removed, but otherwise this looks good.