Received-SPF: pass (google.com: domain of linux-kernel+bounces-58890-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 8 Feb 2024 19:03:31 -0500
From: Frank Li <Frank.li@nxp.com>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: Conor Dooley <conor@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Felipe Balbi <balbi@kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: Re: [PATCH 0/2] usb: dwc3: drop 'quirk' suffix at
 snps,host-vbus-glitches-quirk
Message-ID: <ZcVr05vAYsObrrRR@lizhi-Precision-Tower-5810>
References: <20240207-vbus-glitch-v1-0-7be87099461d@nxp.com>
 <20240207-settling-drone-90e6f10a3476@spud>
 <ZcQAqVViPHcbgn52@lizhi-Precision-Tower-5810>
 <20240208-unquote-palace-83edc6220acd@spud>
 <20240208222748.cc2eodhtqpt2jmpf@synopsys.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240208222748.cc2eodhtqpt2jmpf@synopsys.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?soztKeNg2paMTIOw+NQvoxVeRids1ubFR1M7ctQvj4BlE1Io2mVnIfiPTvol?=
 =?us-ascii?Q?iLNcMSbP0eR7rnxw1DteJYHYpfl80lSoAd5eCozO2G+wfaZDEMn+b2aRngi8?=
 =?us-ascii?Q?r4OOEKeDrrL422wcJnzyF4CPcYAVQLKx5SW/Ky/0X/j/tl5xgvuZeizZt6Rf?=
 =?us-ascii?Q?o+/XIYa5Uruh/Yoi/f028YkqqxxwtvkWB0aD97haghcUG10Q4fPLZ2i1MPIu?=
 =?us-ascii?Q?ysXbB2VwrQM1WlM6jX8s3KHb5LQx2k/0vaWlpq1hcNP67pUA/KYLfCyUcS+M?=
 =?us-ascii?Q?fp3bxavza42bDJcBwPSfRJ2ooaQtZHKZH0HseHdP1u0dIZ9jFX1ZbixBYm/3?=
 =?us-ascii?Q?sre6Uors64rtYoADnh6JZW5apO53P547EV96snmT+5YsB+c6oRnXTqi7/ptB?=
 =?us-ascii?Q?NeP/I+AoY1EklHOrnNgdeiU108Teb03MGdgOcOFGw6cyGrcC4x/2lV9SlZpL?=
 =?us-ascii?Q?FaC5acIkGpKZVsFJ0g07d4ROeRH+IKJP//apEPdkoD2gIvu0TobY9hAd4+LB?=
 =?us-ascii?Q?Si1tvZV3SkQRRCb6/CY3qqbe1zyBesd2w/BwGXbJhYVi3aqEVneQoMHGpA8Q?=
 =?us-ascii?Q?l/LUVhTu1zISk73T9mvxAXZe4Xnmva9EnJiiHVReGLVmZ6aZ5R+mDMxt6KBT?=
 =?us-ascii?Q?GQF2v7XBrAnhz+KWzPREya3R2yp3Ux3OtstnqFAcBz1GIyjCWSzExuj6EkEn?=
 =?us-ascii?Q?iXKyRvsxWR/3rRmG4sMdFW5d2LegHLUZeMGD2pUsjZ+3u3ZEaOMlJKd/oVIg?=
 =?us-ascii?Q?rgpLPaPZH3O3qm1FLEzPZWp+TUfRmoRVXYFDeKpRn2JoVCTRxlhTkZfSbvYi?=
 =?us-ascii?Q?pMzzlaSi2453F4gXnXjHnMph6ogn1CGCj1ViLKVoM2CSFPozTh3yEgq8ervT?=
 =?us-ascii?Q?mobHwqFRH/k8vDZGQj6MLKAa9ZLYnh9khCD6fvT1m5WK/UyhMTXkwmRYjgBx?=
 =?us-ascii?Q?RBnHciF/H8IDZ9E74DkeZNPrNhjHoqyOis0t99ZHil0qMapsRp7J3L92HSKP?=
 =?us-ascii?Q?LE6IsQfZbBS8BXpHCG7uPelJwmWRQWCf5GQlFU8MG9EVrXljtfH6gdabPYmg?=
 =?us-ascii?Q?sPUPIvNAywrCZoO35fnyrGipS3rNSu67wkHiZIyHNVZ0uRQEjI68rss3k+cU?=
 =?us-ascii?Q?L9c97TwxeZnt0VYDcjWIFijP6lNtHtBNCT8yHYGkYQXdLB0VwyzUwO1Pz8Qw?=
 =?us-ascii?Q?A779PfBj7lcGa/xds3YUi/y+froK4OJCGYEFrxG1Z313u+tdnXOSx7ENHG5b?=
 =?us-ascii?Q?4Joqbb06XUmfwc5OnREfV0YHPUUYCLmAtFkBP6LXmmvpGx/IcSsFNbH/tt8W?=
 =?us-ascii?Q?MkT7bJFD6gRZgHF1vyZ/4HGb9AtciHxylzwEECC0ne+HgYgz8noztu8hpeXq?=
 =?us-ascii?Q?Y3OLTNHXA8Dlmtt++hFS5wwf66l8gjVlB+e8C4X3VTdeRSHi8Xtr0/7OVsOJ?=
 =?us-ascii?Q?YMZrvRBAu4Shlw6gK6q/CP0hsVJenNUpoY5WR773plxYG4VknXjSc5QnWBdD?=
 =?us-ascii?Q?9GjcKa2xoX9dOoQ5VpEY0xUFLaMLC17gU8qS3ynMO/pj3qR5cQZBI8rKLsJV?=
 =?us-ascii?Q?djqEyuwd6OPB8nfORxE=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74ba9c47-e3d6-4d6b-9585-08dc290292e6
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 00:03:41.7433
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0ECWfnHRXsPrEH2jWQqW/lmyN9rUEic5na6HCMZzL82SpZAGP9ompOL2kPYxys3hoDvMsRQUmJK5Mk40s3W2XQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8958

On Thu, Feb 08, 2024 at 10:28:22PM +0000, Thinh Nguyen wrote:
> On Thu, Feb 08, 2024, Conor Dooley wrote:
> > On Wed, Feb 07, 2024 at 05:14:01PM -0500, Frank Li wrote:
> > > On Wed, Feb 07, 2024 at 10:05:23PM +0000, Conor Dooley wrote:
> > > > On Wed, Feb 07, 2024 at 05:00:17PM -0500, Frank Li wrote:
> > > > > Since dt maintainer give comments at old thread
> > > > > https://lore.kernel.org/linux-usb/20240119213130.3147517-1-Frank.Li@nxp.com/
> > > > > 
> > > > > The patch v4 already merged.
> > > > > https://lore.kernel.org/linux-usb/20240124152525.3910311-1-Frank.Li@nxp.com/
> > > > > 
> > > > > So submit new patch to rename snps,host-vbus-glitches-quirk to
> > > > > snps,host-vbus-glitches to align dt maintainer's comments.
> > > > 
> > > > I thought the last comment left on the v1 was Thinh agreeing that a
> > > > DT property was not needed here and we should be able to apply this
> > > > conditionally?
> > > 
> > > I don't think so. This is workaround. We can use this track which chip
> > > actually need this. If some year later, such chips already end of life.
> > > We have chance to clear up these code. Otherwise, it will keep there for
> > > ever.
> > 
> > > And I am not sure that the side effect for other chips. Workaround should
> > > be applied as less as possible.
> > 
> > I'd rather do it unconditionally if we can, but if you and Thinh think
> > that we cannot do it unconditionally then sure, keep the property.
> > 
> 
> Perhaps I wasn't clear. I meant I agree that we don't need a new quirk
> property. If anything, it should be safer to keep vbus disabled before
> handing over to xhci driver. We should be able to do this
> unconditionally.

Okay, if everyone think unconditional is good. I can submit new patch to
remove these.

Frank

> 
> BR,
> Thinh