Received-SPF: pass (google.com: domain of linux-kernel+bounces-58896-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240131180757.35044-1-vishnuocv@gmail.com> <901e1fb0-1e42-7bf7-113d-3d0bbb62f4da@linux.intel.com>
 <CABxCQKvtgwxS_DU2U-LNrPiqHF4+y2YPkMgP4-nS6U3ccp8M7w@mail.gmail.com> <2f280707-7250-4bb2-460c-5f8a02208179@linux.intel.com>
In-Reply-To: <2f280707-7250-4bb2-460c-5f8a02208179@linux.intel.com>
From: Vishnu Sankar <vishnuocv@gmail.com>
Date: Fri, 9 Feb 2024 09:15:04 +0900
Message-ID: <CABxCQKthnVk4GOMu5M8Q8PbioO72AaiHSfbu-SB2KjuOz4ZU5A@mail.gmail.com>
Subject: Re: [PATCH] Fix to correct wrong temp reporting on some ThinkPads
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org, 
	LKML <linux-kernel@vger.kernel.org>, vsankar@lenovo.com, 
	Mark Pearson <mpearson-lenovo@squebb.ca>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 9, 2024 at 12:11=E2=80=AFAM Ilpo J=C3=A4rvinen
<ilpo.jarvinen@linux.intel.com> wrote:
>
> On Thu, 8 Feb 2024, Vishnu Sankar wrote:
>
> > Thanks a lot for the review.
> > And sorry for the delay in response.
>
> Small improvements to my earlier version below now that I reread it.
>
> > On Tue, Feb 6, 2024 at 8:03=E2=80=AFPM Ilpo J=C3=A4rvinen <ilpo.jarvine=
n@linux.intel.com> wrote:
> >
> > > @@ -6174,6 +6191,21 @@ static int thermal_get_sensor(int idx, s32 *va=
lue)
> ...
> >       A code reader would be served much better if this convoluted logi=
c is
> >       simplied to:
> >
> >               case TPACPI_THERMAL_TPEC_12:
> >                       if (idx >=3D 12)
> >                               return -EINVAL;
> >
> >                       if (idx <=3D 7)
>
> if (idx < 8)    <- to match idx - 8
Acked
>
> >                               ec_offset =3D TP_EC_THERMAL_TMP0_NS + idx=
;
> >                       else
> >                               ec_offset =3D TP_EC_THERMAL_TMP8_NS + (id=
x - 8);
> >
> >                       if (!acpi_ec_read(ec_offset, &tmp))
> >                               return -EIO;
> >
> >                       *value =3D tmp * 1000;
>
> 1000 should likely be something from linux/units.h.
Got it.
Will use KILO.
>
>
> --
>  i.


--=20

Regards,

      Vishnu Sankar
     +817015150407 (Japan)