Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp619534rdb; Thu, 8 Feb 2024 16:23:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IFfXE0cj801Qrq1Bsgc+p7L4jemOR7guRirTTnicTC5KkxHVlOcpP/pVfmVIRMT8z941w5P X-Received: by 2002:a05:6a00:4592:b0:6e0:4b47:8216 with SMTP id it18-20020a056a00459200b006e04b478216mr104725pfb.16.1707438194270; Thu, 08 Feb 2024 16:23:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707438194; cv=pass; d=google.com; s=arc-20160816; b=UVqTcNQ2S7QIoEhVfuHNaxONADwdlqBeBC7tag+2gmLpOX8rVq1DNGjOHTWaSY383S uRoAoVQu+1nwNEpZjZmJJiwCyUUmO2SSr2p0J1AhFODJ722Hx1544GcR7YfLouVaj1qr QA8v+xRbmXb5rTRyFf3iU1GBA+YhO6B8o5zyUX4bjLTkEULaNGV3tPsCMGH0fWPR9Az6 lnAi0l+O5CXLcBqOIVwFCSj6Bgt3I/PMNJaZoFqS2MJY9JQef0KyQreG35lvN5pSV/RJ /h2TcdOB7ZKMc++WEIl4Ir01Y9emKmIUy0eziXsD/3uJxI2q6+PEmU0n5dSLsPuucZy+ Xqxg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:from:subject:message-id:references:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:in-reply-to:date :dkim-signature; bh=vsNvehKq1ZDZ9aome1IoXssJL6mlGAzVo4fhtG5Pd54=; fh=SpmK72cI7SgVmtx5MHYg1keBFy2nXVrlMv1oDXh3axM=; b=RFlL16T954vr4iDV7+pz2dqyf6LyJP1ePiTRmpPGh/FkU6om/MSmMLdsAjp4jBHHYu Ekr9xWLgDRVEwGf+Vn3uVvXu659EswRUH3wGYVlmkgf9MSyKQVTEzThUKBs6Xjwnh4H5 CTYhDq9MW675YURaEYlAkkpRTtjJKriLYfeKTkMerKbzilxvZzV/HpKJvXcvhTyfDENp YMHAXampYvHDfX8aGXo22KxI6ZU/TcmXgZ34uUz1uOr1DElihaKQf7xQrQ80kFU1N5UZ WeyW2kApMrRhOdkf4JF5s0zHjNahzDZsciRCuR2StsUXQhBAUDAJMV/hSO3BoD/u6RK7 Sa5g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=QqU+Cbx3; arc=pass (i=1 spf=pass spfdomain=flex--seanjc.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-58900-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58900-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com X-Forwarded-Encrypted: i=2; AJvYcCUUeN+6NP+B/QPt4tEGHozTMriVJqCGmOJjGqWpRvM7R9p18R7vsxM1tHwsCSjdoBmzlrlTJHREwkdox2MHISAkaZ/97gSP6HfBy6LqOg== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id bd11-20020a056a00278b00b006e037d6b125si553738pfb.163.2024.02.08.16.23.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 16:23:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58900-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=QqU+Cbx3; arc=pass (i=1 spf=pass spfdomain=flex--seanjc.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-58900-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58900-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E692E282211 for ; Fri, 9 Feb 2024 00:23:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 015D67EB; Fri, 9 Feb 2024 00:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QqU+Cbx3" Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5612360 for ; Fri, 9 Feb 2024 00:23:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707438185; cv=none; b=elb/hsjPWawQEwvQRkm2a8pWvrfU5+p6/uIb2C1ddiOatJiTnDFnqj40x/iiUsd8pyRwTaNdTZnYgqcrx/R7eTQjiPgomGjmPL4vvJNmbUvEsE8JqYINeVeObdIkTDBcF0JhTnocKbjTIeggREiu6TnEeWsIVX+aIOUypiVty1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707438185; c=relaxed/simple; bh=IvsuJ7EMrN39WihS2Hj4OfJrXOBjvzJXlONmXuyLZso=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=izawK2jwsKzMVMA4i5/8kzxZxn7SzWpbf5e//vxr6s8Yb3yelaRFZS3VGlwRy/aqyQTSKJ2ShRqTurw3lz06h77y5t4KFNdVj8jN950jdUiaxo/8pwCiK8rrJzQsotXRi+1aDfFwS+tSaLJb/wMK4F2KsTD4c8hGJEtG4Qu5AzQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=QqU+Cbx3; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-5ffee6fcdc1so9287377b3.2 for ; Thu, 08 Feb 2024 16:23:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707438183; x=1708042983; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=vsNvehKq1ZDZ9aome1IoXssJL6mlGAzVo4fhtG5Pd54=; b=QqU+Cbx35jwdtDI93yaEVvqWN0tb5ca/mV7m93aO7Zjpc50YSVlyCeS8N1kl9Hblko dhskIKI7sUnmyWlGj9LHDYL0tAihusg/DG35tUXHbadio1SDx5v1Os/dy79P5fqofUeT tAu9qkKtiVReBiX3RuXXZKj3wsiLzT60wl7wB3LrxZqIKGEl9GO9qZ8tAThmf7KRRroF Mdh2h0i+mQ2ihGu4qwkFNEekYTT7FAktOksvIK2JCAr7eVNgAgM+YzLxkpnZiz+oQXVT JQctNqcxru1X3ZSTSx4QgWaxCHfFIzq1JEykMiGC/PeOAJgLg8gmYLEtaQe9pBR4oV5k SUKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707438183; x=1708042983; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vsNvehKq1ZDZ9aome1IoXssJL6mlGAzVo4fhtG5Pd54=; b=r5yCOQHQKcCQwiP3NmERE6+0+RPHRnPZq0qRgGYhwJQD1Vgzn3O1x5YVu3wdFePizf XZumniTbrdgohVIhMLxTNqemi25R2rbE1LCPOh1xNnT94xOe3LJJTNiR4qQjbkWMKhWb 8a6yXxAni2JkUx+6px1S8Uf/wJ7nCFwoha1kGNtppA3JDYiVXn1r+dAq8Basp5qqYTr9 QNncLisiEAsshC/eVT+8RUkjmVPi41kcbVgi69M2dT5ppIkz6+tm5rnKsAM7wgF/wDMG vxk1rxTNMs+2ssG3kYDBBSF30rRn7SP8Crkd6K5mZWQ1v42cVqoQVjaBCw/tdCTHt3q0 noOw== X-Gm-Message-State: AOJu0Yx7zxUu8dIWTItJfT00JQ45/O55UOKMiEzSz2HOiM+Rm//b993+ eaAKNTo0InKM2mUYXWiDjljDiun7Rom92yAFQJ7yaV3d6UTDOih6GXBFjARa5USBbaNoZHYBoOH XMA== X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:48c5:0:b0:5ff:82c7:1528 with SMTP id v188-20020a8148c5000000b005ff82c71528mr171ywa.5.1707438182818; Thu, 08 Feb 2024 16:23:02 -0800 (PST) Date: Thu, 8 Feb 2024 16:22:43 -0800 In-Reply-To: <20231212095938.26731-1-julian.stecklina@cyberus-technology.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20231212095938.26731-1-julian.stecklina@cyberus-technology.de> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog Message-ID: <170743804033.201213.17136091550631405731.b4-ty@google.com> Subject: Re: [PATCH] KVM: x86/emulator: emulate movbe with operand-size prefix From: Sean Christopherson To: Sean Christopherson , kvm@vger.kernel.org, Julian Stecklina Cc: Thomas Prescher , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Tue, 12 Dec 2023 10:59:37 +0100, Julian Stecklina wrote: > The MOVBE instruction can come with an operand-size prefix (66h). In > this, case the x86 emulation code returns EMULATION_FAILED. > > It turns out that em_movbe can already handle this case and all that > is missing is an entry in respective opcode tables to populate > gprefix->pfx_66. > > [...] Applied to kvm-x86 misc, thanks! I have a KUT testcase for this now, I'll post it at some point. [1/1] KVM: x86/emulator: emulate movbe with operand-size prefix https://github.com/kvm-x86/linux/commit/03f6298c7cf6 -- https://github.com/kvm-x86/linux/tree/next