Received-SPF: pass (google.com: domain of linux-kernel+bounces-58919-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <8b4f8ec2-7534-4f77-b44f-6728c699ff64@intel.com>
Date: Thu, 8 Feb 2024 17:36:00 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] x86/MCE: Add command line option to extend MCE
 Records pool
To: Avadhut Naik <avadhut.naik@amd.com>, <x86@kernel.org>,
	<linux-edac@vger.kernel.org>
CC: <bp@alien8.de>, <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
	<yazen.ghannam@amd.com>, <avadnaik@amd.com>
References: <20240207225632.159276-1-avadhut.naik@amd.com>
 <20240207225632.159276-3-avadhut.naik@amd.com>
Content-Language: en-US
From: Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20240207225632.159276-3-avadhut.naik@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXhUYUZ5Tm5vMWdZU3AvRThKQTRRY1dlTEtZb2RodTArb2djUW5hRitSU1RG?=
 =?utf-8?B?amN4ZkJFZTM2Mi9IamZGbkpJZncxTTZzQm5BdTM2ZFBIUmVQVEZHODdqaytl?=
 =?utf-8?B?Y3ZMNHhleVhIZU5HRkZxYkpYR0t6cW11ZkMrRUFHdUU2eW1MM1djZGRlRWRv?=
 =?utf-8?B?dWNoaisvbWpsUlZJN0JHeDBKdzhrT09zcXBSSWFhakVabHA4dVF2VVJVR011?=
 =?utf-8?B?elNUN2dxKzZkL3FUMHh3V2pmSnVVdUw0cEEwbm5ZQkpjK1RadXlqQVp2ajNU?=
 =?utf-8?B?SlVOd1ZyamNqUlI2UW16dUNMS0Z1K3gyclNWTHVkNDhIZnRPWVk0TDVNM0FI?=
 =?utf-8?B?ZHVyNGgwUE9yVU5EcFZFRHI2UDV4eDNCQzJDYzJOc2FIT21zeHZ2dENiUWZN?=
 =?utf-8?B?dkxEYzB4ajNxcllnK2JrVUNsV05vcVlRMi9FTmhzb3ZqR1RxR25sN1JwVnlQ?=
 =?utf-8?B?d1Y4eWZiOG9zdTV3cEhicnNLRmhTT3NXNWZoaElTZnhxSjhCOXBkcEh2KzBa?=
 =?utf-8?B?bG9CMms0R1piLytxQVpHTVRjSG90akt4NzFub2pCSWFwK0pVRVJNSklFcTRh?=
 =?utf-8?B?Yi9BejVTZkdUOXpySzU1M3NvSkxjb1o2T1pmcnVGL3dTL1RaYlFKdmh3Q1U0?=
 =?utf-8?B?cWxKdHdja1hCa0dLM3lSeUVMM3FIaWRDRFZoK1ZPdUhYS1ZPRnU3SlJCOGJX?=
 =?utf-8?B?d2IvUE80Ym42TjFQMUVlSTN2dlQ0aENQZTUxQk5JVEtEK3d3SFVWUU9xV29U?=
 =?utf-8?B?RVppTUdBTWdMZVZxTU1QSGFJOGZWWDF1bktpLzNqRnlCNDYrWlExV2lpVVgz?=
 =?utf-8?B?NFdSRFFQOEFIRTFnOUVTbUNMblA3K09JY2wyTXdFQlhza21ITDk3bHNLZnN1?=
 =?utf-8?B?QkpKeFVLMmxCdG5DVWtPQmZWMDVxbEZHZkN5cXhCekRLcUxFTVFwRkFpNkwv?=
 =?utf-8?B?WjY5d0tOT0YzT0xmbHZjWm92M2FERkJKNXA3b0UydWk4c2VaSW1OSXlDeXlx?=
 =?utf-8?B?ekZ3eWtDZUdERmhySHBpR2krTitwWFdyNzVUK3RKS2xlb2FZNUROQklJN2c1?=
 =?utf-8?B?U3pCdUxCTjgydVZVVUhZTjBQVmFTdjl0VEd6YnZXWnFCdDQ1RTdsblRaRkEw?=
 =?utf-8?B?YnhiN0hoZVNMajBEZEpwYW9kWmZMMzhxckt2Mmw5cW5FWnJYSUI0ekdCSXdo?=
 =?utf-8?B?cDFSUGdFekZkWmdqdUJSK2x2ZUZpQTlCKzZjakFsRmMvS0xDcWtCQjVsRERU?=
 =?utf-8?B?c0pCQ2tLTndBcHVEd3BJYmlkdEdaS3A2MCszMjF6N1N6RTMrbDdURHc3Vi9Z?=
 =?utf-8?B?bWdTc01lUy9RcENrQkxNQ2trRlkzT3crb24zd3hKSmJCcjI4KzhNUkRWOHkv?=
 =?utf-8?B?QllKQmQ0OTZ2bnMzMXFLZ0ttSWNLQ3EwUjN4SUJybC9FWUd0UlNFMitYUjBv?=
 =?utf-8?B?cVczc3RrcVJqM3RWZXJPTlVHKzZBSmdkWTBoTGdrbWZIZVVUOW5PYWJhYXFt?=
 =?utf-8?B?YVNPdXVodzZGTUNQdVErU21jYmpMU3FiUnIxdndTRzZ5WU12RjlISURmYzlz?=
 =?utf-8?B?TjVTMlVUOU1NOElYY0FYdE0zRmVzUE9udU1LZGdsRHlvZ3lLZ1hkeDVOYS82?=
 =?utf-8?B?NEVVL3pIdzBZTzFXSFUvWlE3eEZvYnRuVFJQRjRxV1kwZWlMNlUyTzBiVmNL?=
 =?utf-8?B?K2Z2VW9waDlJRXVPdmJYUElxYXFqY25teWxOTG00Q0VUeFB6d0JFZmNTTHI3?=
 =?utf-8?B?dVYrdW8zL1pEemx4bmIyVTNuOElVZGVYSFlmWTBjUTk1TlAySFd3eGJ1ZVZs?=
 =?utf-8?B?clZMOTgzejU2ZXQ0eHRBTnlWU0ZHQUxISmVHeVZxMUdpcjc5Q3k0MTB0Y1dB?=
 =?utf-8?B?cmVCa2ZXR3FXYTB4MnBCcjFHZnFNSUx2ams3bnk4bVRyUlJFSlJyQ2I2c1ZS?=
 =?utf-8?B?bDBZUStEb1BRTDdNY1I2N3NubHd6Z2VSdHMzWVNvN09paFBNbHY1blJSeEhU?=
 =?utf-8?B?YjNRUmRzZUZpK3o3Sml5bS81aVNEWHVRNGlqUXM5U2hURUZiR0F5dThvWFho?=
 =?utf-8?B?ejBCNHc0Z21OMUhhVkk0N3lnZXd4ZEZjODdzMklRVVM3ZWxvMXRTSWdBV3p2?=
 =?utf-8?Q?+F98AsWzJwI1PE9HZSvth8+o8?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d3ec6df-f9a2-40fd-5af0-08dc290f7950
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 01:36:01.7458
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r6+gbbsFwtZ6yhcscc+51ZDPoBFDg5HSJn4vFy4NvgS26bRMkbKx2UQWw/yq6CmbO5lsMc9dl2VLG42Amu7NcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8059
X-OriginatorOrg: intel.com

On 2/7/2024 2:56 PM, Avadhut Naik wrote:
> Extension of MCE Records pool, based on system's CPU count, was undertaken
> through the previous patch (x86/MCE: Extend size of the MCE Records pool).
> 

This statement is unnecessary.

> Add a new command line parameter "mce-genpool-extend" to set the size of
> MCE Records pool to a predetermined number of pages instead of system's
> CPU count.
> 

Like Tony, I am unsure of when this would be useful.

Also, why does it need to override the CPU count based extension
mechanism? Would just adding more pages not work for them?

If there really is a good reason to do this, how about changing
mce-genpool-extend to mce-genpool-add-pages and keeping the description
the same?

mce-genpool-add-pages=	[X86-64] Number of pages to add to MCE Records pool.

Then you can simply add these many number of additional pages to the new
CPU based mechanism.

Sohil

> Signed-off-by: Avadhut Naik <avadhut.naik@amd.com>
> ---
>  .../admin-guide/kernel-parameters.txt         |  2 ++
>  arch/x86/kernel/cpu/mce/genpool.c             | 22 ++++++++++++++++---
>  2 files changed, 21 insertions(+), 3 deletions(-)
>