Received-SPF: pass (google.com: domain of linux-kernel+bounces-58949-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 8 Feb 2024 18:51:30 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Sai Krishna <saikrishnag@marvell.com>
Cc: <richardcochran@gmail.com>, <horms@kernel.org>,
 <vinicius.gomes@intel.com>, <vadim.fedorenko@linux.dev>,
 <davem@davemloft.net>, <netdev@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>, <sgoutham@marvell.com>,
 <gakula@marvell.com>, <lcherian@marvell.com>, <hkelam@marvell.com>,
 <sbhatta@marvell.com>, Naveen Mamindlapalli <naveenm@marvell.com>
Subject: Re: [net-next PATCH v2] octeontx2: Add PTP clock driver for Octeon
 PTM clock.
Message-ID: <20240208185130.23509cb3@kernel.org>
In-Reply-To: <20240206181009.1143910-1-saikrishnag@marvell.com>
References: <20240206181009.1143910-1-saikrishnag@marvell.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 6 Feb 2024 23:40:09 +0530 Sai Krishna wrote:
> The PCIe PTM(Precision time measurement) protocol provides precise
> coordination of events across multiple components like PCIe host
> clock, PCIe EP PHC local clocks of PCIe devices. This patch adds
> support for ptp clock based PTM clock. We can use this PTP device
> to sync the PTM time with CLOCK_REALTIME or other PTP PHC
> devices using phc2sys.

A bit of an odd driver, somewhat similar to what Amazon described.
You register a PTP clock but there's no PTP involved. Also you call
pci_get_device() instead of binding to a proper bus.

Please repost this, add linux-pci and the PCI maintainers to the CC.
It'd be great to get their acks (in addition to Richard's).
-- 
pw-bot: cr