Received-SPF: pass (google.com: domain of linux-kernel+bounces-58991-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <266a5ecd-30f8-4450-ab9a-e4f239ad640d@amd.com>
Date: Fri, 9 Feb 2024 09:28:29 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: linux-next20240208: tg3 driver nw interfaces not getting
 configured
To: Heiner Kallweit <hkallweit1@gmail.com>,
 Stephen Rothwell <sfr@canb.auug.org.au>, andrew@lunn.ch,
 Jakub Kicinski <kuba@kernel.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
 Linux Regressions <regressions@lists.linux.dev>,
 open list <linux-kernel@vger.kernel.org>
References: <20240208155740.24c6ada7@canb.auug.org.au>
 <ce7150b7-b6f1-4635-ba5f-fdfda84a6e2f@amd.com>
 <fd72544a-f3ed-44bb-86e3-bdfa4fca720e@gmail.com>
 <8a59f072-4a71-4662-bfde-308b81e4ce88@amd.com>
 <47987433-7d56-483e-a0fc-38140cc17448@gmail.com>
 <11baa678-8cbe-4a9a-af09-381d649d648c@amd.com>
 <aa9a3495-22fd-4fac-abb0-afedf1b4d8ec@gmail.com>
Content-Language: en-US
From: "Aithal, Srikanth" <sraithal@amd.com>
In-Reply-To: <aa9a3495-22fd-4fac-abb0-afedf1b4d8ec@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?KzZWMFNqQU1LNWFjWDIrRDNmZElvNHN2MndLT2VjMTZUcEU0QUZSNUpXcDdQ?=
 =?utf-8?B?dDlKTXRYSXpNN1pXYzdpRkRhMVEzNUpnbzhQZjVsZENHLzEvS1R2V0hNL2RO?=
 =?utf-8?B?UFFTTms3bXA0SlFhMUpuenRaYUlpc01EZjE5MmNYa2VqWHk0ait2WVhZdzMr?=
 =?utf-8?B?dE51eE55STJJbjFsVnFKd2lmTWRTWlJ4aERJQnc0UGdmdkVRbnltbDJmYUJr?=
 =?utf-8?B?ekxOMVlRSnlwTnJKVVp0Q0JtenFTN3o3Sm8xdSs0MThIc05BNTlZZHdlTSsz?=
 =?utf-8?B?NWVZY2R2Qlo3SCsvVGlPbHlsMGFkV0JFY1VTc1o2N2lUZkQyU2RRTGIweHBZ?=
 =?utf-8?B?c01jSlRuYk0yL3RLeDhyTnl5dXhkTTRxemZ6WDhYVVhyKzFtLzRhaXVRTDl0?=
 =?utf-8?B?UnlGM3ZwSU1WWlM0emw2VjJJZzFuUk4vR3NKM3d4NVE5dHc2MmpnUUVVNVNN?=
 =?utf-8?B?QUgvUSt0c2hmTGI3TVd1dFltTTNoK1pZS24wOFNnNkp1T2R6UFgwODhpWmlD?=
 =?utf-8?B?eGE1eHkvVjg2TFBCemhxbHNGSCtSUjhwcEtkTmh6eDBwdTdKdVlQbDBXRnUx?=
 =?utf-8?B?THcxMFhUYXpqMWlsK2cyS3gyTDMvRWdLUmp0OWFrRlN6TFR6b1VxTWdELzc2?=
 =?utf-8?B?cnVRMFYydlJlem1JN201bERrWGI0ZXZ2UmY4ZFEwTTdaR0svanZ6STFhNnlo?=
 =?utf-8?B?MWVMTWcxQW85L1JzeXM4Ym9hUmtLTzcza25zb0RhQXlsa0phVkdqYkxzc251?=
 =?utf-8?B?Q0xweHBXR3VtUmVTb0FlYlVZeXdyTnVVWkJxdVJ0RGRyTFMzb3N5RkE2UlU1?=
 =?utf-8?B?c0d6RytYSHRNUmFubndBcnZ3SDFsVk85Sm1EbGRqRDRtdzZVckU2V1V5WDI5?=
 =?utf-8?B?VEhIcGVFYjFnLzJWMHFtL081TFZpZVhXY0Y1OUg1SWtlb2xYRlNvVklSSnR5?=
 =?utf-8?B?NzlsclhkOWlGcW5Hd1BOZWZRYjJUbGJMSVpuT2VPRzZmc2JEOHhheWFOa1pC?=
 =?utf-8?B?Y2lnZklhK0FXTm1Qamp4ZjRFd2IxcW9na1JYMTlvSXJnRlNzNFZpREc3WVhy?=
 =?utf-8?B?WU9VRnUvK05nZzB6bTV3MExEanlkVysranZZcVhZeWVJT2xEME1RY1FhVDM1?=
 =?utf-8?B?TFU3Unl2NlVvcW92NUo0MEFEMndZYXVNaUM5NmJ2bVd5dFhmVnhQOEIyREtQ?=
 =?utf-8?B?SndlYzdSSlpBK3NTVE54NTlPbkRnbU1TanJHWVBOaFhSUFJKZ1VxazIybXpp?=
 =?utf-8?B?aGgxTUlwclBDYURFR3RKc1c3ME5VNENlNUlVb0VmVXBMN3lUQnZyalJtT3g2?=
 =?utf-8?B?MHpNY0hCTGc2VGQzWVhSNWpxdGt1c1FBODlpTVhNc2hsKzVPYjJNZ1E1aDFT?=
 =?utf-8?B?bEc4a0ZNVWtlZHFkelpTSkhxekNqM2M1VjRBVk9ndUhPNmtDNCtJdUh5dGZx?=
 =?utf-8?B?ZXowcEJ5OGIzRTdBc1EvZ243RktQT1dQMWVTOEJYcTJ2QUhZbmxZUmE4WVRZ?=
 =?utf-8?B?cTVEZ1dRZTMrR0o5VG42RVBwamtMTWorbEl4Qnh0cUZDVkhEY21vYlRtWkU2?=
 =?utf-8?B?dW1ycWxISUw3Yy9wTnFnSFdlR2trdjdCUHZmdFN3bFl5M0hHQkRzZWpjU04z?=
 =?utf-8?B?aHpmcnY1WkNIemtZcFhvcVAzQ0hMbHk3cnlBb2wrb0JvVVFrR3g3TFIyWDdw?=
 =?utf-8?B?L1g0bXFGWkEyRkxRNHYvZUxEc21icEtodFVWQ3cyY3ZHNVRsRmpSV0F2dXl6?=
 =?utf-8?B?TzhmYjQxQXo5TVl2SW9sVmoxVTdJcDVvcnRpOXliem93a3lFTlNQcVZNeVlV?=
 =?utf-8?B?ZnRJeEdBOEV5Zk93T3plNWZQRFgvelFXWTZ0WDRJL09Ec2UxcHFhTlRmMk51?=
 =?utf-8?B?QmxRKzQwOXVVdEZ0Nzdua2xZemtMSnVIdmdVcnQ3emdTaTlSQ0FiNlo2WVNE?=
 =?utf-8?B?YlU4ZWdmUGdjYUFPUSszcERmZDZ2NkNHV3cxQnJSYzdDaGZSMjhIUlZSbmRp?=
 =?utf-8?B?RUlJV002WmlXakJZTDd6aEtkaS9IakR4UXZpd1h2QmkybkRXMUlRRlpsWWp6?=
 =?utf-8?B?bEtYTkJyZHRIb2RuTEpQS3VaVFJseTJHcXgyMXhCaCtpUEMvU1k0WjF3aUxh?=
 =?utf-8?Q?59IrZHCu8zNk84pGXNIo999FG?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb0eb352-2b51-436f-f1a7-08dc292363e8
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6460.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 03:58:35.9562
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k23zALlYwvNX+uV4mKSdxl2g2DXjEq8OD+xUWqlL+dgX06O+PF+ZvHxDPFN7iRP+xt8bgyO9lZA07T4HdQtvnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8070

On 2/9/2024 3:48 AM, Heiner Kallweit wrote:
> On 08.02.2024 16:28, Aithal, Srikanth wrote:
>> On 2/8/2024 7:32 PM, Heiner Kallweit wrote:
>>> On 08.02.2024 12:05, Aithal, Srikanth wrote:
>>>> On 2/8/2024 4:16 PM, Heiner Kallweit wrote:
>>>>> On 08.02.2024 09:30, Aithal, Srikanth wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On 6.8.0-rc3-next-20240208, the network interfaces are not getting configured.
>>>>>>
>>>>> Thanks for the report. Could you please elaborate on what "not getting
>>>>> configured" means in detail?
>>>>> - Any error in any log?
>>>>> - Any other error message?
>>>>> - Interface doesn't come up or which specific configuration are you missing?
>>>>>
>>>> I am not seeing any errors in the dmesg,
>>>>
>>>> [    4.019383] tg3 0000:c1:00.0 eth0: Tigon3 [partno(BCM95720) rev 5720000] (PCI Express) MAC address d0:8e:79:bb:95:90
>>>> [    4.019391] tg3 0000:c1:00.0 eth0: attached PHY is 5720C (10/100/1000Base-T Ethernet) (WireSpeed[1], EEE[1])
>>>> [    4.019394] tg3 0000:c1:00.0 eth0: RXcsums[1] LinkChgREG[0] MIirq[0] ASF[1] TSOcap[1]
>>>> [    4.019397] tg3 0000:c1:00.0 eth0: dma_rwctrl[00000001] dma_mask[64-bit]
>>>> [    4.041082] tg3 0000:c1:00.1 eth1: Tigon3 [partno(BCM95720) rev 5720000] (PCI Express) MAC address d0:8e:79:bb:95:91
>>>> [    4.041087] tg3 0000:c1:00.1 eth1: attached PHY is 5720C (10/100/1000Base-T Ethernet) (WireSpeed[1], EEE[1])
>>>> [    4.041090] tg3 0000:c1:00.1 eth1: RXcsums[1] LinkChgREG[0] MIirq[0] ASF[1] TSOcap[1]
>>>> [    4.041092] tg3 0000:c1:00.1 eth1: dma_rwctrl[00000001] dma_mask[64-bit]
>>>> [    4.077483] tg3 0000:c1:00.1 eno8403: renamed from eth1
>>>> [    4.124657] tg3 0000:c1:00.0 eno8303: renamed from eth0
>>>>
>>>> nmcli says interfaces are disconnected:
>>>>
>>>> [root@localhost ~]# nmcli
>>>> eno8303: disconnected
>>>>           "Broadcom and subsidiaries NetXtreme BCM5720"
>>>>           ethernet (tg3), D0:8E:79:BB:95:90, hw, mtu 1500
>>>>
>>>> eno8403: disconnected
>>>>           "Broadcom and subsidiaries NetXtreme BCM5720"
>>>>           ethernet (tg3), D0:8E:79:BB:95:91, hw, mtu 1500
>>>>
>>>> I am attaching host dmesg.
>>>>
>>>
>>> Thanks. dmesg lists no error. Please send output from the following commands.
>>>
>>> ip link
>> 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000
>>      link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
>> 2: eno8303: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
>>      link/ether d0:8e:79:bb:95:90 brd ff:ff:ff:ff:ff:ff
>>      altname enp193s0f0
>> 3: eno8403: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
>>      link/ether d0:8e:79:bb:95:91 brd ff:ff:ff:ff:ff:ff
>>      altname enp193s0f1
>>
>>> ethtool <if>
>> Settings for eno8303:
>>          Supported ports: [ TP ]
>>          Supported link modes:   10baseT/Half 10baseT/Full
>>                                  100baseT/Half 100baseT/Full
>>                                  1000baseT/Half 1000baseT/Full
>>          Supported pause frame use: No
>>          Supports auto-negotiation: Yes
>>          Supported FEC modes: Not reported
>>          Advertised link modes:  10baseT/Half 10baseT/Full
>>                                  100baseT/Half 100baseT/Full
>>                                  1000baseT/Half 1000baseT/Full
>>          Advertised pause frame use: No
>>          Advertised auto-negotiation: Yes
>>          Advertised FEC modes: Not reported
>>          Speed: Unknown!
>>          Duplex: Unknown! (255)
>>          Auto-negotiation: on
>>          Port: Twisted Pair
>>          PHYAD: 1
>>          Transceiver: internal
>>          MDI-X: Unknown
>>          Supports Wake-on: g
>>          Wake-on: d
>>          Current message level: 0x000000ff (255)
>>                                 drv probe link timer ifdown ifup rx_err tx_err
>>          Link detected: no
>>
>> Settings for eno8403:
>>          Supported ports: [ TP ]
>>          Supported link modes:   10baseT/Half 10baseT/Full
>>                                  100baseT/Half 100baseT/Full
>>                                  1000baseT/Half 1000baseT/Full
>>          Supported pause frame use: No
>>          Supports auto-negotiation: Yes
>>          Supported FEC modes: Not reported
>>          Advertised link modes:  10baseT/Half 10baseT/Full
>>                                  100baseT/Half 100baseT/Full
>>                                  1000baseT/Half 1000baseT/Full
>>          Advertised pause frame use: No
>>          Advertised auto-negotiation: Yes
>>          Advertised FEC modes: Not reported
>>          Speed: Unknown!
>>          Duplex: Unknown! (255)
>>          Auto-negotiation: on
>>          Port: Twisted Pair
>>          PHYAD: 2
>>          Transceiver: internal
>>          MDI-X: Unknown
>>          Supports Wake-on: g
>>          Wake-on: d
>>          Current message level: 0x000000ff (255)
>>                                 drv probe link timer ifdown ifup rx_err tx_err
>>          Link detected: no
>>
>>> ethtool --show-eee <if>
>> EEE settings for eno8403:
>>          EEE status: enabled - inactive
>>          Tx LPI: 2047 (us)
>>          Supported EEE link modes:  100baseT/Full
>>                                     1000baseT/Full
>>          Advertised EEE link modes:  100baseT/Full
>>                                      1000baseT/Full
>>          Link partner advertised EEE link modes:  Not reported
>>
>> EEE settings for eno8303:
>>          EEE status: enabled - inactive
>>          Tx LPI: 2047 (us)
>>          Supported EEE link modes:  100baseT/Full
>>                                     1000baseT/Full
>>          Advertised EEE link modes:  100baseT/Full
>>                                      1000baseT/Full
>>          Link partner advertised EEE link modes:  Not reported
>>
>>>
>>> If the interfaces aren't up, please try to bring them up manually and see what happens.
>>> ip link set <if> up
>> Nothing happens.
>> [root@localhost ~]# ip link set eno8303 up
>> [root@localhost ~]# ip link set eno8403 up
>> [root@localhost ~]# ip link
>> 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000
>>      link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
>> 2: eno8303: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
>>      link/ether d0:8e:79:bb:95:90 brd ff:ff:ff:ff:ff:ff
>>      altname enp193s0f0
>> 3: eno8403: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
>>      link/ether d0:8e:79:bb:95:91 brd ff:ff:ff:ff:ff:ff
>>      altname enp193s0f1
>>
>>>
>>>
>>>>>> I have 'NetXtreme BCM5720 Gigabit Ethernet PCIe'
>>>>>>           configuration: autonegotiation=on broadcast=yes driver=tg3
>>>>>>
>>>>>> If I revert below commit I am able to get back the interfaces mentioned.
>>>>>>
>>>>>> commit 9bc791341bc9a5c22b94889aa37993bb69faa317
>>>>>> Author: Heiner Kallweit <hkallweit1@gmail.com>
>>>>>> Date:   Sat Feb 3 22:12:50 2024 +0100
>>>>>>
>>>>>>        tg3: convert EEE handling to use linkmode bitmaps
>>>>>>
>>>>>>        Convert EEE handling to use linkmode bitmaps. This prepares for
>>>>>>        removing the legacy bitmaps from struct ethtool_keee.
>>>>>>        No functional change intended.
>>>>>>
>>>>>>        Note: The change to mii_eee_cap1_mod_linkmode_t(tp->eee.advertised, val)
>>>>>>        in tg3_phy_autoneg_cfg() isn't completely obvious, but it doesn't change
>>>>>>        the current functionality.
>>>>>>
>>>>>>        Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>>>>>        Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>>>>>>        Link: https://lore.kernel.org/r/0652b910-6bcc-421f-8769-38f7dae5037e@gmail.com
>>>>>>        Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>>>>>>
>>>>>>
>>>>>> The same works fine on 6.8.0-rc3-next-20240207.
>>>>>>
>>>>>> Thanks,
>>>>>> Srikanth Aithal
>>>>>> sraithal@amd.com
>>>>> Heiner
>>>
>>
> 
> Could you please test whether the following fixes the issue for you?
> 
> The uninitialized struct ethtool_keee causes the bug because
> mii_eee_cap1_mod_linkmode_t() leaves unknown bits as-is.
> 
> ---
>   drivers/net/ethernet/broadcom/tg3.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index 50f674031..7d0a2f5f3 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -4616,7 +4616,7 @@ static int tg3_init_5401phy_dsp(struct tg3 *tp)
>   
>   static bool tg3_phy_eee_config_ok(struct tg3 *tp)
>   {
> -	struct ethtool_keee eee;
> +	struct ethtool_keee eee = {};
>   
>   	if (!(tp->phy_flags & TG3_PHYFLG_EEE_CAP))
>   		return true;

This fix on top of next20240208 resolves the issue. Thank you.

Tested-by: Srikanth Aithal <sraithal@amd.com>