Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp739036rdb; Thu, 8 Feb 2024 22:23:47 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWsejyvkbDvhOyT8BKlNq4Wtq4iuTt5yzcHJ2ruT2GrNnXll89Wbrojmirjd+DDSdjaoqYrBztTYFrERIfKmgdpS9RTu28/sVQ9e0l90A== X-Google-Smtp-Source: AGHT+IETiL62PakbdShq4mwrkHPecyQMYg00tUbkmD7y89BwqNNpPbbXunA7Wa+uFeyOckfb4PxH X-Received: by 2002:a25:744e:0:b0:dc6:bbbc:80e4 with SMTP id p75-20020a25744e000000b00dc6bbbc80e4mr586478ybc.4.1707459827472; Thu, 08 Feb 2024 22:23:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707459827; cv=pass; d=google.com; s=arc-20160816; b=RJOEYm8cmsRea0hTWzwNscRyP4FvR2qcon/SnpEm77FGdERW4SuWq81gOXMPLnwr+R fYYOmrqZVnLkoUeT9kqRSD389wf0rjiuoAtniIXZoiGeUnQY8ThX0thpWlyapGk7c0ps zU3cK4ZC9rseG1Xnm67VwGIz517QJWUbetcsI/HkEc87gUxnocPCKXF9ceQU0PWBOXbm Rvm8rgXMp9rU0sUnyhm5ItGnfhhLMBpEuOtLnNq57PlaZjumxVHV2C6D0Xh1Hl3jIPiA zSIvWt53ruW+1YRKgHaEPzagD1+ERjRhvbCwowyQLc9tyU+8wGyedYmWTLkRT9j4XcLj vGXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=reply-to:cc:to:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:message-id:date :subject:from:dkim-signature; bh=Ex9L+6R2A1gF3eruoGqts7kOEdqsbZg++2PSUZBdBcw=; fh=qok2hyYVjJ+B987dfElmtvkIXLLb8cpbPavyHS9xBz4=; b=aQlDoLH5lpSP1/UDd94Zt6cKx9rdQE3sAWV+8sf0d8yFct9cVR7eubUVMyHAhpjxnI 28ARweJ7zbQhXWJs+RUIcIzpuJadp4dzRci0aQvz2X40ySApTz9qQlodyZlo+A6JSanj mpdCYgdofdRfi9RSp2Qzj9brEYvhtDdaREf1FCI4QL+I/MuUNPN5q3FuLY3bIsUnzcWk yeUaGNzSJ+ywHWb5BGQ5S7uWJERV4hTBjOVwDwdeRsr3QFT7sH/kPhmLB9kbyreezOrh pte6kDdxmcxxGk7PTfNHdL/7y3XvMVJUJGFnESUnad+T4EOpqZTpQKsziuIbKMlbdiNy u67A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AhDQVfRd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-59038-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59038-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUXyjf/uoZRqpazllKMhU071KIh2QVOL8L+djU5EhncX+9KHSg+knQsYoHpYdSXpx/GReHv34STKJ+DY85vHeqySHUcfprhMQY6yagSxw== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id b24-20020a6567d8000000b005c66368cfb2si1163930pgs.451.2024.02.08.22.23.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 22:23:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-59038-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AhDQVfRd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-59038-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59038-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5247BB279FA for ; Fri, 9 Feb 2024 06:23:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C73D15788E; Fri, 9 Feb 2024 06:23:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AhDQVfRd" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC2BF57305; Fri, 9 Feb 2024 06:23:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707459796; cv=none; b=tua/dDSWtPplY3RJworWOEE0Qg6xiSAYu/On2KEDnhdRHtjt+R12ijSSw0qnZRAL848R8LzDvJ0CQaBMbsFrB2dnWek/DEL6UMpCMZi67Nm/kRDVTHxu7SyUuinhxs5ZN7VBVhqeXgW5zuWSN/BCbMFDHcVvqPvRO2LXtfb7jUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707459796; c=relaxed/simple; bh=J4f3TyvsxnSOkgjExvpc7kBzlh95/CH4/HIPYUavxPw=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=R7E22LNapsr8GTHkTINnKCkwJCv+gR5T8zD7U7PlMu+vISNqEWx1iDoxLEV3GXnxu7NLa1EEggVjKS95UWuqvtYzxxJNQ8mekR7WH6kJ+n/iGnpP9WPRAoY+Cs0Eqy3g7/PNtueU/QsiZSV3ph7omvXjLWUVI8PL9cnCe2xh4FI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AhDQVfRd; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id 193DDC433C7; Fri, 9 Feb 2024 06:23:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707459796; bh=J4f3TyvsxnSOkgjExvpc7kBzlh95/CH4/HIPYUavxPw=; h=From:Subject:Date:To:Cc:Reply-To:From; b=AhDQVfRdsrwSl/1hlb0WH0jduy7/R5tMx3Y471HGYk7YQnl2zAlLtXrYUxu+V+qmY 3N/oJ3tk/dj9mA4SOlHFiS5ymICZgifS8Kqs4ihHzQ0an4K3oxitmvfzD0uQkR5A/5 HS9kIMMHGnH3aHi8eIzfF5VO5/V4H0Y3/lzHGmwmKWs4hJeceQPX3Xx7TLTZ4WQpKP +oKz7ml+ElSiWRNY+q/ANjFjzjQWzqt1cbuFrK7d031ZeMg8tf9VmFHyv4IIwiubPC OAV+N9jK5HivNgJK8Ryj0fSiobUfRpy+E1q6d20qWSvsoFl8iXCPkIpv523Zsf8PxH e2XORI6yTLkdA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0918C48297; Fri, 9 Feb 2024 06:23:15 +0000 (UTC) From: Christoph Winklhofer via B4 Relay Subject: [PATCH v6 0/3] w1: add UART w1 bus driver Date: Fri, 09 Feb 2024 07:22:36 +0100 Message-Id: <20240209-w1-uart-v6-0-3e753c149196@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAKzExWUC/12OzW7CMBAGXwX5zEbr3xhOvEfVg5OsiQuJkZOGV ijvXgeJ1uphD5+0M5oHmygFmthx92CJljCFOOZh9jvW9m48E4QubyZQKOSo4M7h06UZiKyx2nH tNLL8fUvkw9fT9Paet09xgLlP5F685CIfokJbKYXaAIf2o7qH8XLto6d0Og8uXKs2DpuwD9Mc0 /ezbJGb9hWhfyMWCQi5o8aDbATVplBsEYsqOfPHqczVnrisrbONpP+cLjhRcDpzvLOi8V0rHB1 Kbl3XHwVGuq5PAQAA To: Krzysztof Kozlowski , Rob Herring , Conor Dooley , Christoph Winklhofer , Rob Herring , Greg Kroah-Hartman , Jiri Slaby , Krzysztof Kozlowski , Jonathan Corbet Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707459793; l=5105; i=cj.winklhofer@gmail.com; s=20240104; h=from:subject:message-id; bh=J4f3TyvsxnSOkgjExvpc7kBzlh95/CH4/HIPYUavxPw=; b=JwwE1pqxWGJywhS7eAGACb23QEqy8Ww7tLs8uqHowXQou9kATMor83zCc+uP3q4b4O98IHF0y dIA/3x0dnqICWtwN4pEgjd+YJafc8+1rkMUWdDVJZqPMSoa/vz85FJ6 X-Developer-Key: i=cj.winklhofer@gmail.com; a=ed25519; pk=lgjGjOt7hFKJT9UXhgUyrdthxvZ7DJ5F1U/7d9qdAsk= X-Endpoint-Received: by B4 Relay for cj.winklhofer@gmail.com/20240104 with auth_id=111 X-Original-From: Christoph Winklhofer Reply-To: Hello! This patch contains a driver for a 1-Wire bus over UART. The driver utilizes the UART interface via the Serial Device Bus to create the 1-Wire timing patterns. Changes in v6: - change order of patches for dt-binding - remove unnecessary lock in remove - delay for 1-Wire cycle without mutex lock - fix comment style and add some more comments - Link to v5: https://lore.kernel.org/r/20240126-w1-uart-v5-0-1d82bfdc2ae9@gmail.com Thanks Krzysztof and Rob for the review. Changes in v5: - dt-binding: allow child object for onewire and use prefix -bps for baud rate configuration. - use type u8 for a byte, instead of unsigned char - use constants (NSEC_PER_SEC, BITS_PER_BYTE) - make delay computation from packet time more coherent - Link to v4: https://lore.kernel.org/r/20240106-w1-uart-v4-0-7fe1378a8b3e@gmail.com Thanks Jiri, Krzysztof and Rob for the review. Changes in v4: - rework baud-rate configuration: also check max bit-time, support higher baud-rates by adding a delay to complete 1-Wire cycle. - dt-binding w1-uart: specify baud-rates for 1-Wire operations - Link to v3: https://lore.kernel.org/r/20240105-w1-uart-v3-0-8687093b2e76@gmail.com Changes in v3: - improve baud-rate configuration: use specific limits for 1-Wire reset, touch-0 and touch-1 operation, compute in nanoseconds. - remove unused header atomic.h - use function instead of macro to compute bit-time from baud-rate - switch to b4 util to publish patch: missing recipients - Link to v2: https://lore.kernel.org/lkml/20231223100408.44056-1-cj.winklhofer@gmail.com Changes in v2: - add documentation for dt-binding - allow onewire as serial child node - support different baud-rates: The driver requests a baud-rate (9600 for reset and 115200 for write/read) and tries to adapt the transmitted byte according to the actual baud-rate returned from serdev. - fix locking problem for serdev-receive and w1-master reset/touch: The received byte is now protected with a mutex - instead of the atomic, which was used before due to the concurrent store and load. - explicit error in serdev-receive: Receiving more than one byte results in an error, since the w1-uart driver is the only writer, it writes a single-byte and should receive a single byte. - fix variable names, errno-returns, wrong define CONFIG_OF - fix log flooding - fix driver remove (error-path for rxtx-function) - Link to v1: https://lore.kernel.org/all/20231217122004.42795-1-cj.winklhofer@gmail.com Krzysztof, thank your very much for your feedback! It was tested on a "Raspberry Pi 3 Model B+" with a DS18B20 and on a "Variscite DART-6UL" with a DS18S20 temperature sensor. Content: - Patch 1: device tree binding 1-Wire - Patch 2: allow onewire as serial child node - Patch 3: driver and documentation The patch was created against the w1 subsytem tree (branch w1-next): Link: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-w1.git/ The checkpatch.pl script reported the following error - which I am not sure how to fix: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? The technical details for 1-Wire over UART are in the document: Link: https://www.analog.com/en/technical-articles/using-a-uart-to-implement-a-1wire-bus-master.html In short, the UART peripheral must support full-duplex and operate in open-drain mode. The timing patterns are generated by a specific combination of baud-rate and transmitted byte, which corresponds to a 1-Wire read bit, write bit or reset pulse. For instance the timing pattern for a 1-Wire reset and presence detect uses the baud-rate 9600, i.e. 104.2 us per bit. The transmitted byte 0xf0 over UART (least significant bit first, start-bit low) sets the reset low time for 1-Wire to 521 us. A present 1-Wire device changes the received byte by pulling the line low, which is used by the driver to evaluate the result of the 1-Wire operation. Similar for a 1-Wire read bit or write bit, which uses the baud-rate 115200, i.e. 8.7 us per bit. The transmitted byte 0x00 is used for a Write-0 operation and the byte 0xff for Read-0, Read-1 and Write-1. Hope the driver is helpful. Thanks, Christoph --- Christoph Winklhofer (3): dt-bindings: serial: allow onewire as child node dt-bindings: w1: UART 1-Wire bus w1: add UART w1 bus driver .../devicetree/bindings/serial/serial.yaml | 2 +- Documentation/devicetree/bindings/w1/w1-uart.yaml | 60 +++ Documentation/w1/masters/index.rst | 1 + Documentation/w1/masters/w1-uart.rst | 54 +++ drivers/w1/masters/Kconfig | 10 + drivers/w1/masters/Makefile | 1 + drivers/w1/masters/w1-uart.c | 417 +++++++++++++++++++++ 7 files changed, 544 insertions(+), 1 deletion(-) --- base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d change-id: 20240104-w1-uart-ee8685a15a50 Best regards, -- Christoph Winklhofer