Received-SPF: pass (google.com: domain of linux-kernel+bounces-59079-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+3f0a39be7a2035700868@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [bluetooth?] KASAN: slab-use-after-free Write in __hci_acl_create_connection_sync
Date: Fri,  9 Feb 2024 15:37:18 +0800
Message-ID: <20240209073719.84-1-hdanton@sina.com>
In-Reply-To: <000000000000b7b62e0610db6b8a@google.com>
References: 
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On Thu, 08 Feb 2024 01:27:31 -0800
> HEAD commit:    b1d3a0e70c38 Add linux-next specific files for 20240208
> git tree:       linux-next
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=107c2d8fe80000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git  master

--- x/net/bluetooth/hci_sync.c
+++ y/net/bluetooth/hci_sync.c
@@ -6553,12 +6553,14 @@ static int __hci_acl_create_connection_s
 	if (err == -ETIMEDOUT)
 		hci_abort_conn_sync(hdev, conn, HCI_ERROR_LOCAL_HOST_TERM);
 
+	hci_conn_put(conn);
 	return err;
 }
 
 int hci_acl_create_connection_sync(struct hci_dev *hdev,
 				   struct hci_conn *conn)
 {
+	hci_conn_get(conn);
 	return hci_cmd_sync_queue(hdev, __hci_acl_create_connection_sync,
 				  conn, NULL);
 }
--