Received-SPF: pass (google.com: domain of linux-kernel+bounces-59077-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <77e7ed84395c716e17d783e9411fd57ad8c22295.camel@gmail.com>
Subject: Re: [PATCH] iio: core: make iio_bus_type const
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: "Ricardo B. Marliere" <ricardo@marliere.net>, Jonathan Cameron
	 <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Fri, 09 Feb 2024 08:38:03 +0100
In-Reply-To: <20240208-bus_cleanup-iio-v1-1-4a167c3b5fb3@marliere.net>
References: <20240208-bus_cleanup-iio-v1-1-4a167c3b5fb3@marliere.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-02-08 at 16:37 -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the iio_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>=20
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---

Acked-by: Nuno Sa <nuno.sa@analog.com>

> =C2=A0drivers/iio/industrialio-core.c | 2 +-
> =C2=A0include/linux/iio/iio.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 | 2 +-
> =C2=A02 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-c=
ore.c
> index e8551a1636ba..9b2877fe8689 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -42,7 +42,7 @@ static DEFINE_IDA(iio_ida);
> =C2=A0static dev_t iio_devt;
> =C2=A0
> =C2=A0#define IIO_DEV_MAX 256
> -struct bus_type iio_bus_type =3D {
> +const struct bus_type iio_bus_type =3D {
> =C2=A0	.name =3D "iio",
> =C2=A0};
> =C2=A0EXPORT_SYMBOL(iio_bus_type);
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index 4f89279e531c..e370a7bb3300 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -669,7 +669,7 @@ DEFINE_GUARD_COND(iio_claim_direct, _try, ({
> =C2=A0int iio_device_claim_buffer_mode(struct iio_dev *indio_dev);
> =C2=A0void iio_device_release_buffer_mode(struct iio_dev *indio_dev);
> =C2=A0
> -extern struct bus_type iio_bus_type;
> +extern const struct bus_type iio_bus_type;
> =C2=A0
> =C2=A0/**
> =C2=A0 * iio_device_put() - reference counted deallocation of struct devi=
ce
>=20
> ---
> base-commit: 81e8e40ea16329914f78ca1f454d04f570540ca8
> change-id: 20240208-bus_cleanup-iio-1e5714e23bb9
>=20
> Best regards,