Received-SPF: pass (google.com: domain of linux-kernel+bounces-59091-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 9 Feb 2024 07:54:49 +0000
From: Lee Jones <lee@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] mfd: tmio: remove obsolete io accessors
Message-ID: <20240209075449.GD689448@google.com>
References: <20240209015817.14627-8-wsa+renesas@sang-engineering.com>
 <20240209015817.14627-10-wsa+renesas@sang-engineering.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240209015817.14627-10-wsa+renesas@sang-engineering.com>

On Fri, 09 Feb 2024, Wolfram Sang wrote:

> Since commit 568494db6809 ("mtd: remove tmio_nand driver") and commit
> aceae7848624 ("fbdev: remove tmiofb driver"), these accessors have no
> users anymore. Remove them.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  include/linux/mfd/tmio.h | 25 -------------------------
>  1 file changed, 25 deletions(-)

Acked-by: Lee Jones <lee@kernel.org>

> diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
> index bc53323293a3..4223315d2b2a 100644
> --- a/include/linux/mfd/tmio.h
> +++ b/include/linux/mfd/tmio.h
> @@ -10,31 +10,6 @@
>  #include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
>  
> -#define tmio_ioread8(addr) readb(addr)
> -#define tmio_ioread16(addr) readw(addr)
> -#define tmio_ioread16_rep(r, b, l) readsw(r, b, l)
> -#define tmio_ioread32(addr) \
> -	(((u32)readw((addr))) | (((u32)readw((addr) + 2)) << 16))
> -
> -#define tmio_iowrite8(val, addr) writeb((val), (addr))
> -#define tmio_iowrite16(val, addr) writew((val), (addr))
> -#define tmio_iowrite16_rep(r, b, l) writesw(r, b, l)
> -#define tmio_iowrite32(val, addr) \
> -	do { \
> -		writew((val),       (addr)); \
> -		writew((val) >> 16, (addr) + 2); \
> -	} while (0)
> -
> -#define sd_config_write8(base, shift, reg, val) \
> -	tmio_iowrite8((val), (base) + ((reg) << (shift)))
> -#define sd_config_write16(base, shift, reg, val) \
> -	tmio_iowrite16((val), (base) + ((reg) << (shift)))
> -#define sd_config_write32(base, shift, reg, val) \
> -	do { \
> -		tmio_iowrite16((val), (base) + ((reg) << (shift)));   \
> -		tmio_iowrite16((val) >> 16, (base) + ((reg + 2) << (shift))); \
> -	} while (0)
> -
>  /* tmio MMC platform flags */
>  /*
>   * Some controllers can support a 2-byte block size when the bus width
> -- 
> 2.43.0
> 

-- 
Lee Jones [李琼斯]