Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp780600rdb; Fri, 9 Feb 2024 00:21:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+sT/W5rYZUZ9/9kJ8wXEFaMYC/vWrvwopcP8OkbMneVFONuSx61T5cL/yQJkvSEVpkXNk X-Received: by 2002:a17:903:41c1:b0:1d9:727d:e84f with SMTP id u1-20020a17090341c100b001d9727de84fmr790823ple.47.1707466870540; Fri, 09 Feb 2024 00:21:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707466870; cv=pass; d=google.com; s=arc-20160816; b=rpMBUdSCqPmxqnW4x/CgP2+NZgLw7sXQU+++vQ17bXecFfSpC5H8Ccr+dzRb4cWAtq ly99WPWvVvPZOj4krSTKadQPhM9yRs9yPjIjU/+3vjKP0NuoXoPKnFW5w6Me8Z7mkvyt SoX83HqbcichIjniOQx0i+9xWGr13iqibymU6wHT0pszagjxVQp9kd4MkE2XdEoRzP9q qlLEWM4aPlLcTi4jiKGmvDTRXSHmsB3bY5J09VhIzgvUal+oZuhcoNetPK4bCUuF3/T7 pNTPFmb3mn/qvmxJIKVL8Hm9Z/qG38J/RHqQvakmmlQ2PgfuNZXOJAiOAPwhg4agmDdd qczg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-id:precedence:message-id:date :subject:cc:to:from:dkim-signature; bh=lOGM2ox03bKKsQ2BwwS9WHFj8/IxNhRH949PvmjrUH8=; fh=YgNDrFAkLD0lzWgBKJNUJPdwFAtDlU5VxrYWbM0eLZ4=; b=cOoHGCnkmcIdqJM2WmePwP1nrc57xnNQyhRgJPd3tOXzR6LAgCXI7JcGfs9rbujNFY WwYp8HI7mDEONwbORemNR8dIpKVycHCCxjfnWG3UONfQX3mMZHR8sLOrJHEuOnd1ubue 79mlVhfNnIvDH92VxFUFiejLJ8vAaIa86FXlYnGCmWAIKgI/ALHC3lWExScD9SqvAgLm jazo/l34GlHiRI6/9fb12/0tiwqkwWSfEh2TW1PYCtcpCU4MiJX9pGPUjOL8d0jNuBfW cT5hNvdczvPQtURdZkIY/7j4BgB3E126AwkAur26QV7GoeUyG8ABFLYtZH/1vgjOK/OQ m0Vg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=mDjd1MW2; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-59108-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59108-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com X-Forwarded-Encrypted: i=2; AJvYcCV6Z4LwtYw+2mRiM94bxgBFJPEPAc6J54+P60E7gjszhaLIcv9EyV3bhFFnvHdgpapmPmxOxZhCJvKDypjE7vFqt0wfnk0eT2ZQi9rTjg== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id v10-20020a170902b7ca00b001d52198a844si1213724plz.614.2024.02.09.00.21.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 00:21:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-59108-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=mDjd1MW2; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-59108-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59108-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E429D283574 for ; Fri, 9 Feb 2024 08:21:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9942065BCB; Fri, 9 Feb 2024 08:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mDjd1MW2" Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4278A804; Fri, 9 Feb 2024 08:20:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707466854; cv=none; b=HIsWp9nU7Ksmbd+VPstjMeWi05+8bmHjq4wgFX2+hPOK7I+g2K8TUtm9MMwmeQiBGCxyvHzYbtxw4nsZIOd3D5NNvGAbZPeIbdxx6z7vsRiHAUdyaKVBU8GOl+jH/oKHWShfDdg9OIhAcCj4WVhIESG7dYmFLTg1wuUWbkF4TL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707466854; c=relaxed/simple; bh=UGZeq7C8AXSDp6QEFpOyY2J9Cw2Ay2NUaHO+BuuL4sA=; h=From:To:Cc:Subject:Date:Message-Id; b=gCC7xL+Vx5NjmqZaQoeys3AYUF5hvEKMaWBD/TLb2I1N8q+JhaY6RQpiMWhm/u9TNxCZiscKaaF14kpwmgYKZWQgXyCnZ08opszUHSw7rkBvF+ehqEdBz95nXK/SpdNrCs5npTesURbM2lyW0XEooGCxoUT0J3NMLOICNzxIusU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mDjd1MW2; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a3122b70439so75757066b.3; Fri, 09 Feb 2024 00:20:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707466851; x=1708071651; darn=vger.kernel.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lOGM2ox03bKKsQ2BwwS9WHFj8/IxNhRH949PvmjrUH8=; b=mDjd1MW24uQIwcN2HLfYaWOudyUdsuxVwqt704/IG+J4aFUDHAU63HornqI4cuQVMP bNlvH3r/Vm/zve/BauLl1t4EVrB3Gc1Nz3VEZJNHszvx5oxXBHBa+SNiOeC0cRA1++ss Haxkc5JkmRVkHplZmzgWlbvNCM/+KFeYROadZ5C2/X83k0WVpCzsci+VkE2TzhZjvVpS IA5xAoDYFBXVwdoYhcfE0AOwcvWwlS5l4AOnFBllT8tnIl52NaPwe6ZRECnRe9Q0CWuh 867VnksYs61btWvibxqWNG7DvtJ5z0jgTJDEnsDSsqHDCfprAnn8j1AvP70CkZfMU7dP EtvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707466851; x=1708071651; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lOGM2ox03bKKsQ2BwwS9WHFj8/IxNhRH949PvmjrUH8=; b=TCAydemKfhbyVumhqr+Ws+JOaQLFsuiDIKwqUBQnGwWY5rbjvYFQwr1YkyIvgdDKvY Z4W0mlmdZyx2g6coqApH0LRA+31NcScyohgxFGZgKDgZ0L2RZ1QyjYWAcbi20o5/++XE 4tIhz61fzZHYNN0imBzgllMSworA6OBDZp0PxtWsLxurkfFJQkSRWVptu2tXftulcIcS ULNb6z8RV8cxsO0v1FcZNGa/E8MqtFDrCZTLCP5zvyg1vZS5BBUYrLyOIF//iJljnE8R C3Wz1Yj5qQv18K7bnISMAMTaT2p8F7wTbGhb+VMD8pp1qME7lzNosNCXht86baLnRe4q HYDg== X-Gm-Message-State: AOJu0YxN0bKrjmxKirgG/yU+TsB7NlhglkhoNC0I8nO/nLnxYN7NM2n3 AfOOFWMN8SzOO0bUdqB/l9IA53P6iwlQZzOE9O8YIvUwUXwMNZlZ X-Received: by 2002:a17:906:874c:b0:a37:7f72:574c with SMTP id hj12-20020a170906874c00b00a377f72574cmr472254ejb.68.1707466851266; Fri, 09 Feb 2024 00:20:51 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV4eR9GD9M+KuD19uCHflWV+fAiD7/NLXBZ6dyFie4GJz0WB43lazdCx6+rHPp8TGoZqYqS+SNsljDAmJSpdt2yAi43PwktlTQ+ReVwBkw5DUJcTksGPvCkflJfYXWNjgonU1N0PL0RJ8VsiyfktUGD2aUViKMNUV02kWn4IrspDlWAGEHXa5iYOUUgqEGPqVEWaHi5tBBbLp48HVrWmbwa53XpPaE209R6IIQZcq1lkXquQKfc31cl6FsSmyfQvRqFlJHZVjw5AZMI Received: from felia.fritz.box ([2a02:810d:7e40:14b0:cc99:64b5:3ac3:6096]) by smtp.gmail.com with ESMTPSA id t10-20020a170906a10a00b00a3bd7052c22sm518897ejy.60.2024.02.09.00.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 00:20:50 -0800 (PST) From: Lukas Bulwahn To: Jaroslav Kysela , Takashi Iwai , Richard Fitzgerald , Simon Trimmer , linux-sound@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: [PATCH] ALSA: hda/cs35l56: select intended config FW_CS_DSP Date: Fri, 9 Feb 2024 09:20:44 +0100 Message-Id: <20240209082044.3981-1-lukas.bulwahn@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Commit 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier") adds configs SND_HDA_SCODEC_CS35L56_{I2C,SPI}, which selects the non-existing config CS_DSP. Note the renaming in commit d7cfdf17cb9d ("firmware: cs_dsp: Rename KConfig symbol CS_DSP -> FW_CS_DSP"), though. Select the intended config FW_CS_DSP. This broken select command probably was not noticed as the configs also select SND_HDA_CS_DSP_CONTROLS and this then selects FW_CS_DSP. So, the select FW_CS_DSP could actually be dropped, but we will keep this redundancy in place as the author originally also intended to have this redundancy of selects in place. Signed-off-by: Lukas Bulwahn --- sound/pci/hda/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig index 20d757e38f94..26da739eea82 100644 --- a/sound/pci/hda/Kconfig +++ b/sound/pci/hda/Kconfig @@ -159,7 +159,7 @@ config SND_HDA_SCODEC_CS35L56_I2C depends on I2C depends on ACPI || COMPILE_TEST depends on SND_SOC - select CS_DSP + select FW_CS_DSP select SND_HDA_GENERIC select SND_SOC_CS35L56_SHARED select SND_HDA_SCODEC_CS35L56 @@ -174,7 +174,7 @@ config SND_HDA_SCODEC_CS35L56_SPI depends on SPI_MASTER depends on ACPI || COMPILE_TEST depends on SND_SOC - select CS_DSP + select FW_CS_DSP select SND_HDA_GENERIC select SND_SOC_CS35L56_SHARED select SND_HDA_SCODEC_CS35L56 -- 2.17.1