Received-SPF: pass (google.com: domain of linux-kernel+bounces-59155-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <66e0b76e-c1aa-4e65-9372-07a1fccaeb6b@oracle.com>
Date: Fri, 9 Feb 2024 09:22:20 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/6] block atomic writes for XFS
Content-Language: en-US
To: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: hch@lst.de, djwong@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org,
        dchinner@redhat.com, jack@suse.cz, chandan.babu@oracle.com,
        martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com
References: <20240124142645.9334-1-john.g.garry@oracle.com>
 <ZcXQ879zXGFOfDaL@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <ZcXQ879zXGFOfDaL@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?TEZUd2Q3NHlJanBtaG9kd201OUxhMEo1Qmo4eXNqQVJiUnBxR0JKVUlkTzNH?=
 =?utf-8?B?TUdIeEFzOGpyYlhsT3ltVTJEeHduYkdpbEN6am9NQlN4TjlzcUtuNklmNldF?=
 =?utf-8?B?cnhFL0lOZzk1dTgwb0ZUTDVyZ2tldmhhZG0ybXBFQlkrQVo5RE1RWGFxa0pM?=
 =?utf-8?B?R3kzS0Z6UUZJYUNJdy9lT3NpU3VkUmNGVVE4S3RzY09BZzNFSjZJMlZDc1l4?=
 =?utf-8?B?T3drcGNrWEJia21BYUozY2pYVE85S1EwRWlIY0d1OE1rOEZXRW11THpvU1RG?=
 =?utf-8?B?SHdEbldWcFkyZkpRcGcraFhBLzVSTWsxUDBUQ2RnNnlMMUhvUzJ3eSt2NGhD?=
 =?utf-8?B?M0Q4OFN4bXAvU0gzbnZSK0RzWTJITEZjc0k1b1B3dldCQjBSK0ZabHpmaVBm?=
 =?utf-8?B?OHJJSUIyMDJEOUNzTFlPL3N0dW9Pa2VhZGw4dlQ2Ui9ubWU5dXhSaUo4eDRG?=
 =?utf-8?B?a0lJTVU3Z0Z1Mzk0UmVKQy8ycmN2YXdiRkZLTG4rOEJpOUFwV2p2NDBTYjla?=
 =?utf-8?B?WTRiaHpuWDJnbHFoSktJUWZ6SGdrQWFic3BFYVpLa29OSHUyUEJIL0pLQ2FC?=
 =?utf-8?B?WTQyM3NCc3hNSXZnYXdxWDZSckYrR0hiNnJuUUxkTXVvaGNBS2ZiR280emVu?=
 =?utf-8?B?N0xIbWFRYVFZSDdZTjRnOHNDRnpsejgwOHZOdmhxMEMraCt4ekl4V0xKVzNG?=
 =?utf-8?B?WXAxQldXekd2Y0E0b2lGa0k5VU84RFN0WFc0d2Iwa09Jczg2em1QdDMxcDNJ?=
 =?utf-8?B?RlFPQUx6b0dhNWU5dlV0Zis2MXNMUmFVcjh0RWFvM2ZRWnpVQmE2cDVGM1Ar?=
 =?utf-8?B?QmVqOXFZa1VDd0NFc0ZLenhBMldIU3RQUlJ6VUxKZ1pCdzc5aXFGc2pHOWVk?=
 =?utf-8?B?RVE5ZXQvK3ZEVFdjYkF1bTIwWGhjM1R3VzVaSE42SUxmL1F3a0kxYnlUVWdL?=
 =?utf-8?B?SllzaDkxT2o0YVFNNXVndWp4SlF0N3IwZ1QvSHpEeEtmQTBoVXVmeEVJN0cw?=
 =?utf-8?B?cnFGUFFZZG1uZjU1d29sWFlwbkU3QzZZS01zUVE4djh6L2RGQmY4dTFLUG1W?=
 =?utf-8?B?QzlCR3pmNVBMeDQ4QkRUUFJaVHpYZUFrRmc2cWRpT1J5WERDU20rU1FZYlNy?=
 =?utf-8?B?Y0hzWE95T1BsVk9yYWRHSG1wMmt5S0dRU2NaMHJMVldIVDAvZXJoUTRWMXd2?=
 =?utf-8?B?Z05RSm13ajREY3AyYVJkYzJVeWpoaGlNL0Q3SmV1LzdqcTU4OHNpUnJZaVdl?=
 =?utf-8?B?K3k1U0FCUnZMWE9TOVJ6elF6Sm5uWnpEd3lOUFM0bFZtbXBvWmhFbjhOM01X?=
 =?utf-8?B?Sk11cllKcEVuWkRqajRlZ1loYkE5QitSSCtlaFF4NkhPbG9teGZlUDhwaHlU?=
 =?utf-8?B?SnNrZGN6aVhqakdFSGRSZDA4M1A3WDhuVXI3TzFOWnpBNjJKYWlnbHUvNzVj?=
 =?utf-8?B?d1pISjQ3aldrNGNvTDNraWMrU3VtSDI1OXdDQXJNS0FqcklkT0lDNnp1ZHNR?=
 =?utf-8?B?MTQ5TVlDUzQvYlFiNm5keFIzZU5PcXV6RUtUOCt0REl5NFpHckkyVHA3cVlJ?=
 =?utf-8?B?Z1pkdUVUZWxrSmRQaXFPUGtyMmZFci9UV01MdHE2N2lFQklYK0FtNmJGazZV?=
 =?utf-8?B?aDZ2eHZRbm1WNTB0U0F4WVdNdklpS1I0dU1HWTVQVkJnNENoVzJGbjlSd2hp?=
 =?utf-8?B?OGtSUUVXU2dIdjE5akFtTWZPaWhVTWk1U1NyWXB3NGxmd2YzOThVaUluOVp1?=
 =?utf-8?B?OGg4ZXN2WmJBZUl1WHZ4TXR6ZjlCa2Q2Q1ozREFpaldBanZYRVV5bXhLdTNL?=
 =?utf-8?B?TDNyMTJzYS9KdDJRV054ZUViMEpTUURsbFlYNGJ2SWRVZnpCSVVxL0xTTWtL?=
 =?utf-8?B?N1BSRGkrMEhEeVdaOU5uSmhRcFUvbUt0WVJGLzIxM25MQUVVaDhMZUxURnlR?=
 =?utf-8?B?VHpMQi9vN2FJL1hYOVFCUC9kcVo0bnprZHhBWW1PQngvUzYxaFlvMWRMalhn?=
 =?utf-8?B?aU14YUlCYldyTmtBNExKbmxnb1RQNU9oSXlvRHk1VkZRRDdHblpqem5IamZJ?=
 =?utf-8?B?akN3VWswQ2RZL1JVSnNqbngremdqNWpHM3RPdWFpZmdzeUxsc0J5aFZiSis4?=
 =?utf-8?B?VDNOcVlraG5aanRNZG9aY2RXRUpUaDFqZlNJd1NZV21jY0poQWhaWmJFTWc0?=
 =?utf-8?B?NGc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	iFqKX/4DIkO3rkIL1pMcnOaBlt8mWblYEcZE3ldYFwpILnhH7txEYr+76F/YjKY5IeLHWScYfjX6f3EIqLbrpa5H7OwxSqQj4b9i9QuPUyzJlYujwipvm76ght0sM85LEibt+0MrKjMWkSrQlZzP5vmbUT4/B5HbDa4baTLzAQqtuGsZuDoMx7SLAX/zlGC8sR04kMKaLrEmQn2H+TPMKWXLAf6NtDQarDBQJHNQr1svXukMFgWnkSgZqknNv6XHNIFxo+4D7GG0cbUN3o2yEImV+WzuVdYKdN5S93Fhh4hKPCyfbNtoqXY1moZQPhn4zgLvolesjVQxZb/QVWkbkvksFoa7SNA2aYGuPFjRomh1ajbNec7p8LclyBbWj+uIQkkTpRZEeCWuqqMIcxDLuPT0gGc3WLp2rH/ndYw8z0gj1bqEBQsrUYJGGniUIW5Y/mbugr02xPvRfrzr2jI/NkMOLL/4HyAbXI64IbJz3JgppQJnqSvKr3eytNFiLy0LszxGUbbHB13utKsxknQQtPXNLwKdnmva06qqt/QNiLvGZVJu11eU5SjAwkH7YdpKpEm8RK0rIfbzAhxT0Dr9mqOcN/wbfMS4le2y1m8J9kQ=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa5fc83d-3288-4474-55bd-08dc2950a059
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 09:22:24.6399
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q4Y9Y+fHC16BJGeEjZdj2IAhM0yUBsIaNXAzRA4wALYYI/J657q+rJbYFi3LNDTdzBWytKoKqNzGVSZqvoDrQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5926
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-09_06,2024-02-08_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 phishscore=0
 spamscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402090066
X-Proofpoint-GUID: KPVbK_al2N2QWZSl1FthBpqJDA0RYRBe
X-Proofpoint-ORIG-GUID: KPVbK_al2N2QWZSl1FthBpqJDA0RYRBe

On 09/02/2024 07:14, Ojaswin Mujoo wrote:
> On Wed, Jan 24, 2024 at 02:26:39PM +0000, John Garry wrote:
>> This series expands atomic write support to filesystems, specifically
>> XFS. Since XFS rtvol supports extent alignment already, support will
>> initially be added there. When XFS forcealign feature is merged, then we
>> can similarly support atomic writes for a non-rtvol filesystem.
> 
> Hi John,
> 
> Along with rtvol check, we can also have a simple check to see if the
> FS blocksize itself is big enough to satisfy the atomic requirements.
> For eg on machines with 64K page, we can have say 16k or 64k block sizes
> which should be able to provide required allocation behavior for atomic
> writes. In such cases we don't need rtvol.
>
I suppose we could do, but I would rather just concentrate on rtvol 
support initially, and there we do report atomic write unit min = FS 
block size (even if rt extsize is unset).

In addition, I plan to initially just support atomic write unit min = FS 
block size (for both rtvol and !rtvol).

Thanks,
John