Received-SPF: pass (google.com: domain of linux-kernel+bounces-59208-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-144-ge5821d614e-fm-20240125.002-ge5821d61
Precedence: bulk
MIME-Version: 1.0
Message-Id: <87302cfa-c3ec-4d60-b870-a86acf0f6f8b@app.fastmail.com>
In-Reply-To: <e9a72160-2d39-4090-8822-ca68477f429f@leemhuis.info>
References: <20240122153442.7250-1-arnd@kernel.org>
 <170594251756.17335.7078970144473561827.b4-ty@linaro.org>
 <e9a72160-2d39-4090-8822-ca68477f429f@leemhuis.info>
Date: Fri, 09 Feb 2024 11:20:21 +0100
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Linux regressions mailing list" <regressions@lists.linux.dev>,
 "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
 "Miquel Raynal" <miquel.raynal@bootlin.com>,
 "Arnd Bergmann" <arnd@kernel.org>
Cc: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <rafal@milecki.pl>,
 "Chen-Yu Tsai" <wenst@chromium.org>,
 "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, asahi@lists.linux.dev,
 "Sven Peter" <sven@svenpeter.dev>, "Michael Walle" <michael@walle.cc>,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmem: include bit index in cell sysfs file name
Content-Type: text/plain

On Fri, Feb 9, 2024, at 10:09, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 22.01.24 17:55, Srinivas Kandagatla wrote:
>> On Mon, 22 Jan 2024 16:34:10 +0100, Arnd Bergmann wrote:
>>> Creating sysfs files for all Cells caused a boot failure for linux-6.8-rc1 on
>>> Apple M1, which (in downstream dts files) has multiple nvmem cells that use the
>>> same byte address. This causes the device probe to fail with
>>>
>>> [    0.605336] sysfs: cannot create duplicate filename '/devices/platform/soc@200000000/2922bc000.efuse/apple_efuses_nvmem0/cells/efuse@a10'
>>> [    0.605347] CPU: 7 PID: 1 Comm: swapper/0 Tainted: G S                 6.8.0-rc1-arnd-5+ #133
>>> [    0.605355] Hardware name: Apple Mac Studio (M1 Ultra, 2022) (DT)
>>> [    0.605362] Call trace:
>>> [...]
>> 
>> Applied, thanks!
>> 
>> [1/1] nvmem: include bit index in cell sysfs file name
>>       commit: b40fed13870045731e374e6bb48800cde0feb4e2
>
> The problem description from Arnd to an outsider like me sounded like
> this is something that should be fixed rather sooner than later in
> mainline. Am I wrong with that? If not: will this be heading to Linus
> soon? Just wondering, as the fix seems to be a in "for-next" branch[1]
> of the nvmem repo and not in a "fixes" branch.

Yes, this that this needs to be fixed before v6.8 is
out. I assumed it had gone upstream already.

If anyone is still unsure about the ABI, we could also revert
the original commit 0088cbc19276 ("nvmem: core: Expose cells
through sysfs") for v6.8 and try again for v6.9 with the
fixed ABI, but I think we already had an agreement on the
changes that I sent.

     Arnd