Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp828468rdb; Fri, 9 Feb 2024 02:21:18 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXB2OBeNoYeju0XD5gvvBhmb1XPw+V3B36G9em3IGy3jeOHczdBoDWEsCvryFy6CQ07UZkU6oyBjGnKmgmkqlx9P8TZ18Pky3gnboXHng== X-Google-Smtp-Source: AGHT+IHKi+Nn5hICaSHgub9SUb208lOa8YwzNA08CNrMdc2uAaMhLdfV5KT5n0qmblDsPH4lHo4k X-Received: by 2002:a05:6a00:2d02:b0:6e0:329b:3335 with SMTP id fa2-20020a056a002d0200b006e0329b3335mr1001000pfb.8.1707474078106; Fri, 09 Feb 2024 02:21:18 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707474078; cv=pass; d=google.com; s=arc-20160816; b=omXlaJjc9MUOAyt8HT6lLDvX0oaKvtvMoUnx+QfyZSMfeoc6fl9QvBK6UYeYM4pe9v Yg/cUnw/ZQS9gtRmv/y7Kz3aYX3Z9MCHt2cRP5WlO8TvaaJoIgYVANsbDSAH+xxdnLOR kf863v71unDIE/maqDrQN/7jazu3nvhydLkbGiXbNCzPOR1IjQbf4uLLo4CpdSyVEOdw 7ixTfnJugMVZltrRO30M/GMgQguNhaftdAJ5QQoOEi8ju11lpyWMNpgAAOVa+E5PGe/D PF93LmK3Xnay2GW9HWwP9aeNjOA/JL8Jwy0JA+MpfzLYQYN+GioW1Me7i31geYFl0l3T db1Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature :dkim-signature:dkim-signature:dkim-signature; bh=mgMlkkPibxaPZ13lVHWwY0Y/CuH9ry83iFmx8OiVLbI=; fh=Qo0eKIoY5oE5P5jBfCyjHMcKhXTR1TGC3HDoa/MAjWU=; b=pO/Swghy/6TRJ2b/gem9y652kUTAH77Q8WcO7TkNWpMptB4SpFAd1Geg+FbdbT4fSs DlzaF2lOF/MVC0jyY0ckrknJSx9yeSbHnrlz8KRs8QARiQgkcoaqD902qJ+vAXGwGP0H G512lge+UOF1B65KbfcUss0XkRWeRW3HjKyXkCyushu59rqctRN0BHu01qhFiXh2a/vf WypwFn3WV8vKOANwMg3Z28BMCTnGMqZMW8UODoA9wyiQG0MW8aZ6y6vkmRiIWkHXSKui vtYkQkCBkfqr67AYTlno76HEa9SQlFhNt9K/lWVw/xKy3mlxPeER0n/VzH1NCyY5k4C0 bMwQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=pLJClPrp; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=pLJClPrp; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=MHPAbcgY; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-59205-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59205-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de X-Forwarded-Encrypted: i=2; AJvYcCUGdV5F1mr9PTuxTz3p0559d9hDuy8iGKKXG7tFGpR8yEnYXqIsCKXvGjoRrXD78bdLG73m6TDSTt5vMVp3h4F5n+J7LhUmkMt0BwSD6g== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id k192-20020a633dc9000000b005ceb4a7020esi1467642pga.393.2024.02.09.02.21.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 02:21:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-59205-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=pLJClPrp; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=pLJClPrp; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=MHPAbcgY; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-59205-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59205-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 95285285A39 for ; Fri, 9 Feb 2024 10:19:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F397E69947; Fri, 9 Feb 2024 10:19:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="pLJClPrp"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="MHPAbcgY"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="pLJClPrp"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="MHPAbcgY" Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D03A67E6E; Fri, 9 Feb 2024 10:19:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707473956; cv=none; b=LDhcWE8ubMEj4cg0Z/3lRYhGbKAn/Sl8lgDkwoqhmnsRYSvFr2YKPvLyBZO8yBXlY3ROpDNJu97fj7sZU6xibHLXH1FM66Eii822enBJGsDGQ15s32jzD+i8Ws1PvrwpFczwRl9PL5gToz5wM3VbaiXgdnYN6O7KeZ4r+7XGShc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707473956; c=relaxed/simple; bh=xJCBHJeU9/djlGFXXT3GUZt8nlqpjwZiLm+sMcIoOFM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DatfrgTr3S5dWEdyFOGYqQlq2jslG2iyjkizvbgFx+68rV4Oz7yTMl/mQkzgop1+KPHk8Vb6bYFwY0S7vFbVcfR4z9VmtWhH0v58XblX/kdLSTz+CzjLaiM+KDyKG3DWnr3J6WyH6wuyJVKSRIdcKsiA5KCVIcXJmmF7cN89fFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=pLJClPrp; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=MHPAbcgY; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=pLJClPrp; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=MHPAbcgY; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7179B1F7F9; Fri, 9 Feb 2024 10:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707473952; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mgMlkkPibxaPZ13lVHWwY0Y/CuH9ry83iFmx8OiVLbI=; b=pLJClPrp4w7cN0ueSQ00PHBW1vOi9ufRd4VAxU9oaKeNW/DiYQ1/MiA55/34tKa6lpZDM3 UQC1fpVx6w8S3M+T1Udo7UNvZHL2uY+2ofhYOn+TkRmV8SXrXp0zW0UOFLO9oZlHoV7DML wCLBRHPQinFKmGhPTTKcrJFYJfIdBwg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707473952; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mgMlkkPibxaPZ13lVHWwY0Y/CuH9ry83iFmx8OiVLbI=; b=MHPAbcgYa6+sCc1gmhtWpBKTfk42/AafAKvUjIfZdMJimDuJoB2E0dBR2RStyaU1Gi6JUc tEvsWt6PnMS8+dCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707473952; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mgMlkkPibxaPZ13lVHWwY0Y/CuH9ry83iFmx8OiVLbI=; b=pLJClPrp4w7cN0ueSQ00PHBW1vOi9ufRd4VAxU9oaKeNW/DiYQ1/MiA55/34tKa6lpZDM3 UQC1fpVx6w8S3M+T1Udo7UNvZHL2uY+2ofhYOn+TkRmV8SXrXp0zW0UOFLO9oZlHoV7DML wCLBRHPQinFKmGhPTTKcrJFYJfIdBwg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707473952; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mgMlkkPibxaPZ13lVHWwY0Y/CuH9ry83iFmx8OiVLbI=; b=MHPAbcgYa6+sCc1gmhtWpBKTfk42/AafAKvUjIfZdMJimDuJoB2E0dBR2RStyaU1Gi6JUc tEvsWt6PnMS8+dCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 20D681326D; Fri, 9 Feb 2024 10:19:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id /5xPBiD8xWXjIQAAD6G6ig (envelope-from ); Fri, 09 Feb 2024 10:19:12 +0000 Message-ID: <9292aeda-b529-46cc-81e4-42b4f3051fca@suse.de> Date: Fri, 9 Feb 2024 11:19:11 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock" To: Lee Duncan , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Chengfeng Ye , Satish Kharat , Sesidhar Baddela , Karan Tilak Kumar , Lee Duncan References: Content-Language: en-US From: Hannes Reinecke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -1.30 X-Spamd-Result: default: False [-1.30 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; BAYES_HAM(-0.01)[49.08%]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_SEVEN(0.00)[8]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:email,suse.de:email]; FREEMAIL_TO(0.00)[gmail.com,vger.kernel.org]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[gmail.com,cisco.com,suse.com]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Flag: NO On 2/7/24 23:20, Lee Duncan wrote: > From: Lee Duncan > > This reverts commit 1a1975551943f681772720f639ff42fbaa746212 > > This commit causes interrupts to be lost for FCoE devices, > since it changed sping locks from "bh" to "irqsave". > > Instead, a work queue should be used, and will be addressed > in a separate patch. > > Fixes: 1a1975551943f681772720f639ff42fbaa746212 Please use the correct fixes tag: Fixes: 1a1975551943 ("scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock") Otherwise looks good. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald, Werner Knoblich