Received-SPF: pass (google.com: domain of linux-kernel+bounces-59206-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <a602e869-1fb9-40e4-8aba-728d13c22dcb@suse.de>
Date: Fri, 9 Feb 2024 11:19:48 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 2/2] fnic: move fnic_fnic_flush_tx() to a work queue
Content-Language: en-US
To: Lee Duncan <leeman.duncan@gmail.com>, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: Chengfeng Ye <dg573847474@gmail.com>, Satish Kharat <satishkh@cisco.com>,
 Sesidhar Baddela <sebaddel@cisco.com>, Karan Tilak Kumar
 <kartilak@cisco.com>, Lee Duncan <lduncan@suse.com>
References: <cover.1707343839.git.lduncan@suse.com>
 <ce5ffa5d0ff82c2b2e283b3b4bff23291d49b05c.1707343839.git.lduncan@suse.com>
From: Hannes Reinecke <hare@suse.de>
In-Reply-To: <ce5ffa5d0ff82c2b2e283b3b4bff23291d49b05c.1707343839.git.lduncan@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2/7/24 23:20, Lee Duncan wrote:
> From: Lee Duncan <lduncan@suse.com>
> 
> Rather than call 'fnic_flush_tx()' from interrupt context we should
> be moving it onto a work queue to avoid any locking issues.
> 
> Fixes: 1a1975551943f681772720f639ff42fbaa746212

Same here, please use the correct fixes tag.

> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Lee Duncan <lduncan@suse.com>
> ---
>   drivers/scsi/fnic/fnic.h      | 3 ++-
>   drivers/scsi/fnic/fnic_fcs.c  | 5 +++--
>   drivers/scsi/fnic/fnic_main.c | 1 +
>   drivers/scsi/fnic/fnic_scsi.c | 4 ++--
>   4 files changed, 8 insertions(+), 5 deletions(-)
> 
Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich