Received-SPF: pass (google.com: domain of linux-kernel+bounces-59258-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 9 Feb 2024 10:59:47 +0000
From: Simon Horman <horms@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: Steve French <smfrench@gmail.com>, Jeff Layton <jlayton@kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	Paulo Alcantara <pc@manguebit.com>,
	Shyam Prasad N <sprasad@microsoft.com>, Tom Talpey <tom@talpey.com>,
	Christian Brauner <christian@brauner.io>, netfs@lists.linux.dev,
	linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Steve French <sfrench@samba.org>,
	Shyam Prasad N <nspmangalore@gmail.com>,
	Rohith Surabattula <rohiths.msft@gmail.com>
Subject: Re: [PATCH v5 09/12] cifs: Cut over to using netfslib
Message-ID: <20240209105947.GF1516992@kernel.org>
References: <20240205225726.3104808-1-dhowells@redhat.com>
 <20240205225726.3104808-10-dhowells@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240205225726.3104808-10-dhowells@redhat.com>

On Mon, Feb 05, 2024 at 10:57:21PM +0000, David Howells wrote:

..

> diff --git a/fs/smb/client/cifsfs.h b/fs/smb/client/cifsfs.h
> index e8e0f863e935..5cd547b7b5ea 100644
> --- a/fs/smb/client/cifsfs.h
> +++ b/fs/smb/client/cifsfs.h
> @@ -85,6 +85,7 @@ extern const struct inode_operations cifs_namespace_inode_operations;
>  
>  
>  /* Functions related to files and directories */
> +extern const struct netfs_request_ops cifs_req_ops;
>  extern const struct file_operations cifs_file_ops;
>  extern const struct file_operations cifs_file_direct_ops; /* if directio mnt */
>  extern const struct file_operations cifs_file_strict_ops; /* if strictio mnt */

Nit: this hunk would probably be better placed in the
     patch at adds cifs_req_ops to fs/smb/client/file.c

..