Received-SPF: pass (google.com: domain of linux-kernel+bounces-59272-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240208-alice-mm-v2-1-d821250204a6@google.com> <20240208225407.11951-1-kernel@valentinobst.de>
In-Reply-To: <20240208225407.11951-1-kernel@valentinobst.de>
From: Alice Ryhl <aliceryhl@google.com>
Date: Fri, 9 Feb 2024 12:15:48 +0100
Message-ID: <CAH5fLghObExCR55dEozb2MSsPZWd7432z5FyOYmNKHFKJHt8Lg@mail.gmail.com>
Subject: Re: [PATCH v2 1/4] rust: uaccess: add userspace pointers
To: Valentin Obst <kernel@valentinobst.de>
Cc: a.hindborg@samsung.com, akpm@linux-foundation.org, alex.gaynor@gmail.com, 
	arnd@arndb.de, arve@android.com, benno.lossin@proton.me, 
	bjorn3_gh@protonmail.com, boqun.feng@gmail.com, brauner@kernel.org, 
	cmllamas@google.com, gary@garyguo.net, gregkh@linuxfoundation.org, 
	joel@joelfernandes.org, keescook@chromium.org, linux-kernel@vger.kernel.org, 
	linux-mm@kvack.org, maco@android.com, ojeda@kernel.org, 
	rust-for-linux@vger.kernel.org, surenb@google.com, tkjos@android.com, 
	viro@zeniv.linux.org.uk, wedsonaf@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 8, 2024 at 11:54=E2=80=AFPM Valentin Obst <kernel@valentinobst.=
de> wrote:
>
> > +    /// Reads the entirety of the user slice, appending it to the end =
of the
> > +    /// provided buffer.
> > +    ///
> > +    /// Fails with `EFAULT` if the read encounters a page fault.
> > +    pub fn read_all(self, buf: &mut Vec<u8>) -> Result<()> {
> > +        self.reader().read_all(buf)
> > +    }
>
> I think there is also no need to give an explicit `()` for the
> generic type parameter here as it is the default (applies to some
> other methods in this patch as well).

I'll change this if I send a v3, but I don't think it's that important.

Alice