Received-SPF: pass (google.com: domain of linux-kernel+bounces-59275-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Simon Trimmer <simont@opensource.cirrus.com>
To: 'Lukas Bulwahn' <lukas.bulwahn@gmail.com>,
        'Jaroslav Kysela'
	<perex@perex.cz>, 'Takashi Iwai' <tiwai@suse.com>,
        'Richard Fitzgerald'
	<rf@opensource.cirrus.com>,
        <linux-sound@vger.kernel.org>
CC: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240209082044.3981-1-lukas.bulwahn@gmail.com>
In-Reply-To: <20240209082044.3981-1-lukas.bulwahn@gmail.com>
Subject: RE: [PATCH] ALSA: hda/cs35l56: select intended config FW_CS_DSP
Date: Fri, 9 Feb 2024 11:18:07 +0000
Message-ID: <001801da5b49$a89be460$f9d3ad20$@opensource.cirrus.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Language: en-gb
Thread-Index: AQIj8QOMXSB51XGLfZZGXWCY5rrZsLBusJ+A

> -----Original Message-----
> From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> 
> Commit 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic
> CS35L56 amplifier") adds configs SND_HDA_SCODEC_CS35L56_{I2C,SPI},
> which selects the non-existing config CS_DSP. Note the renaming in
> commit d7cfdf17cb9d ("firmware: cs_dsp: Rename KConfig symbol CS_DSP ->
> FW_CS_DSP"), though.
> 
> Select the intended config FW_CS_DSP.
> 
> This broken select command probably was not noticed as the configs also
> select SND_HDA_CS_DSP_CONTROLS and this then selects FW_CS_DSP. So,
> the
> select FW_CS_DSP could actually be dropped, but we will keep this
> redundancy in place as the author originally also intended to have this
> redundancy of selects in place.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Thanks!

Reviewed-by: Simon Trimmer <simont@opensource.cirrus.com>