Received-SPF: pass (google.com: domain of linux-kernel+bounces-59295-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 9 Feb 2024 12:29:50 +0100
From: Christian Brauner <brauner@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andy Lutomirski <luto@amacapital.net>, 
	"Eric W. Biederman" <ebiederm@xmission.com>, Tycho Andersen <tycho@tycho.pizza>, linux-api@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pidfd: change pidfd_send_signal() to respect PIDFD_THREAD
Message-ID: <20240209-festmachen-gekreische-7616d41f6e43@brauner>
References: <20240207114549.GA12697@redhat.com>
 <20240208-fragt-prospekt-7866333b15f0@brauner>
 <20240208135344.GD19801@redhat.com>
 <20240208143407.GF19801@redhat.com>
 <20240209102816.GA3282@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240209102816.GA3282@redhat.com>

On Fri, Feb 09, 2024 at 11:28:17AM +0100, Oleg Nesterov wrote:
> On 02/08, Oleg Nesterov wrote:
> >
> > Is prepare_kill_siginfo() correct when we send a signal to the child
> > pid namespace? si_pid = task_tgid_vnr(current) doesn't look right
> 
> Yes, but iiuc send_signal_locked() should fixup si_pid/si_uid, so it
> is not buggy.

It must've been. Yesterday I realized that otherwise kill(2) would have
been broken for a long time. I think this was originally fixed in commit
6588c1e3ff01 ("signals: SI_USER: Masquerade si_pid when crossing pid ns
boundary").