Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp918157rdb; Fri, 9 Feb 2024 05:19:32 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXqyJYuHFhnF3kecmvpF60JgBz4wqBbcMFw6PgfI+OpfvFhYku9rsld/4Fsf0MvUFgwARkLjIQg9u2pRh4yqNYp7vt2oNRYY40alL/l7Q== X-Google-Smtp-Source: AGHT+IHUKn2NV7uNV7T/+kqgQNsdbSwhwj/bBLGPhorvBUKKs0ZAEom7/ZKEPvB+bxOtYJeQQJwG X-Received: by 2002:a05:620a:5641:b0:785:9539:43c3 with SMTP id vw1-20020a05620a564100b00785953943c3mr1713153qkn.19.1707484772185; Fri, 09 Feb 2024 05:19:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707484772; cv=pass; d=google.com; s=arc-20160816; b=GQQog4n66o4HUXcInmCrgswaN3Wi4xLOylqN6x+jrieJPpcijRJeZLCst1UHYe+BoK MNN+QsOdBKpTzZeozcMGRGLbGuWVMU0eePlSTvT+B7afLjbxDQ4bHQ8eRCGNaMV7qx1Q esafRdifhG28YrWbNLobjdDuijTDL3OeVxzxWzMcu51bX9BAqI2P7QjiHHyUKm/PZYfo 5vtRUhh0c38LoBPEL0/5PSFoZi7Bzeh2sOonbnYvP6Yfdo3+W12vdqfguMM/Flwkb4Hq jTSdNbsG7mdxHfaaDSJUpYk1tatzyHeTIUhno9hCU0nPJvXzP8+BoOitzv2BRQuGMmKZ iPPQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=H0Ihgqg6vcooY6HsSUddyRQvt/glr76kGUtcEmebLvw=; fh=tEW45Bn6VL3EVoLZU2pYeXOtmGNJ7p/9FqLa6U61sRw=; b=y0L38+ZkNhkAlpYzupKl5x3PaTNY9XyDh2/IONdJ2WZKN5uybu0s00QQiXfMTA9B4R 1xUktQLP/YoGqR6Fr1jFPLKaBsfWQqFRnegtncgaESal1i/NMS8a80I5HSwLhfGP/gVq QoT5a0clbNhUYxJGpuSXHrCVgNr+ZOLJQ4N/J/boio3tdZ3ZDlJEY6qjDgQa/7lIX2dj U5G9O400KAZnBJ6l/S8OyGN+Nbr2Z5WD9bvtc9TwPNUzQFZClMrl0Z4PPicMMqXrmIyz aiWCpbHmfahhW8pLl9j55DyIYMlMjUsKoccAnhnmOv42JzVHpkCgZaZDc7SzVnMYk/nk +HRg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=O8OiZyFe; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-59349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59349-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=2; AJvYcCXQ5utUnvOixIzqJUC06rdZbk98uYquuso45jVxPXxd6QUSSTsJzGaRH0xeiad8sEAd0Fc1IpvaLkDmngDBhfO5W9Ici4DD+2lIy5sfRA== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id f19-20020a05620a15b300b00785ae5ff3casi1912117qkk.90.2024.02.09.05.19.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 05:19:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-59349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=O8OiZyFe; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-59349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59349-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A68B51C220E3 for ; Fri, 9 Feb 2024 13:19:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B5B28381B1; Fri, 9 Feb 2024 13:19:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="O8OiZyFe" Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E091364DA for ; Fri, 9 Feb 2024 13:19:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707484761; cv=none; b=mICiDpdbH89jBgW5PQw+jfMO537hhDHZtT/gjBcRby791nM7Y8HP7uBEnIsP82EDttPY3cZK3/JUgFqmiKG8mG4Im6EX2MyEwfxZ02Aiw8e6CgaBjkZZmzr+R8bJ1Qy9mN9rqH1dAPfyPIvb0HRrZ+7D7nwB+RXtd1IKjFbcAe8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707484761; c=relaxed/simple; bh=H0Ihgqg6vcooY6HsSUddyRQvt/glr76kGUtcEmebLvw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=iz0bFAu8rTM3GuXcNYW92Ns1SHc09VK8oeNDNj9Sy/Rg+LCMpBotQW8Owp9o7l4JsWTVztdgkkUafdPaYrR7+ZaJKX6UM5m2SEJ0JRPnra+ugFzRkGL9GNs2eiQceBsoBCYCbng74HBiFO0TdVFASjnPYcApx2+rsmiOcbWYvoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=O8OiZyFe; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-604ab54bb83so10255927b3.1 for ; Fri, 09 Feb 2024 05:19:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707484758; x=1708089558; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=H0Ihgqg6vcooY6HsSUddyRQvt/glr76kGUtcEmebLvw=; b=O8OiZyFePScKt86hTEL1JwkigXacBxrfnGWw2jyuBykB5K+Ijph0TlUc0bkr1AHqtP XtEMSS8igprPEaRn43fJmOv3GicsLLvQG/0ilLRKHukLk/VzJDJdGOjjwCV7VmZ4vBsM MQ/yiWn/omfJ5OC5MSZU8B4fSxYMd0lgONXsiNPpU3Z5SvvUshz1/pKO4/yFsCt1sQki VRGZWI/woSvN4lC0yLxdBFcW4UJsr+Wngbo52S18w0k6QxwM+x8JuVUe1rd+Zcbd2Nfn qu4CvZiayR1QRXLR43NLdWVwT6L3p23cx6tGzgxUfMPptWw0ug+x92+ZECDgOZl7OgXJ lkVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707484758; x=1708089558; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H0Ihgqg6vcooY6HsSUddyRQvt/glr76kGUtcEmebLvw=; b=xOmx/zKr9F0fpNueqJEcOiTVh4o3zoB+i+5v5X2SfIh07JyvlmSFpP5+1Df40Fn0z9 L7CnsJeEk6ZfJBz4S9Nlgn6StuPWhpjmhj9baitmXKysIsMhZliqAhVCjE+1Nx+xqri/ reXbQFs/UHJ/Q50j7jqm/KPC16yYA6B1sTuG55lF+4XvePnm/s+doPkgxod/5ngCU71M qa6YwhiCS5Yu5NCDQ7UP5wF+1i/BriKH3FYm2nfIUT2tjz83FK3KRMSEAkwFQDzyuDEV nyjZrF/CKtr6/lvymiScvL7w4xxtxDXQ63fIoIugBJyiD781QrAS9iQDoxUci6GKhOpF /nsg== X-Forwarded-Encrypted: i=1; AJvYcCWaDNSMbqnb3Qeh/rZRiEhEQLqVt/sEZFEo2neQHQSB3ZqJ3344s21QIsMk/LCI62EwaSKDSvDhuPdjk2uV5wJeFV4l1bPs1VIMdaao X-Gm-Message-State: AOJu0YzP6gj4upzSW8idzuuLaT5D9Uk6z8i38ZVULgSDprsVDcHtVXOC HOtDZl235hd7HgIb07IBslPFQyY2STXDlbcEICO3ZpppcTE5thltYpkeq1yh0aE1aNj11k71OvI 1Pvyt/7mFQRT1ms5pFbrM9365pwFxDUrvIztw+A== X-Received: by 2002:a81:6f03:0:b0:604:91b1:5401 with SMTP id k3-20020a816f03000000b0060491b15401mr1403138ywc.38.1707484758481; Fri, 09 Feb 2024 05:19:18 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240209-realtek_reverse-v6-0-0662f8cbc7b5@gmail.com> <20240209-realtek_reverse-v6-3-0662f8cbc7b5@gmail.com> In-Reply-To: <20240209-realtek_reverse-v6-3-0662f8cbc7b5@gmail.com> From: Linus Walleij Date: Fri, 9 Feb 2024 14:19:07 +0100 Message-ID: Subject: Re: [PATCH net-next v6 03/11] net: dsa: realtek: convert variants into real drivers To: Luiz Angelo Daros de Luca Cc: =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Feb 9, 2024 at 6:04=E2=80=AFAM Luiz Angelo Daros de Luca wrote: > Previously, the interface modules realtek-smi and realtek-mdio served as > a platform and an MDIO driver, respectively. Each interface module > redundantly specified the same compatible strings for both variants and > referenced symbols from the variants. > > Now, each variant module has been transformed into a unified driver > serving both as a platform and an MDIO driver. This modification > reverses the relationship between the interface and variant modules, > with the variant module now utilizing symbols from the interface > modules. > > Signed-off-by: Luiz Angelo Daros de Luca > Reviewed-by: Vladimir Oltean The code looks good, easy to read and it works, so: Reviewed-by: Linus Walleij Yours, Linus Walleij