Received-SPF: pass (google.com: domain of linux-kernel+bounces-59379-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 9 Feb 2024 14:39:52 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Aithal, Srikanth" <sraithal@amd.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Jakub Kicinski <kuba@kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Regressions <regressions@lists.linux.dev>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: linux-next20240208: tg3 driver nw interfaces not getting
 configured
Message-ID: <6aa4c396-00f2-4479-8ea9-fa67253ee662@lunn.ch>
References: <20240208155740.24c6ada7@canb.auug.org.au>
 <ce7150b7-b6f1-4635-ba5f-fdfda84a6e2f@amd.com>
 <fd72544a-f3ed-44bb-86e3-bdfa4fca720e@gmail.com>
 <8a59f072-4a71-4662-bfde-308b81e4ce88@amd.com>
 <47987433-7d56-483e-a0fc-38140cc17448@gmail.com>
 <11baa678-8cbe-4a9a-af09-381d649d648c@amd.com>
 <aa9a3495-22fd-4fac-abb0-afedf1b4d8ec@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aa9a3495-22fd-4fac-abb0-afedf1b4d8ec@gmail.com>

> Could you please test whether the following fixes the issue for you?
> 
> The uninitialized struct ethtool_keee causes the bug because
> mii_eee_cap1_mod_linkmode_t() leaves unknown bits as-is.
> 
> ---
>  drivers/net/ethernet/broadcom/tg3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index 50f674031..7d0a2f5f3 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -4616,7 +4616,7 @@ static int tg3_init_5401phy_dsp(struct tg3 *tp)
>  
>  static bool tg3_phy_eee_config_ok(struct tg3 *tp)
>  {
> -	struct ethtool_keee eee;
> +	struct ethtool_keee eee = {};

Nice catch.

Please add my Reviewed-by, if you have not already sent the real
patch.

	Andrew