Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp946217rdb; Fri, 9 Feb 2024 06:06:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IFZBLa09hBqXysx5fSZrTv+j0baT7IYtVrjbm8pCgGS/HEmSKRfQoKxbSuQuP71q8SIKVko X-Received: by 2002:a05:6402:1812:b0:560:10c:3cc with SMTP id g18-20020a056402181200b00560010c03ccmr1407348edy.21.1707487604299; Fri, 09 Feb 2024 06:06:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707487604; cv=pass; d=google.com; s=arc-20160816; b=fEbvw41CdM26Z8Ow/6EMDl2EzmN0GEouW7sldjOWaKq791mo276jY8hkanDTx12HbI 0E8z7OW3ozyaAlljwlOFXBGFa8OP/SYWnTAdxn0kSf2Np9pkih6j8w1aCXCPSlE7B7qi qvoWlkH6tq1XWhanLVT6qSTVhAy8ZRZP7KoPKCJ3VMf6IPbCNycCDB5VQr3j80Gz/YHz 9yCqbs6FiTQZZxacpjr5962jdcyaP2zHTYU0Lip/lczFG3oItWq9Kix/I/F1CH2RJvPK huc7qPxn1RlvAMbGikkoDg5ihO5j+MYhzU5kAl967IcUlSyd8hl06jP03bQC146vURWe DBAg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=edgfHyClH8frjqdW176guaeqRWtXQmQVgxIX7uID0gk=; fh=2L75xEdcSb0JtHjTv+jy3FPb+A0/owZxVk0E+43oj7Q=; b=hDSe8JszYAirBJ6fyweGErQ8MaKvgp7rT70NwDSJaldxpnPi+d2oMlBISsyrCssJX8 Tf55jyPFVluy/qJnSnYOD+A/yKZ3Ibgmt8AStEOXKOPTZADbfangbgr6qVA6db7pXXLs ukWxf1o0Hj7UY1PI0SSfYhk91iGWfEeiJLIXeVEHfH7F+t4O5ij9XyxFrxfQsPIJHl3O PGD+cIUGZOYPamUoReAw8KGBjpHEhVLOvgOMZc56kPjhn5ggC17+VbCtRPJC8u5csF9M 8GLR7SxOrSvRHkd2j/9/BvChClYXfAISERJvGLXokf320pZ+Mr6zei9ip0c+QDLXgVB9 UB+Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=PVJ6UVBC; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-59391-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59391-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com X-Forwarded-Encrypted: i=2; AJvYcCXT6rAOis4SZmRF4SZM76yWEiMOrouLs8yu/R5Y5OFpiZqgHaRZ0ZwcWEyZMlWFuKsRS6cV7VMQ8vD+8qJP0cp/QssDznWX6GLFCqTKUg== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id z17-20020a05640235d100b0056148c79709si461013edc.85.2024.02.09.06.06.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 06:06:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-59391-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=PVJ6UVBC; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-59391-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59391-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 90A3C1F253F2 for ; Fri, 9 Feb 2024 13:56:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 451C04D599; Fri, 9 Feb 2024 13:56:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="PVJ6UVBC" Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A45A4D11A; Fri, 9 Feb 2024 13:56:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707486974; cv=none; b=RXD7Th3oDXBDmyzya9BSxjnQ9xooR3yDRHDGDh3BmMTdn/K3x5+9HP0zfAqsOvGv0UEWHnEVV+LwwoFs3mbTQlA89Zt/D1T1/cyd+oAtaFr/9uvGr5MoJpu7DbRDbkz9fW+HIPfEwYqvG4nqZNR3w10v4GKY4P0McSFLFbn9Frw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707486974; c=relaxed/simple; bh=Y7H7/t7uj8gApP1bpHRilwd85LT3J++X+h8HBhu5qUE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ek8llW/pZ/KSwL83zvF+1TC0Ss3JEnjO+THVMFrOM4qGwRCJEYmhsJIyQTKKtzgijtGXZdIkDexhmyA2DKyvCbtuKOhTp26H1yXkEjYHHowmb9jhTV+OGoaLwbawEi9qqNB7giQgoNUW03fxc4yE/ZReir+SkmbyzfkmMJjAl1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=PVJ6UVBC; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 527851BF206; Fri, 9 Feb 2024 13:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1707486965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=edgfHyClH8frjqdW176guaeqRWtXQmQVgxIX7uID0gk=; b=PVJ6UVBC5ChpcMt8ptcINE+fuPY2TiGagSVF3uJU2+QddUP1LeGL0w4FRb0pFUOhCqjhWt bjTOPdW5gB2RI7SoAMoMMSFemuA+eq9D6Ni8zaFWqMYZv160/NbcUhG/iB+r0tRoEq03RC D2hn4hgqH4ySbdIC16GGjFM4Fhm21rY4sBESzpWBc9HNfTwg1KSzEV1lZ+7qaPXEBTe2tl FO1ODI4CnMP18TPzLgtz6GDqBebIKxwMzzkSaO/YfspkG7U+HrSaTCbJKVYdbD5ksmb2qQ DqxZU2j52LoFPPQFX7IDiVc/Z9XDnYrZuvPmWWZX+u9I6jXZbTe0aEHfdWSNuQ== From: =?utf-8?q?Th=C3=A9o_Lebrun?= Date: Fri, 09 Feb 2024 14:55:50 +0100 Subject: [PATCH v3 1/4] spi: cadence-qspi: fix pointer reference in runtime PM hooks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20240209-cdns-qspi-pm-fix-v3-1-540ac222f26b@bootlin.com> References: <20240209-cdns-qspi-pm-fix-v3-0-540ac222f26b@bootlin.com> In-Reply-To: <20240209-cdns-qspi-pm-fix-v3-0-540ac222f26b@bootlin.com> To: Mark Brown , Apurva Nandan , Dhruva Gole Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Gregory CLEMENT , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk , =?utf-8?q?Th=C3=A9o_Lebrun?= X-Mailer: b4 0.12.4 X-GND-Sasl: theo.lebrun@bootlin.com dev_get_drvdata() gets used to acquire the pointer to cqspi and the SPI controller. Neither embed the other; this lead to memory corruption. On a given platform (Mobileye EyeQ5) the memory corruption is hidden inside cqspi->f_pdata. Also, this uninitialised memory is used as a mutex (ctlr->bus_lock_mutex) by spi_controller_suspend(). Fixes: 2087e85bb66e ("spi: cadence-quadspi: fix suspend-resume implementations") Signed-off-by: Théo Lebrun --- drivers/spi/spi-cadence-quadspi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c index 74647dfcb86c..d19ba024c80b 100644 --- a/drivers/spi/spi-cadence-quadspi.c +++ b/drivers/spi/spi-cadence-quadspi.c @@ -1930,10 +1930,9 @@ static void cqspi_remove(struct platform_device *pdev) static int cqspi_suspend(struct device *dev) { struct cqspi_st *cqspi = dev_get_drvdata(dev); - struct spi_controller *host = dev_get_drvdata(dev); int ret; - ret = spi_controller_suspend(host); + ret = spi_controller_suspend(cqspi->host); cqspi_controller_enable(cqspi, 0); clk_disable_unprepare(cqspi->clk); @@ -1944,7 +1943,6 @@ static int cqspi_suspend(struct device *dev) static int cqspi_resume(struct device *dev) { struct cqspi_st *cqspi = dev_get_drvdata(dev); - struct spi_controller *host = dev_get_drvdata(dev); clk_prepare_enable(cqspi->clk); cqspi_wait_idle(cqspi); @@ -1953,7 +1951,7 @@ static int cqspi_resume(struct device *dev) cqspi->current_cs = -1; cqspi->sclk = 0; - return spi_controller_resume(host); + return spi_controller_resume(cqspi->host); } static DEFINE_RUNTIME_DEV_PM_OPS(cqspi_dev_pm_ops, cqspi_suspend, -- 2.43.0