Received-SPF: pass (google.com: domain of linux-kernel+bounces-59412-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 9 Feb 2024 15:07:20 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Catalin Popescu <catalin.popescu@leica-geosystems.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, afd@ti.com, hkallweit1@gmail.com,
	linux@armlinux.org.uk, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	bsp-development.geo@leica-geosystems.com, m.felsch@pengutronix.de
Subject: Re: [PATCH v3 2/2] net: phy: dp83826: support TX data voltage tuning
Message-ID: <00691961-d516-4338-b7e8-203625e561ee@lunn.ch>
References: <20240209123628.2113971-1-catalin.popescu@leica-geosystems.com>
 <20240209123628.2113971-2-catalin.popescu@leica-geosystems.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240209123628.2113971-2-catalin.popescu@leica-geosystems.com>

On Fri, Feb 09, 2024 at 01:36:28PM +0100, Catalin Popescu wrote:
> DP83826 offers the possibility to tune the voltage of logical
> levels of the MLT-3 encoded TX data. This is especially interesting
> when the TX data path is lossy and we want to increase the voltage
> levels to compensate the loss.

Maybe i'm being nit-picky....

"TX data path is lossy" should probably be "TX data path as far as the
RJ46 socket is lossy". 802.3 probably defines the voltage at that
point. If you tune it so the voltage is too high at that point, you
are breaking the standard. So you can use this to adjust for losses in
your coupling and cable run to the front panel. You should not be
using this for range extension by cranking up the voltages. Yes, you
might be able to, but we should not be encouraging it.

      Andrew