Received-SPF: pass (google.com: domain of linux-kernel+bounces-59427-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Koo, Anthony" <Anthony.Koo@amd.com>
To: Dan Carpenter <dan.carpenter@linaro.org>, "SHANMUGAM, SRINIVASAN"
	<SRINIVASAN.SHANMUGAM@amd.com>
CC: "Wentland, Harry" <Harry.Wentland@amd.com>, "Li, Sun peng (Leo)"
	<Sunpeng.Li@amd.com>, "Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>, "Koenig, Christian"
	<Christian.Koenig@amd.com>, "Pan, Xinhui" <Xinhui.Pan@amd.com>, David Airlie
	<airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, "Kazlauskas, Nicholas"
	<Nicholas.Kazlauskas@amd.com>, "Pavic, Josip" <Josip.Pavic@amd.com>, "Huang,
 Leon" <Leon.Huang1@amd.com>, "Adhuri, Mounika" <Mounika.Adhuri@amd.com>,
	"Huang, Lewis" <Lewis.Huang@amd.com>, "amd-gfx@lists.freedesktop.org"
	<amd-gfx@lists.freedesktop.org>, "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] drm/amd/display: Fix && vs || typos
Thread-Topic: [PATCH] drm/amd/display: Fix && vs || typos
Thread-Index: AQHaW1hJ7IhOQLhJY0uycbxy1/gQ5LECDHgw
Date: Fri, 9 Feb 2024 14:12:15 +0000
Message-ID:
 <DM6PR12MB4545EFF1E303FE549FFF06DAF34B2@DM6PR12MB4545.namprd12.prod.outlook.com>
References: <7482be2a-aca1-41dd-bb6e-d547571b9507@moroto.mountain>
In-Reply-To: <7482be2a-aca1-41dd-bb6e-d547571b9507@moroto.mountain>
Accept-Language: en-US
Content-Language: en-US
msip_labels:
 MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=dd976861-e9b1-4fd0-bee5-cdb124f30a44;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-02-09T14:09:22Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM6PR12MB4545:EE_|MW3PR12MB4428:EE_
x-ms-office365-filtering-correlation-id: b74bc418-f61f-42eb-8df4-08dc29791e60
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 iVWCE8j+BFRfQ+rvfNxna344X+WDwxgFKA7O0JDV3cPe4E8twcpqSh4cMfggaaR8PbSD1HXMgsAUZN0MDhXfAsabl+yAMt4dpwuQCChkz0YyHgso/gPo3zZSe6INYhvuH0AjQXRyShqElW2ykTazLgR9YX7fAyD6X/ZXXGZGpAWfQva/6Bo1Vv7IO/E3vQVXxu0csezCuPx7q6QmpZBJ2/Y3DkRU3XxFwf+3wEjq89LrZma6HFYbi5whNgXgbDwd+Buk9YIwR4worQ52/pyYH+FK/iROmlmUNLLrewLvr9E//mA4l/kor44/loDhWyr0aAnItVTs9WYik5W2bH0Op5IiVoXVpqw5i6E/6F8ZzLRurc7AiYvhC0InnRnjWiqtsaz8GWax3DSSLIVACKraHpgOcNQ0IwCMm+HgpdRuiZ2B2CoZmYa04RWAoIZMdBNdzfSNAYx6ktc1RJFWo+0G4LJLG75V6AHWLkgZCDAyotfVwv+763vRifi5M4if/KA78qEk46Fi7eS7G1hpo0Qxzjezh0J5JPKoQ0BrajmlSqRL6fTHQNcRXv2pq2rSyD2s0QyIbtU6D6cduDPIBvX2Ym3hX70dLT8WuxQ/eROOu6pOejIp3fM6v0oQpvO+oYB/
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4545.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(346002)(376002)(39860400002)(366004)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(2906002)(52536014)(8676002)(4326008)(8936002)(5660300002)(54906003)(83380400001)(26005)(33656002)(38100700002)(122000001)(86362001)(38070700009)(110136005)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(6636002)(316002)(6506007)(7696005)(53546011)(71200400001)(9686003)(478600001)(55016003)(41300700001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?9d0sPFpNHCL5FWZpAmql3hZEvi4f8YgtbFBD1JAzlsP2nmbWQJ7BOmDdBGrG?=
 =?us-ascii?Q?1br9L2r9ccP9QwP83MqSsmR3m7uwULIMoQ9ALtwc+gEclVpXdoLTf7t0rhh0?=
 =?us-ascii?Q?2DaZLsXi9Jl9E0Ztia20GEhnW/Xb0ifawF4RTaI5nNxVMjd4t5OpiX9MWzfF?=
 =?us-ascii?Q?C1zOjXWp6z8LMdjGEz4SgktG8UtaSW45sltX7XhX6KO0gWO5EV2t6zIiJG5/?=
 =?us-ascii?Q?NZpGlvQe39Ja/WQuImA/PH0JXhxSs0WLhctqPGaqwmO1mjG2K8geZYGCAbCY?=
 =?us-ascii?Q?P3t8v/iuHkl/8j0nRNr1dcuxqLKpQNqQPbk7zAfDwGSkYXZoaIlqe3UwwENX?=
 =?us-ascii?Q?2CYtcaIeBamDRgJQF4Lk8F8J3cREVIoY358n1FcljjFEpY2TkykWXFQ63yKD?=
 =?us-ascii?Q?GjuVbDkLJ2KcaNgLLbWVx0gtY5d5XJUrNvgb0EOwbyN/J9bMZnxcDzBF0whs?=
 =?us-ascii?Q?CyhWRL4Hq8JG+qd1suOlENFXDKxxIjNeAi/7t32soXyCvF7JnYm8T3AHCsml?=
 =?us-ascii?Q?XdNhsBZMUEvgsahVgbEX7WbE+P1rAxWnV4+dnFaHqv4XCyvpAHgO06+ek60q?=
 =?us-ascii?Q?mzjXXksPdQmmW/kOVT5rtDOf7wJ+lPozErzy0Gnw85xneGcBAxcNacADAtBb?=
 =?us-ascii?Q?kr/CvC8HAubLgyk6iI60PzEng5KgXacjCDOb/biVcbVj996Ec3nyisTJ4Eco?=
 =?us-ascii?Q?vkCxvmH3Kujj9ZD4ajQlwwH3kMFEIjjpGsrVBlKnEErxrHzdCk/pO8rSvf5m?=
 =?us-ascii?Q?gTS6AhE9OtuQ3zJEllKOgW/q6QAWryv09+vN8Vy+sD2x70S2P6EjdERC826M?=
 =?us-ascii?Q?Dk9kcbn/XJuKMco55vRe/VLSicKf1DHvv/VCDQPeXVms+EZmiatAZ08ycGTi?=
 =?us-ascii?Q?mw5zbgyrIG8jzfL4uqfIUb/JJ4Vn48BylOBjMhj1MMmKuV7Lq03n5DBzUi0u?=
 =?us-ascii?Q?ZuuVN0aWKCNnAfoR6zbA5AI/y8sCWT7kz3e9bEQYPQBhTaY0cq5zX/tSOpnT?=
 =?us-ascii?Q?KEIW04D+lwV2/R1cd3qNaUpqjCWjqWTs3UZ8zRBhgZjig1Y3TtlPGE2x7Tju?=
 =?us-ascii?Q?NE8QvkBOp0RipzOZYpKrY10YkiYLSkLEXy23Y0/uE0I4mFTkzTgSx7LLDq9D?=
 =?us-ascii?Q?x861TTtumGd7+NvzaErpq/VqqFa5PY00pTE75zBdhgJp5JCE39bsBA64A5px?=
 =?us-ascii?Q?wxcPbczIKWpqiktRZPO4sNUa9yaN5bZVG7f4Ww0v8eGkHhJxeW2zlWDhCv1C?=
 =?us-ascii?Q?uWY2wKtUF5ouG0EEeFEWLaGAGqb0SKZkdw/Sxhh85v5OIR24AC1obgsk1CWN?=
 =?us-ascii?Q?godNORR3nW3dhcA7OkESjhsvIAGivm2JhcwcC/XityGHE37t+Jiw57rLIzb/?=
 =?us-ascii?Q?Sl7EDu8Qhv5/6nezYfd7B5Ml+tmBLI7uGQ+uGLQPF0MdITooKtPf4ggohQ1U?=
 =?us-ascii?Q?EzQoG4oVfIVEJS8nZoUgQJwxsUMjnVMM3oMIgP5OUUMZnwneLIYU5QkbJ90a?=
 =?us-ascii?Q?+8GPUqPJZ6Oy0psr1yOeXg9lt/mUTEhADbtJkO29nR6cEhWut+Vm9G/P++Si?=
 =?us-ascii?Q?z15NAgWW9xaZt87BLQo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4545.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b74bc418-f61f-42eb-8df4-08dc29791e60
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2024 14:12:15.6687
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9v4M/tQNBWkyNe40BHv0/CPwEarpNnMhj1Fy7+dsQY9SPztzy7gpGnxjQgMS5WaH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4428

[AMD Official Use Only - General]

Reviewed-by: Anthony Koo <Anthony.Koo@amd.com>

Looks good, my mistake for not noticing this!

Thanks,
Anthony

-----Original Message-----
From: Dan Carpenter <dan.carpenter@linaro.org>
Sent: Friday, February 9, 2024 8:03 AM
To: SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@amd.com>
Cc: Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo) <Sunpeng.L=
i@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Deucher, Alexande=
r <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>=
; Pan, Xinhui <Xinhui.Pan@amd.com>; David Airlie <airlied@gmail.com>; Danie=
l Vetter <daniel@ffwll.ch>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.c=
om>; Koo, Anthony <Anthony.Koo@amd.com>; Pavic, Josip <Josip.Pavic@amd.com>=
; Huang, Leon <Leon.Huang1@amd.com>; Adhuri, Mounika <Mounika.Adhuri@amd.co=
m>; Huang, Lewis <Lewis.Huang@amd.com>; amd-gfx@lists.freedesktop.org; dri-=
devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; kernel-janitors@=
vger.kernel.org
Subject: [PATCH] drm/amd/display: Fix && vs || typos

These ANDs should be ORs or it will lead to a NULL dereference.

Fixes: fb5a3d037082 ("drm/amd/display: Add NULL test for 'timing generator'=
 in 'dcn21_set_pipe()'")
Fixes: 886571d217d7 ("drm/amd/display: Fix 'panel_cntl' could be null in 'd=
cn21_set_backlight_level()'")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c b/driv=
ers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c
index 5c7f380a84f9..7252f5f781f0 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c
@@ -211,7 +211,7 @@ void dcn21_set_pipe(struct pipe_ctx *pipe_ctx)
        struct dmcu *dmcu =3D pipe_ctx->stream->ctx->dc->res_pool->dmcu;
        uint32_t otg_inst;

-       if (!abm && !tg && !panel_cntl)
+       if (!abm || !tg || !panel_cntl)
                return;

        otg_inst =3D tg->inst;
@@ -245,7 +245,7 @@ bool dcn21_set_backlight_level(struct pipe_ctx *pipe_ct=
x,
        struct panel_cntl *panel_cntl =3D pipe_ctx->stream->link->panel_cnt=
l;
        uint32_t otg_inst;

-       if (!abm && !tg && !panel_cntl)
+       if (!abm || !tg || !panel_cntl)
                return false;

        otg_inst =3D tg->inst;
--
2.43.0