Received-SPF: pass (google.com: domain of linux-kernel+bounces-59452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Daniel Gomez <da.gomez@samsung.com>
To: "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"brauner@kernel.org" <brauner@kernel.org>, "jack@suse.cz" <jack@suse.cz>,
	"hughd@google.com" <hughd@google.com>, "akpm@linux-foundation.org"
	<akpm@linux-foundation.org>
CC: "dagmcr@gmail.com" <dagmcr@gmail.com>, "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"willy@infradead.org" <willy@infradead.org>, "hch@infradead.org"
	<hch@infradead.org>, "mcgrof@kernel.org" <mcgrof@kernel.org>, Pankaj Raghav
	<p.raghav@samsung.com>, "gost.dev@samsung.com" <gost.dev@samsung.com>,
	"Daniel Gomez" <da.gomez@samsung.com>
Subject: [RFC PATCH 3/9] shmem: move folio zero operation to write_begin()
Thread-Topic: [RFC PATCH 3/9] shmem: move folio zero operation to
	write_begin()
Thread-Index: AQHaW2RUQo5uE9Fs4EG+AkzmtoGKGQ==
Date: Fri, 9 Feb 2024 14:29:02 +0000
Message-ID: <20240209142901.126894-4-da.gomez@samsung.com>
In-Reply-To: <20240209142901.126894-1-da.gomez@samsung.com>
Accept-Language: en-US, en-GB
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPKsWRmVeSWpSXmKPExsWy7djP87obzY6lGly5o2gxZ/0aNovXhz8x
	Wpzt+81mcXrCIiaLp5/6WCxmT29mstiz9ySLxeVdc9gs7q35z2pxY8JTRovzf4+zWvz+MYfN
	gcdj56y77B4LNpV6bF6h5bFpVSebx6ZPk9g9Tsz4zeJxZsERdo/Pm+Q8Nj15yxTAGcVlk5Ka
	k1mWWqRvl8CVsfSyVcFzwYrPJ76yNDDe5+ti5OSQEDCRePJ1I3MXIxeHkMAKRomZP5YzQjhf
	GCWadt5jhXA+M0q8PzSRGaalZ9UzFojEckaJjmV7meGqlt/5CJU5zSgxbfFDhMlHF/5lB+ln
	E9CU2HdyEztIQkTgOaNE6+6PYA6zwG1miTntsxhBqoQFvCROfp4BZosIBEq877vAAmHrSXT8
	/cYGYrMIqEgsWHof7CpeASuJ5t5VYDangLXEvEfrwWoYBWQlHq38BbaZWUBc4taT+UwQXwhK
	LJq9B+ojMYl/ux6yQdg6EmevP2GEsA0kti7dxwJhK0p0HLvJBjFHT+LG1ClQtrbEsoWvoW4Q
	lDg58wnY/xICTVwSexZPYIVodpHoPL4eapmwxKvjW9ghbBmJ/zvnM01g1J6F5L5ZSHbMQrJj
	FpIdCxhZVjGKp5YW56anFhvlpZbrFSfmFpfmpesl5+duYgSmudP/jn/Zwbj81Ue9Q4xMHIyH
	GCU4mJVEeEOWHEkV4k1JrKxKLcqPLyrNSS0+xCjNwaIkzquaIp8qJJCeWJKanZpakFoEk2Xi
	4JRqYIrKZW6esourctYD9YZejp5G53R3z3zPX2FTL81h6CsKz9T6kudiZjSh/++pFyZLNoYf
	32dVnnNVhe3JmsdTXqcZbjFZK/Jt6UQhVeaM+LNtElO2yp6+4Lkv2F//9V8Ok1pb3yVXZ6yW
	dEvS/lwa0bJ9uY74ovViIhev7f2wo89zj4rp/3DOvOLPSq76X+r3m2R1f/lvN2/uo3UHW6xO
	yTQLZbLzH3Mr6+LOc0l98e5/eOL+s3b7XiwW6PI/os1aEjyrt3Da8dV/buT/zumTFw5Q5A75
	teTT1llRNrez5BXvBggIVuXscjHp1smekVJ+a9+0Wu7X94xOxkiET5gjGLAnvbUkU5rl5P/n
	aR7PlViKMxINtZiLihMB4wymQOIDAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFKsWRmVeSWpSXmKPExsVy+t/xe7obzY6lGtxZzWgxZ/0aNovXhz8x
	Wpzt+81mcXrCIiaLp5/6WCxmT29mstiz9ySLxeVdc9gs7q35z2pxY8JTRovzf4+zWvz+MYfN
	gcdj56y77B4LNpV6bF6h5bFpVSebx6ZPk9g9Tsz4zeJxZsERdo/Pm+Q8Nj15yxTAGaVnU5Rf
	WpKqkJFfXGKrFG1oYaRnaGmhZ2RiqWdobB5rZWSqpG9nk5Kak1mWWqRvl6CXsfSyVcFzwYrP
	J76yNDDe5+ti5OSQEDCR6Fn1jKWLkYtDSGApo0Rb92pGiISMxMYvV1khbGGJP9e62CCKPjJK
	/P11D6rjNKPEwTktUJkVjBJdi1YygbSwCWhK7Du5iR0kISLwlFFi+u9DYC3MAreZJea0zwJb
	IizgJXHy8wwwW0QgUOLP979sELaeRMffb2A2i4CKxIKl95lBbF4BK4nm3lVgthCQPW37abAa
	TgFriXmP1oPZjAKyEo9W/mIHsZkFxCVuPZnPBPGEgMSSPeeZIWxRiZeP/0E9pyNx9voTqKcN
	JLYu3ccCYStKdBy7yQYxR0/ixtQpULa2xLKFr6HuEZQ4OfMJywRG6VlI1s1C0jILScssJC0L
	GFlWMYqklhbnpucWG+oVJ+YWl+al6yXn525iBCaqbcd+bt7BOO/VR71DjEwcjIcYJTiYlUR4
	Q5YcSRXiTUmsrEotyo8vKs1JLT7EaAoMo4nMUqLJ+cBUmVcSb2hmYGpoYmZpYGppZqwkzutZ
	0JEoJJCeWJKanZpakFoE08fEwSnVwJTw4+6k1eH5h6bWmDgtytWcdWPGlTNdFq7ak/4w/v5R
	+23y9H7OtMbX/6Kezgn56JGQmeRn1Gj57EfHe+UVDpv5xe5sPdQ68YboZDmXq5PyxF7kF+5+
	/+fqpaTwG0Y/Ny299Ub7Plfy80Y/Zl+lL7lSMZU3lTZfiXpSWTj/4vqZTZNSbhRw3F3Vmcee
	GbjgKbfrYdZvy6bH7pXI+dXRnLH+3a41jno/Hc8unLdda/JJjeajDBJb1KoZU7c3P5mic6vw
	QsfERTZNvkc2fbD859j6IfpNoOC/MJNgl09lr/8XV2y3mmYWUMyuWPO7WjRZ+lKmkDdr3ptd
	l49Ou5zYVuUrF2IvyJ9QJNp/4F95iroSS3FGoqEWc1FxIgDA8rDp3QMAAA==
X-CMS-MailID: 20240209142905eucas1p2df56a08287a84a5fa004142100926bb4
X-Msg-Generator: CA
X-RootMTR: 20240209142905eucas1p2df56a08287a84a5fa004142100926bb4
X-EPHeader: CA
CMS-TYPE: 201P
X-CMS-RootMailID: 20240209142905eucas1p2df56a08287a84a5fa004142100926bb4
References: <20240209142901.126894-1-da.gomez@samsung.com>
	<CGME20240209142905eucas1p2df56a08287a84a5fa004142100926bb4@eucas1p2.samsung.com>

Simplify zero out operation by moving it from write_end() to the
write_begin(). If a large folio does not have any block uptodate when we
first get it, zero it out entirely.

Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
---
 mm/shmem.c | 27 ++++++++++++++++++++-------
 1 file changed, 20 insertions(+), 7 deletions(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index 5980d7b94f65..3bddf7a89c18 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -149,6 +149,14 @@ static inline bool sfs_is_fully_uptodate(struct folio =
*folio)
 	return bitmap_full(sfs->state, i_blocks_per_folio(inode, folio));
 }
=20
+static inline bool sfs_is_any_uptodate(struct folio *folio)
+{
+	struct inode *inode =3D folio->mapping->host;
+	struct shmem_folio_state *sfs =3D folio->private;
+
+	return !bitmap_empty(sfs->state, i_blocks_per_folio(inode, folio));
+}
+
 static inline bool sfs_is_block_uptodate(struct shmem_folio_state *sfs,
 					 unsigned int block)
 {
@@ -239,6 +247,15 @@ static void sfs_free(struct folio *folio, bool force)
 	kfree(folio_detach_private(folio));
 }
=20
+static inline bool shmem_is_any_uptodate(struct folio *folio)
+{
+	struct shmem_folio_state *sfs =3D folio->private;
+
+	if (folio_test_large(folio) && sfs)
+		return sfs_is_any_uptodate(folio);
+	return folio_test_uptodate(folio);
+}
+
 static void shmem_set_range_uptodate(struct folio *folio, size_t off,
 				     size_t len)
 {
@@ -2845,6 +2862,9 @@ shmem_write_begin(struct file *file, struct address_s=
pace *mapping,
 	if (ret)
 		return ret;
=20
+	if (!shmem_is_any_uptodate(folio))
+		folio_zero_range(folio, 0, folio_size(folio));
+
 	*pagep =3D folio_file_page(folio, index);
 	if (PageHWPoison(*pagep)) {
 		folio_unlock(folio);
@@ -2867,13 +2887,6 @@ shmem_write_end(struct file *file, struct address_sp=
ace *mapping,
 	if (pos + copied > inode->i_size)
 		i_size_write(inode, pos + copied);
=20
-	if (!folio_test_uptodate(folio)) {
-		if (copied < folio_size(folio)) {
-			size_t from =3D offset_in_folio(folio, pos);
-			folio_zero_segments(folio, 0, from,
-					from + copied, folio_size(folio));
-		}
-	}
 	shmem_set_range_uptodate(folio, 0, folio_size(folio));
 	folio_mark_dirty(folio);
 	folio_unlock(folio);
--=20
2.43.0