Received-SPF: pass (google.com: domain of linux-kernel+bounces-59533-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <c9629380-c97c-4797-b6b3-5044d5beeb97@amd.com>
Date: Fri, 9 Feb 2024 09:28:16 -0600
User-Agent: Mozilla Thunderbird
From: "Moger, Babu" <babu.moger@amd.com>
Subject: Re: [PATCH v15-RFC 1/8] x86/resctrl: Split the RDT_RESOURCE_L3
 resource
Reply-To: babu.moger@amd.com
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
 Reinette Chatre <reinette.chatre@intel.com>,
 Peter Newman <peternewman@google.com>, Jonathan Corbet <corbet@lwn.net>,
 Shuah Khan <skhan@linuxfoundation.org>, x86@kernel.org
Cc: Shaopeng Tan <tan.shaopeng@fujitsu.com>, James Morse
 <james.morse@arm.com>, Jamie Iles <quic_jiles@quicinc.com>,
 Randy Dunlap <rdunlap@infradead.org>, Drew Fustini <dfustini@baylibre.com>,
 linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
 patches@lists.linux.dev
References: <20240126223837.21835-1-tony.luck@intel.com>
 <20240130222034.37181-1-tony.luck@intel.com>
 <20240130222034.37181-2-tony.luck@intel.com>
Content-Language: en-US
In-Reply-To: <20240130222034.37181-2-tony.luck@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VkExaUkrOHlzaTBqNWI2QUt5WW1FcnRRUlZWcjdUdTZHMUNCY2RIN3BCaFVQ?=
 =?utf-8?B?Y0s4RmxDc3g4UXVyUE5SRW80WXJJSHA0K2RnSk1CVWtWZ2pqN29XSE9VOXZG?=
 =?utf-8?B?dzlCZUpENEs2bkk2eEhCRzdjZ25VbGJsYU9RQVRZNHJHQ3FKR3N6NUZkRTYr?=
 =?utf-8?B?a3h0MnRxa1VCaElqUFgvcnY5MWZCcksrczFzM1pWOUVydnZwdEkremNQY3Ja?=
 =?utf-8?B?VWovN1ZBMTcvaXo0N2trU0pDRzRxb2Z5ejZrUGs1NVpWWTBEV2s1WVF6cGFX?=
 =?utf-8?B?QW1GSEh3SW8rZ0tPU3NoNXFQMXVRQUxZR3E5R1VIWkRZOXh1eXlpSmZSeUti?=
 =?utf-8?B?bW1IMms1cEYvbStzY05oa3ovdkh3ZERzQnpWcmtTcmlNTyswYXhRaUpGWU1j?=
 =?utf-8?B?UVdDakJCZjZaQWIzKzRkWFppT3p1bVJPVDRDY09jYmc4SERSL3FIU3lZSjZi?=
 =?utf-8?B?Z1ZuZmxsT0QvK0JvbVZhalhzdHdGZktBalVqdmNjZDZqUnE2eFBWSlZvTGda?=
 =?utf-8?B?KzZVVk4zZFNORmtDdmxuWG5DaGd3SFVQeWlXU0tMeEJENmwyRk44bml5VTB3?=
 =?utf-8?B?bXRkcjY1TUU4QURiTVVTbjVVVW5nZ2tOeFdlM3NPdVdJdUdLS0FlUUpHTUhX?=
 =?utf-8?B?dlFZWnFINDRtYS9OQ00xaWtPeHZWK0Q3TjFiMHd2c2R6RnVhMVl5QXU1NkRJ?=
 =?utf-8?B?WTN3Mk1mT3p2TFNlZ1F0c09YYVRHb1RzRXF4dkFzQWpQem5FR3FTOHJRaCtn?=
 =?utf-8?B?WnBaOS9YUmcrUkJua2FrdEhuQ3FtN0JxN1c5UEozb2ltWEdneHJpaUhxU20z?=
 =?utf-8?B?cXRVTE9PZE00dTgydnF5U25ObnJiNTFWVGhaZC9sUUpudkN2NzNZQnhBN2pq?=
 =?utf-8?B?NUtseS96MTVZdk1oek5tTWNSOUNXbGxRRFNtbVlvb0JKMXVPMzBYN1BLSlp2?=
 =?utf-8?B?SlJkVDhqVmxFNE5LSDVSZFZVYTQ0ek1lVjdEcklCWWdKMDdrNkltRXZtaWhq?=
 =?utf-8?B?dnBsYWFQc214VUwxT1dieThUUEFVRDRyaHhETjQ5NVJrK0hLb1ZKdDA3S0xZ?=
 =?utf-8?B?YTVoQmtqRHd2djJvemd2QjJIRytSenlUSFk4bU9MaENRaGgzYlVwcCtTUkx6?=
 =?utf-8?B?ODcxVjg4ZllManNmaWNnSy92YXlOQXI3ZytWeTRQaEZ3eXVMU25UZFd2Y2E5?=
 =?utf-8?B?eGlvSUJrd2tBZHVJVGNkdHlzQlpPdUgyRnVKUlRYQmsrOEFzeHlFRVBFcEk0?=
 =?utf-8?B?M002cXBvdG5WczUxY3ZQUnhzQzhNNjcrVjI1U3BYRHpUT1RSczg0enA5VzlR?=
 =?utf-8?B?cVpReVdaM0oycFIrbm5yeFBpbDI2UmVwRENwMUtNMXNjMXU3YXp5ZEhZbmVx?=
 =?utf-8?B?L3hFMU1ldHBkTVZiK1pLTDdaNEQzQTJQdW1SL2MwdWNnejNNNDYyanRxeW13?=
 =?utf-8?B?U3lQM2pqS0VVcWt5RklSN3g4cVkwUGNoay8yWXdJRDlFQWxXYXhLajBQL1dI?=
 =?utf-8?B?aUsvMWJzcDdudktsWk9VOFpTV3ZoUmtaL25nU1pTU2lXSERWL3JvMzJNTDBm?=
 =?utf-8?B?UzVSZk5BYXpsSmFqdENNSkxxcERvOG9pYTkyMUY5aTRBL0FpbjBBamFobVhr?=
 =?utf-8?B?a0Z4RzAxdUQrTTg2NmpvdmR4R2pWc09FbXZVRFFGMXhjT1h3dVdWZm1SUEZK?=
 =?utf-8?B?VUJMWkx0bmx3QVJad2czaGZGdnpuS2o0encralYvOGpmeG94OFM5NXR1Y1N2?=
 =?utf-8?B?VDdMT1VaV00rTEdyMTA3dTJVWGE0UGZtMEJkaWJTZ1hkcE1kVEdIMTltVCtH?=
 =?utf-8?B?bXhiOHNPemF2M2RnZ2lkelIvK2d4c2xkSUlUOWdGb1VsT3hmdkM1NTY2SU91?=
 =?utf-8?B?cFJPYW92Nkk4N1Y1NjdEbEhKeG4zT2tpejRzRzZZSzVCNmlDTnBhcUFFOFZ6?=
 =?utf-8?B?MU1XWXIvOVNXZ3dhSERmM0FnQ2llUmU1WFlmcWtpanN5a2kyaGE1ODNjdE95?=
 =?utf-8?B?a0xNSERDVGZFTTIvTWhIeXVDM2tuZ1dadVVIZ2szWjdmcWZuazRPdGRrVDRX?=
 =?utf-8?B?cVBKY01rWjUwbXFSbEtiSkN1K051VnRQYW1qV2YwOU1HK2pheURvazQ1N0hS?=
 =?utf-8?Q?hjGk=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f088b744-349f-485d-3c2c-08dc2983bd8e
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 15:28:17.8544
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R1aHONjNC8NKeWJsLwjOFO1e5k3du8mRZh/1tjq5RwldpMJJWWLFAM4QSCotCS2F
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7503

Hi Tony,

On 1/30/24 16:20, Tony Luck wrote:
> The RDT_RESOURCE_L3 is unique in that it is used for both monitoring
> an control functions. This made sense while both uses had the same

an/and

> scope. But systems with Sub-NUMA clustering enabled do not follow this
> pattern.
> 
> Create a new resource: RDT_RESOURCE_L3_MON ready to take over the
> monitoring functions.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>  arch/x86/kernel/cpu/resctrl/internal.h |  1 +
>  arch/x86/kernel/cpu/resctrl/core.c     | 10 ++++++++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index 52e7e7deee10..c6051bc70e96 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -429,6 +429,7 @@ DECLARE_STATIC_KEY_FALSE(rdt_alloc_enable_key);
>  extern struct dentry *debugfs_resctrl;
>  
>  enum resctrl_res_level {
> +	RDT_RESOURCE_L3_MON,
>  	RDT_RESOURCE_L3,

How about?
RDT_RESOURCE_L3,
RDT_RESOURCE_L3_MON,

>  	RDT_RESOURCE_L2,
>  	RDT_RESOURCE_MBA,
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> index aa9810a64258..c50f55d7790e 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -60,6 +60,16 @@ mba_wrmsr_amd(struct rdt_domain *d, struct msr_param *m,
>  #define domain_init(id) LIST_HEAD_INIT(rdt_resources_all[id].r_resctrl.domains)
>  
>  struct rdt_hw_resource rdt_resources_all[] = {
> +	[RDT_RESOURCE_L3_MON] =
> +	{
> +		.r_resctrl = {
> +			.rid			= RDT_RESOURCE_L3_MON,
> +			.name			= "L3",

L3_MON ?

> +			.cache_level		= 3,
> +			.domains		= domain_init(RDT_RESOURCE_L3_MON),
> +			.fflags			= RFTYPE_RES_CACHE,
> +		},
> +	},
>  	[RDT_RESOURCE_L3] =
>  	{
>  		.r_resctrl = {

-- 
Thanks
Babu Moger