Received-SPF: pass (google.com: domain of linux-kernel+bounces-59537-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <6628954f-c7e9-4040-9f03-7b5b6a6d082d@amd.com>
Date: Fri, 9 Feb 2024 09:29:03 -0600
User-Agent: Mozilla Thunderbird
From: "Moger, Babu" <babu.moger@amd.com>
Subject: Re: [PATCH v15-RFC 5/8] x86/resctrl: Add "NODE" as an option for
 resource scope
Reply-To: babu.moger@amd.com
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
 Reinette Chatre <reinette.chatre@intel.com>,
 Peter Newman <peternewman@google.com>, Jonathan Corbet <corbet@lwn.net>,
 Shuah Khan <skhan@linuxfoundation.org>, x86@kernel.org
Cc: Shaopeng Tan <tan.shaopeng@fujitsu.com>, James Morse
 <james.morse@arm.com>, Jamie Iles <quic_jiles@quicinc.com>,
 Randy Dunlap <rdunlap@infradead.org>, Drew Fustini <dfustini@baylibre.com>,
 linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
 patches@lists.linux.dev
References: <20240126223837.21835-1-tony.luck@intel.com>
 <20240130222034.37181-1-tony.luck@intel.com>
 <20240130222034.37181-6-tony.luck@intel.com>
Content-Language: en-US
In-Reply-To: <20240130222034.37181-6-tony.luck@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NHczaDNvZTVVblhqVkFNZGZQdXc4b2ZlNEd0c2psRml6bTJPWm53RzNqK1BT?=
 =?utf-8?B?Z29YbEhuZ1lWZzhSaGFaaG5RTkhzaGx4R29aL1ZsQkxrcEUwRkplaHBlL1hG?=
 =?utf-8?B?a2V1YmVMNzVFaGViQUE2eHIyY29Cc3ZHUmk3THdBVEQ5Q1VGSlZ5ZnYvSElv?=
 =?utf-8?B?cXZVTHI1a0lkOXZFTzVLZGIxUVhoSWdXMllPVm1YNmcxT0lpWnlsUmEzZ2Js?=
 =?utf-8?B?L2d2czJPS2UrVUhTQ2hPZXNSc3JrK0t3a3FWSHk1K1RwdVZBVTh5aUU2WGg1?=
 =?utf-8?B?Njltd2UzV3Z3VmEyQTZKTUVGTEJkeGVraDdLdDVMNmY1QzlNSUxkR2Q4L0FH?=
 =?utf-8?B?RERsVVhXWW1ISXFkcmp1dVB0NVc1T1VKOU16dDNQS0dTSnU5QWFScWhYRnRW?=
 =?utf-8?B?UDVPb3RqTzR5dnJ6YlZTZnFRMnMxcDFCUG8wU09YK3hSRkNhMXNkOHZhcFdO?=
 =?utf-8?B?cnJ5QWowVVptcnN5aVpRSzlOVGFGNklSQ25GbE9NQlFxK2cwWU9mcjdPZzBa?=
 =?utf-8?B?UWVTbXZJcWxiZDQ5ZWg1WnVDeHl6Q051bVNFUmVmRFlhaDYzazZ4RGlIbjBq?=
 =?utf-8?B?aXcwakxuZXNRcnkwWXEwOUNNUWF0VmxuYlVZS1dCby9rVHpidGxoNzhjTWFE?=
 =?utf-8?B?NkEydXUzWkRVSi9obStBNm8xdElUMkQrOWNkMk1VcEJDWWZ4V3BrTTI0SmdN?=
 =?utf-8?B?MUxUUGNUUDVQZmVhc05pTTl1Y2x3RkRYa3hzK3pHQkM5REZsbHJoeENxZHhJ?=
 =?utf-8?B?QitUdi9YUGkyeGtvMDFzNVV0ZEtYTXRJSFJQMm0zVURiV01GRUtoaVhCMEFH?=
 =?utf-8?B?UVlEM25wVm1sQ241Ky9XaENKWWczYzhTSWtWMHNZZVVJZ0pUeisxUjZJSFVK?=
 =?utf-8?B?YWtrckpiZUdFbHpUbjhSUk0vajNuVkM5SUNyRURmSG1ZTCtUOSttOVh0MHhG?=
 =?utf-8?B?UG5jcEQ4cnB5bXRocmluUUZzYkJQM3hyMXd3NzZGclp3elhnTmp2M2dnZ0ZI?=
 =?utf-8?B?ellMMjEzMGk4KzU3ZVUyWUQ0SE52NG5YVG5NTTZnVGE1dnpHRlRPR2Q0cVB0?=
 =?utf-8?B?RjBCTmp0WVVFMXNuS1FGc3pidGRlQThQbEJTSGZybXpVME1HdGRQSGcycTQw?=
 =?utf-8?B?QVZlbXlJaXR3Y01mUGJ2NFZOM0NscGJFeWVRYUJyeE9DejJPS29YV1NmLzlZ?=
 =?utf-8?B?WFRXRUtSV2VRSkVOR25BbkFsaG9LaVFkU1U1aXI1K0w4elJ4T29Oajl1KzJT?=
 =?utf-8?B?elg3T05YWGhVbmVVNEFsT0ZkdEdtYW4wWGZRem14b3AyRHphUDNjU3psa09D?=
 =?utf-8?B?aEN3YUlRbG1PdEZUcCt1RkZqQ2xTL1NWY3hrdXNybDBsL0k3S3phNGw4Si8z?=
 =?utf-8?B?bzl3VU4wcTFKdHdZcDR4SkRDMXIwWnFVR1luTWxrc1YvenA1dEFDcWZ5VDBR?=
 =?utf-8?B?VmIwVklTWjFuZ21CWUhzLy9iNy9YaG9QUXF4N2RiejB0YUZOZXhucjNPbjVj?=
 =?utf-8?B?M3NWMUJubU9LeFQvNGhWVlJRQjQra043Sjh4MVQ1aVZuMURMSklKMTVSVk8v?=
 =?utf-8?B?L0dZdHJVR2h0TmNmNElqYWJJNjR1bDF0K01IUHloZVpaaTR3M21zNWpibUN6?=
 =?utf-8?B?SDd4UGdRSkh6Ly85UkVQT0MrcmNSY1JXNkhqOWdZUmhuR3hneUo1Qks1N3du?=
 =?utf-8?B?S3AzTXczYlc2VVZHbk5reHhQSk83d2E0c0RaZXhDTzhmd2lLN3IxVTdXbU1F?=
 =?utf-8?B?MUhLeE9UZlZobXlWSHFWZkVGdFdoZGhpSGl3SloxcEF1SkdObmg1TVRqdjFu?=
 =?utf-8?B?ZjlFVzhlWmxVbFB3dWhiNWVSdEZYUlZwYmt3NFJpYVlsakpHMldIUk9NdnZU?=
 =?utf-8?B?WG5kMU9iOTgzMy94RzMwb0tWS0tpNk5DQjJtUmJFMytZYjZDTXM2OExLTU8r?=
 =?utf-8?B?aWU0azVVKzAwU0RSODNYQlEzUFFYM2RsSlA0RHhLQ2dxa2NhODYxM2R4ZE92?=
 =?utf-8?B?TXMwNVNKSHU1S3VtNnZXOHpJRkdQRkN6OW50b2w0SXV0VWVtSmJrWksxM090?=
 =?utf-8?B?L0RrWDZlSEQvVy8zeTRGVlVSMDczWlEvTVh0R1VqTFdYT1dnV3dQZXJ1WkM4?=
 =?utf-8?Q?3XGo=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ec475d3-da0d-412f-1232-08dc2983d99c
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 15:29:04.9053
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dUhyRc66ygOxpNRB3b3iOPVgW92fpx13JaizKwQ4TWg1AihI4LZiE28ZatlZhsOs
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7503

Hi Tony,

This patch probably needs to be merged with with patch 7.

Thanks

On 1/30/24 16:20, Tony Luck wrote:
> Add RESCTRL_NODE to the enum, and to the helper function that looks
> up a domain id from a scope.
> 
> There are a couple of places where the scope must be a cache scope.
> Add some defensive WARN_ON checks to those.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>  include/linux/resctrl.h                   | 1 +
>  arch/x86/kernel/cpu/resctrl/core.c        | 3 +++
>  arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 4 ++++
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c    | 3 +++
>  4 files changed, 11 insertions(+)
> 
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index 2155dc15e636..e3cddf3f07f8 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -147,6 +147,7 @@ struct resctrl_schema;
>  enum resctrl_scope {
>  	RESCTRL_L2_CACHE = 2,
>  	RESCTRL_L3_CACHE = 3,
> +	RESCTRL_NODE,
>  };
>  
>  /**
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> index 59e6aa7abef5..b741cbf61843 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -505,6 +505,9 @@ static int get_domain_id_from_scope(int cpu, enum resctrl_scope scope)
>  	case RESCTRL_L2_CACHE:
>  	case RESCTRL_L3_CACHE:
>  		return get_cpu_cacheinfo_id(cpu, scope);
> +	case RESCTRL_NODE:
> +		return cpu_to_node(cpu);
> +
>  	default:
>  		break;
>  	}
> diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
> index 6a72fb627aa5..2bafc73b51e2 100644
> --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
> +++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
> @@ -292,10 +292,14 @@ static void pseudo_lock_region_clear(struct pseudo_lock_region *plr)
>   */
>  static int pseudo_lock_region_init(struct pseudo_lock_region *plr)
>  {
> +	enum resctrl_scope scope = plr->s->res->scope;
>  	struct cpu_cacheinfo *ci;
>  	int ret;
>  	int i;
>  
> +	if (WARN_ON_ONCE(scope != RESCTRL_L2_CACHE && scope != RESCTRL_L3_CACHE))
> +		return -ENODEV;
> +
>  	/* Pick the first cpu we find that is associated with the cache. */
>  	plr->cpu = cpumask_first(&plr->d->cpu_mask);
>  
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index eff9d87547c9..770f2bf98462 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -1413,6 +1413,9 @@ unsigned int rdtgroup_cbm_to_size(struct rdt_resource *r,
>  	unsigned int size = 0;
>  	int num_b, i;
>  
> +	if (WARN_ON_ONCE(r->scope != RESCTRL_L2_CACHE && r->scope != RESCTRL_L3_CACHE))
> +		return size;
> +
>  	num_b = bitmap_weight(&cbm, r->cache.cbm_len);
>  	ci = get_cpu_cacheinfo(cpumask_any(&d->cpu_mask));
>  	for (i = 0; i < ci->num_leaves; i++) {

-- 
Thanks
Babu Moger