Received-SPF: pass (google.com: domain of linux-kernel+bounces-59535-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <b3e77817-e070-48a7-a92b-630603c81556@amd.com>
Date: Fri, 9 Feb 2024 09:28:35 -0600
User-Agent: Mozilla Thunderbird
From: "Moger, Babu" <babu.moger@amd.com>
Subject: Re: [PATCH v15-RFC 3/8] x86/resctrl: Prepare for non-cache-scoped
 resources
Reply-To: babu.moger@amd.com
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
 Reinette Chatre <reinette.chatre@intel.com>,
 Peter Newman <peternewman@google.com>, Jonathan Corbet <corbet@lwn.net>,
 Shuah Khan <skhan@linuxfoundation.org>, x86@kernel.org
Cc: Shaopeng Tan <tan.shaopeng@fujitsu.com>, James Morse
 <james.morse@arm.com>, Jamie Iles <quic_jiles@quicinc.com>,
 Randy Dunlap <rdunlap@infradead.org>, Drew Fustini <dfustini@baylibre.com>,
 linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
 patches@lists.linux.dev
References: <20240126223837.21835-1-tony.luck@intel.com>
 <20240130222034.37181-1-tony.luck@intel.com>
 <20240130222034.37181-4-tony.luck@intel.com>
Content-Language: en-US
In-Reply-To: <20240130222034.37181-4-tony.luck@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dDF6ZXBGcGUzdHRISTd0VlppVDQ1NWRiaXpLYk9nWjdSWGZNK28xazBxMmFI?=
 =?utf-8?B?S1VDTDlmeVZURFdHVlR1eEk2d0dWem1TYVRHVkg5L3ZxZ0FsNXZpYkNyNUY3?=
 =?utf-8?B?Yk02K2drSEs4ZTBWZm1BcDZBWnhOWFp4eTVLblRxUWdKUStOcy9jeVkxb01z?=
 =?utf-8?B?VndQNFU4R0xEdGlMM1h4cFRmbStiZkFlSHBCdklpVXQ3RmFFYmJaaXhjVFdO?=
 =?utf-8?B?NXkydHVKMXJiNjdNUFg4TjRuUU5oM3U3UERtYTBBbjBtRG56dzA3TVdRZmpX?=
 =?utf-8?B?eHplaC8rbWUzd21xRThDeUtoZ1Q5WER3aTZDbElOVUZ0V3F3bk94ZFlicXZs?=
 =?utf-8?B?eXVMcjFCWHkzejRMMUdld3NURzQ0dmpsak9OL0hFQWpRbEVRek1hUmgwNS9O?=
 =?utf-8?B?MHF2aDZtNHhDbUlZZTk5MDgveE9qa0NTa3o4S2d5TlQyT0Nuc2wycER0dmVl?=
 =?utf-8?B?emFvUzlua0xuTklRZFVqTURjckpMSmoyR3RxOVZQOXhnYWlaNCtESGlINkI5?=
 =?utf-8?B?T0VMT0Y4WFB3UCtudnhHeFN3UEg1cEYxNkgrUGZQc1V5MGFHQnRoS091TlNx?=
 =?utf-8?B?RmRBcENad0FXQUlNREtFU0tYaDFaUGJKWGRlUzZ3OEZKVnlHc3NNUC9VSXpz?=
 =?utf-8?B?VkhOYmZnMjc2bCtmWGFkb2xnckNwYXlWR3RJaVdvVlpkSnVVUEw4MjVMUWJF?=
 =?utf-8?B?S0wxNTI0a2Y0UXZaL0g5L0ZlOE1uT3I1UjAxSERiQk44LzIrakkwdSt5VmlT?=
 =?utf-8?B?c291QkNaaHZwblhsUGV0UjFYYmlnVEY4U1VvTXRDQnhrVGE1dTc5dkVqekhj?=
 =?utf-8?B?d0VEVkFXVGhQUThxaDZYQVpmbjhjNGxhRjFQR05BNUtLTVMzTUZnZXR1c2U5?=
 =?utf-8?B?YUJFQXJmZUg5WjZyeExLR3VxNFNYWmYwNXRVNWZJcEhXQ1cwZzRDVVZTbVph?=
 =?utf-8?B?a2p3RXgwanBseTA4Z01KYWNLYXQyMXlOYVRoU0NMUnZsOXg2bytKQ044QjlW?=
 =?utf-8?B?Umd1MzdmV0V5UE56SVUrU0dOQ3JyN3ZtaEJNQVBJSlA1NHVvVmFGRmFnWmV2?=
 =?utf-8?B?b0VFZHk3bTB4MkRGZ0o4VE94ZTBuL01FNjRydkFBRThLSVdKRGpkYVF3UXM0?=
 =?utf-8?B?UkN5OUcvMzQwWVN0aEJQemh2Zmdwa1JDWk82cEY1VWdTVTk4TVBWQkZOOUk3?=
 =?utf-8?B?VnpsNjlQdFo3NEVIeW5aOEVrdjdlejA2SWJmOGdQQ0pteGZlbTZZTWo4c2VP?=
 =?utf-8?B?VCtBYy9JNFMxd3crdjV3Ui94cG5Ha3YreVhvQXl1ZGh2REtGU2M0dlBORmlZ?=
 =?utf-8?B?bllCSC9DbFA4a3JPeHpoTXh6c2dha3ZwaXVCWmdCaFl3SHFVS2NoNVBET2hP?=
 =?utf-8?B?NUkxeDFXUjZZY0RnWWNSTTUxclNWSDBZYUJ2eGNJcVBSTGVnbEtra04zS3JO?=
 =?utf-8?B?NExjZ0padCt4clB2OUlWaVhnUVovNEhFOTArcDdIdXc1elBqa2NrTnZybXRL?=
 =?utf-8?B?cGJZU1ZDK3gzMUxKZ3dPSzF4N2J2bmJySldTZ2RzSno3WDNJdXZRQWZjWk1w?=
 =?utf-8?B?MThLMzZHNWpucUo0SzNNcjFpQU9hempFd1JGTElqYlVrOUZuMmttWURrS0lB?=
 =?utf-8?B?U1ZTNE9YK01KUDhMaFduR1ZmSkhmRVFKTUQxUFRySTM2MzB1V3dZYlVzZENz?=
 =?utf-8?B?bS9VNFNCSlM2c1hVOEZybU13R2x3cDFtQmhtcDlGek0vSXptcVRaVEdmOUZY?=
 =?utf-8?B?NllNL0JGb0JBTEl6WmZmczVrK0NsVVdaY1FwdDNUd1gyd2hsYjlPaVdOSmJ3?=
 =?utf-8?B?aEppNDNrdWFxUmF6R1o0dXVUNFU4M2JkTjQwdmowdkFSY2NrRktWb3p4MHQ3?=
 =?utf-8?B?ck90YWxJQVRUODdMdzB5ZDYrT1pYdVF3NktQRmJ4Mlp0US9xQnBQalV5MEZB?=
 =?utf-8?B?Z3FzQkZ2UmtmNkxhd1RJL09qdFVpb3B5My91UG1NQlVFL0xndEVtd1ROaFNa?=
 =?utf-8?B?c2xYeXdiSjZHdkltb2xSU2FTbFBVamtNdWhEa0ExTkhuVkJ4R1Jud09YSWo4?=
 =?utf-8?B?eVZWNUpiL0FNeitaWjhvQVZLTDJKdmdhUEZTcm9JQU8rUEZQc2U4RXUveEFW?=
 =?utf-8?Q?oers=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8dc49a2b-4abf-4814-bf30-08dc2983c8fb
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 15:28:37.0070
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yDLu3txWGW+l0M3N6AG3ie795Pv5IH7yxV/5qZuwugGxoWGjvI03p4OaGARLV+yX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7503

Hi Tony,

On 1/30/24 16:20, Tony Luck wrote:
> Not all resources are scoped in line with some level of hardware cache.

same level?

Thanks
Babu
> 
> Prepare by renaming the "cache_level" field to "scope" and change
> the type to an enum to ease adding new scopes.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>  include/linux/resctrl.h                   |  9 +++++++--
>  arch/x86/kernel/cpu/resctrl/core.c        | 14 +++++++-------
>  arch/x86/kernel/cpu/resctrl/pseudo_lock.c |  2 +-
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c    |  2 +-
>  4 files changed, 16 insertions(+), 11 deletions(-)
> 
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index 66942d7fba7f..2155dc15e636 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -144,13 +144,18 @@ struct resctrl_membw {
>  struct rdt_parse_data;
>  struct resctrl_schema;
>  
> +enum resctrl_scope {
> +	RESCTRL_L2_CACHE = 2,
> +	RESCTRL_L3_CACHE = 3,
> +};
> +
>  /**
>   * struct rdt_resource - attributes of a resctrl resource
>   * @rid:		The index of the resource
>   * @alloc_capable:	Is allocation available on this machine
>   * @mon_capable:	Is monitor feature available on this machine
>   * @num_rmid:		Number of RMIDs available
> - * @cache_level:	Which cache level defines scope of this resource
> + * @scope:		Hardware scope for this resource
>   * @cache:		Cache allocation related data
>   * @membw:		If the component has bandwidth controls, their properties.
>   * @domains:		All domains for this resource
> @@ -168,7 +173,7 @@ struct rdt_resource {
>  	bool			alloc_capable;
>  	bool			mon_capable;
>  	int			num_rmid;
> -	int			cache_level;
> +	enum resctrl_scope	scope;
>  	struct resctrl_cache	cache;
>  	struct resctrl_membw	membw;
>  	struct list_head	domains;
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> index 0828575c3e13..d89dce63397b 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -65,7 +65,7 @@ struct rdt_hw_resource rdt_resources_all[] = {
>  		.r_resctrl = {
>  			.rid			= RDT_RESOURCE_L3_MON,
>  			.name			= "L3",
> -			.cache_level		= 3,
> +			.scope			= RESCTRL_L3_CACHE,
>  			.domains		= domain_init(RDT_RESOURCE_L3_MON),
>  			.fflags			= RFTYPE_RES_CACHE,
>  		},
> @@ -75,7 +75,7 @@ struct rdt_hw_resource rdt_resources_all[] = {
>  		.r_resctrl = {
>  			.rid			= RDT_RESOURCE_L3,
>  			.name			= "L3",
> -			.cache_level		= 3,
> +			.scope			= RESCTRL_L3_CACHE,
>  			.domains		= domain_init(RDT_RESOURCE_L3),
>  			.parse_ctrlval		= parse_cbm,
>  			.format_str		= "%d=%0*x",
> @@ -89,7 +89,7 @@ struct rdt_hw_resource rdt_resources_all[] = {
>  		.r_resctrl = {
>  			.rid			= RDT_RESOURCE_L2,
>  			.name			= "L2",
> -			.cache_level		= 2,
> +			.scope			= RESCTRL_L2_CACHE,
>  			.domains		= domain_init(RDT_RESOURCE_L2),
>  			.parse_ctrlval		= parse_cbm,
>  			.format_str		= "%d=%0*x",
> @@ -103,7 +103,7 @@ struct rdt_hw_resource rdt_resources_all[] = {
>  		.r_resctrl = {
>  			.rid			= RDT_RESOURCE_MBA,
>  			.name			= "MB",
> -			.cache_level		= 3,
> +			.scope			= RESCTRL_L3_CACHE,
>  			.domains		= domain_init(RDT_RESOURCE_MBA),
>  			.parse_ctrlval		= parse_bw,
>  			.format_str		= "%d=%*u",
> @@ -115,7 +115,7 @@ struct rdt_hw_resource rdt_resources_all[] = {
>  		.r_resctrl = {
>  			.rid			= RDT_RESOURCE_SMBA,
>  			.name			= "SMBA",
> -			.cache_level		= 3,
> +			.scope			= RESCTRL_L3_CACHE,
>  			.domains		= domain_init(RDT_RESOURCE_SMBA),
>  			.parse_ctrlval		= parse_bw,
>  			.format_str		= "%d=%*u",
> @@ -514,7 +514,7 @@ static int arch_domain_mbm_alloc(u32 num_rmid, struct rdt_hw_domain *hw_dom)
>   */
>  static void domain_add_cpu(int cpu, struct rdt_resource *r)
>  {
> -	int id = get_cpu_cacheinfo_id(cpu, r->cache_level);
> +	int id = get_cpu_cacheinfo_id(cpu, r->scope);
>  	struct list_head *add_pos = NULL;
>  	struct rdt_hw_domain *hw_dom;
>  	struct rdt_domain *d;
> @@ -564,7 +564,7 @@ static void domain_add_cpu(int cpu, struct rdt_resource *r)
>  
>  static void domain_remove_cpu(int cpu, struct rdt_resource *r)
>  {
> -	int id = get_cpu_cacheinfo_id(cpu, r->cache_level);
> +	int id = get_cpu_cacheinfo_id(cpu, r->scope);
>  	struct rdt_hw_domain *hw_dom;
>  	struct rdt_domain *d;
>  
> diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
> index 8f559eeae08e..6a72fb627aa5 100644
> --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
> +++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
> @@ -311,7 +311,7 @@ static int pseudo_lock_region_init(struct pseudo_lock_region *plr)
>  	plr->size = rdtgroup_cbm_to_size(plr->s->res, plr->d, plr->cbm);
>  
>  	for (i = 0; i < ci->num_leaves; i++) {
> -		if (ci->info_list[i].level == plr->s->res->cache_level) {
> +		if (ci->info_list[i].level == plr->s->res->scope) {
>  			plr->line_size = ci->info_list[i].coherency_line_size;
>  			return 0;
>  		}
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index 9ee3a9906781..eff9d87547c9 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -1416,7 +1416,7 @@ unsigned int rdtgroup_cbm_to_size(struct rdt_resource *r,
>  	num_b = bitmap_weight(&cbm, r->cache.cbm_len);
>  	ci = get_cpu_cacheinfo(cpumask_any(&d->cpu_mask));
>  	for (i = 0; i < ci->num_leaves; i++) {
> -		if (ci->info_list[i].level == r->cache_level) {
> +		if (ci->info_list[i].level == r->scope) {
>  			size = ci->info_list[i].size / r->cache.cbm_len * num_b;
>  			break;
>  		}

-- 
Thanks
Babu Moger