Received-SPF: pass (google.com: domain of linux-kernel+bounces-59555-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <d06441c9-db33-4c44-81cd-dc1052f48e43@amd.com>
Date: Fri, 9 Feb 2024 09:49:55 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] cpufreq: amd-pstate: Fix min_perf assignment in
 amd_pstate_adjust_perf()
Content-Language: en-US
To: Tor Vic <torvic9@mailbox.org>, Perry.Yuan@amd.com, ray.huang@amd.com,
 gautham.shenoy@amd.com, rafael.j.wysocki@intel.com
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
 Oleksandr Natalenko <oleksandr@natalenko.name>
References: <8eefeeb7-f8e8-49f4-b83c-e67a9e728f41@mailbox.org>
 <20240209154336.7788-1-torvic9@mailbox.org>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20240209154336.7788-1-torvic9@mailbox.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MkIvMEQyK1FUeXQzZ1kzbmhnd3lVb21OL1NtRDJ4MGR4R3gzZjdvVTlQM25X?=
 =?utf-8?B?cGJlTmRwMmZ4WC93WnlhcENrVWdMV21qNGFjaDdOWDJUZ3pUaGtiOEJIaWdq?=
 =?utf-8?B?dFJpcit4OUJWZkdhMEg0cGN0YndtUHU3dTlJU3J0U2o4UU5yTGlwWElKcUVl?=
 =?utf-8?B?RmFnT0dGcHhEdjFTRFRML2ZxZ2JuVmRzVFBKU1FwMHlMcE14dzYrUElQckJZ?=
 =?utf-8?B?enFyMittZGVDcGhBSDlxdmVQdjZ6S3E2SXRNVFpCVTU0eGFUelhadjIxZnB2?=
 =?utf-8?B?aVVNSXBoQW9ScW5BUytaR1VaejQ5bzMzeWZTcVpwQlMzOWpIT3kyc21IME5w?=
 =?utf-8?B?SGl5aFRzUFQzdnVuMENrMklVa1VPSU5weGsyeGRYRE9uYkRRaSt1RCtBYlVU?=
 =?utf-8?B?cUdJVUdLV0wveGp5aHdQOEtCM3d1ZGMwRGE5RklJS0E4bWhqalZkUVd0OVhq?=
 =?utf-8?B?UXRKWXczV0drQyt4amJVWGl1dmZPeEFDa1U3cTE2YkJRKzBZR1JRazVDeEdR?=
 =?utf-8?B?TXBUV2F0cmN5cTVwU3JxVmE2SVI0ZndReUx6bXorTm1Cd09hOXJsTmN5ZUJj?=
 =?utf-8?B?bmgwNTBIWlkxbDFhbGFjUGo4VUNxdFY0Z3BiTWcxWFkvc2tLY3RwTTczZVJ0?=
 =?utf-8?B?UUVpNEZCeUEyWW5oOG96dW40OUpnNGxGbjFVVEF0WjJwalBiL2Riazk2TGtT?=
 =?utf-8?B?eS9DMHlkbFBLOTlzOThRM2REWkpyU0J0dC94aHlrTDJNVUxRS0lmWDNOMXN6?=
 =?utf-8?B?Z01Xd1NkS1g3S0V2VXluZlIwNnJ4OW5GOUhHNmJTcWJHbXBWTmFRaWNmY3lI?=
 =?utf-8?B?R2RQS2VSQ0lwcWZxcFN0OE8reVBFaERlUDJYNzhnUE0xTWVpbmx4VDZoYi9s?=
 =?utf-8?B?cGl0SzhlQ05ObHpIN1RkZWFMVkJSd1U0b2NVZUFCemQweXlIV2xUSEU3WTZ0?=
 =?utf-8?B?WEkzLzdyYUlNeC9aOGFSNmlrVEMrcnZWS2xBRVpjK0loNkFuYk9wenBMUC9W?=
 =?utf-8?B?ZHpJY3RaL0E1MGJEdHhTOHhVbHN0K0R2NFN2TnowRWoxMkxFUUcrQzFFWFJL?=
 =?utf-8?B?VzJxNnFjL3NvZ1J1allubFBVS1JpMXVpRitDTjlGZ2lQMDkydENXMWxkYnlY?=
 =?utf-8?B?TThTazF1YmlxdEgyUjAvUHJSMWRwYklNZ0dOUHJtbnN3U0gxTVY4SGd2aEQz?=
 =?utf-8?B?SHRCenYrbnh5Y0VITVZ1WnNhbmlNRkJUYjNJNmtJcXJ0d3ZvT1ozeDFXRXFX?=
 =?utf-8?B?cXBxaSs4Slc5dGd2VUNFOFdkWFUvZzZBK08xWWpKRzl3ejQvajQvZko5aU9L?=
 =?utf-8?B?Wjg3ZkJzVzcyTjFFOW5jbzRRNk1RMEtyNGI2Q2EvN2NWRmNYSFhTKzRJQm1T?=
 =?utf-8?B?ZmpHdWZ4a0xWQjBBNzdPRTFaRXNSUmxta0xSSkZKWktrdHBmMkU1WVVuU1Fm?=
 =?utf-8?B?dHpUU2s1aUVGWnVGQmFobGhWdVhsTkpJQTVpcmE1MFZhOXAyN040TXZiWW50?=
 =?utf-8?B?aFoyOXgyODNXelJZcEYrWWhpRWtOU2FWQW5uUDA2RWhkZXo5RWN1aHNBOHBm?=
 =?utf-8?B?VjJ6VGxFbkM5OXN3YUZucHlRQVNxYVAxaFQwOGlNMlU2QXlRb2hVZWorbXFQ?=
 =?utf-8?B?cTdGaE9nRUJibHZlZDJJbjVySTV5OE9VWVdkMHRFSm5LZHBaaisyU1k0eUZW?=
 =?utf-8?B?Y2tRbDZOMHN2WUU1SHFUb2RvNXVvWk1tbWpBL1pubWdtQ3kwWDlmQ2V1ZldT?=
 =?utf-8?B?SFFOVDAzODBTbUFiYjBCUVFhNmJhZzNxNTRlWEFsUGx2Z3NYYmw2bUMzb1BM?=
 =?utf-8?B?TURvQmRqTExpK3RJcU5ZV294elY3cTVwRFZFZE1ETlM4dzF5N0wxVjdvTHU0?=
 =?utf-8?B?NnBYR202WXRmK0hnQlRzdjRNZjZhQk95WC9nTTBrVENzTUtoZm9kRFVxdVNr?=
 =?utf-8?B?MHpOSVZTRHlzWDFOcXFYRDEvZmR0ZHkxUithc21TWHYySzh6UlNKaFg2MGN6?=
 =?utf-8?B?V0FmTnJGZUdXQk1VZk5ucFVpOU5qcGdMNDZtbllIaWEyN0JrcWU0WE0wNTlm?=
 =?utf-8?B?TTVUbGcySVQxd0NOVjEvTGdYWHFjRGcySlFXUmhDTnFzT2w4QW82WkdJejFR?=
 =?utf-8?Q?VJ+wNdazWOGWaOr/zgOCPFHxm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92582d73-3a52-46a5-d968-08dc2986c36e
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 15:49:56.2268
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UG52lP3iHocbi7YiklS35yPorDbSCqpwuR0NA+6EqfMGRdF+HEmXa5DHOvvOHiTEGdqhtxTlJBlCctiplzaMfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5837

On 2/9/2024 09:42, Tor Vic wrote:
> In the function amd_pstate_adjust_perf(), the 'min_perf' variable is set
> to 'highest_perf' instead of 'lowest_perf'.
> 
> Cc: <stable@vger.kernel.org> # 6.1+
> Fixes: 1d215f0319c2 ("cpufreq: amd-pstate: Add fast switch function for AMD P-State")
> Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
> Reviewed-by: Perry Yuan <Perry.Yuan@amd.com>
> Signed-off-by: Tor Vic <torvic9@mailbox.org>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v2->v3: Resend with git, misconfigured mail client borked v2
> v1->v2: Add Perry's 'Reviewed-by' and 'Cc: stable' tag
> ---
>   drivers/cpufreq/amd-pstate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 08e112444c27..aa5e57e27d2b 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -577,7 +577,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu,
>   	if (target_perf < capacity)
>   		des_perf = DIV_ROUND_UP(cap_perf * target_perf, capacity);
>   
> -	min_perf = READ_ONCE(cpudata->highest_perf);
> +	min_perf = READ_ONCE(cpudata->lowest_perf);
>   	if (_min_perf < capacity)
>   		min_perf = DIV_ROUND_UP(cap_perf * _min_perf, capacity);
>