Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp1012951rdb; Fri, 9 Feb 2024 07:50:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IGlSMqVo9Btbxo/7jq1hVc49wUKmO59ySJ/U5NEHb6VoAWCkOJY+4dO5nkyURQO699A0K15 X-Received: by 2002:aa7:c353:0:b0:561:1366:c8c0 with SMTP id j19-20020aa7c353000000b005611366c8c0mr1592488edr.24.1707493842288; Fri, 09 Feb 2024 07:50:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707493842; cv=pass; d=google.com; s=arc-20160816; b=zCYQvN+/J840tcBOnswcPF2BXat0mo0PMyZSVdet35OVfjFWSxN0o7GblsJZGUF+GQ MtkvEdvPe/P60K/GrssAUsatchhjjM4T0lM5kU7U0RGtpvDvZ1PfADMVY4+vmD4XGUHD TccCZ9T+nZrtJn0ZN6eqi3D0AOrDdWqwcmhfPvE8BAQeGY4ww2JdG1OcIY0Nat7OELGg ZKMYg0il3R+COX3bfmhIf1EO/rUwUsBGcdps/3TjraTV0qyGgFC6R0lv5m5Kzvcyu/Ay gvOjbsns7bglxQVReWDzSCR0nh6xRcs1JwJ8izufPxFUYnURs1lZZEFhVz9/clDc06D3 25eQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=aog0pm2kQ6N1ORXu6JJIvtvbI3Lh2fO9g5pi0fRqPxk=; fh=6ZLDGLuGIW3rRlgBnRobjrVSQgFzK1tk5HXsi6WboTI=; b=xt7GEm6FRFIKUbKCS9ojtVzAAsbz1Nz3SE3ucsNqbWXqlU77FXZd4FuGs3k1uP7Xm1 2IhPTuJ5Ue6GwK5c2cU17Gus9WcMyWEtu8EDiycaaMKyrcuERVcxNzSc4wr7ub3nHM5F uHQeqDAmIDxxNu11NpzMNIyjbkexWr0Ok9DKOiRFIcGa+wv9EpOm04WvRGRlaxXWNBaP mgBzKqYxUPr/kEdzCKZSbEElXqHvJjElWZJLPyU+9X3RsxspL7g1eY2fINwUBVV36wMq IVuCdgg/TpFgixIOJW8MSRRH5NyYbInDE1TtczG2l0ivY1YRWt66oDYx7UBwbEvjYMuJ MYhw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Gd6H8K62; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-59557-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59557-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCV2w7m5w7hhI4G7D5C2K8NSV5jUPnBhseFPZEvB0VBZazvM7OdQ6BfDD7BOW7Bz1aJxGhUfA1kRHmMn8HNiis3ghtyWMjrMpo38Js5oLQ== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id cq8-20020a056402220800b00560c3207796si991531edb.641.2024.02.09.07.50.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 07:50:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-59557-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Gd6H8K62; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-59557-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-59557-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 0BE661F25971 for ; Fri, 9 Feb 2024 15:50:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 62E577603C; Fri, 9 Feb 2024 15:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Gd6H8K62" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D21A74E10 for ; Fri, 9 Feb 2024 15:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707493834; cv=none; b=o4pUo0MP76QNmVe3dVVD5wRnDKUKNX5AXdH2W/lPtWbvhwaMlbwgA6hUQ0yeqwk7eQFPDlvMxIQCb2ivxxEUPQgO09BkMygVOIYFu6O5tBxWh8hT4Ytv753OoNxS1e4CEANwRr3zq2MiPB3AEPHgCK5pLUmszOJwUzQlZ9GdJV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707493834; c=relaxed/simple; bh=zRj7Ic4l/E73fjvhjprZydN7d0176ik2vMMmlB1Ot98=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZCHAFgp4+MkuMUN+cHBhSMGmOG7L0YsWU+JIExu913sgLKtY/R7kWGGFDyIXZvbBtLIRAOjX7oeFvRmAEPqLSV3p47i1Rk6bipXuYmf3bqxJJxrRgdMxL+KOtyiFTGmdQz0nSpQn8jZufpdbH1VKcivvFtQkFBadvEfgo6frLKY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Gd6H8K62; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE1EAC433C7; Fri, 9 Feb 2024 15:50:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707493834; bh=zRj7Ic4l/E73fjvhjprZydN7d0176ik2vMMmlB1Ot98=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Gd6H8K62KuZARwutWS7UtdyHlLVoUpcXYspGEJb1w5wdxpSUcNbv5Fev/+6jzh9Mk /ddrLAWcBB58pafUJxOMJ7VsfTSqUmvITzEQr8c85Qq1ceSgxs0h2guX7vL8bygqkK mGQLE+zKYV7n2J0kO6gyvIfB5itVCebY/wynHR+68dI2RrUI63Nr7LljnipHBAiG/U 1ZKX+5Epto301nUA4GPhcDuiktyk9gIt7uEWBC0vbK8YN58XNdwthsieTBTLlxdyiO 7oZ+9Ul2C5ezTlp6fB1OIhIkEO2YcBUYX+9zoxcdf+XJevXp/qUpXQDsU9hAUgG68H 0dUILikGB9r3A== Date: Fri, 9 Feb 2024 07:50:32 -0800 From: Jakub Kicinski To: Imran Khan Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] connector/cn_proc: make comm length as TASK_COMM_LEN. Message-ID: <20240209075032.1deb447a@kernel.org> In-Reply-To: <20240209121046.1192739-1-imran.f.khan@oracle.com> References: <20240209121046.1192739-1-imran.f.khan@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 9 Feb 2024 23:10:46 +1100 Imran Khan wrote: > Since comm_proc_event::comm contains a task_struct::comm, > make its size same as TASK_COMM_LEN and avoid magic number > in buffer size. missed CCing netdev?