Received-SPF: pass (google.com: domain of linux-kernel+bounces-59585-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 9 Feb 2024 16:09:06 +0000
From: Will Deacon <will@kernel.org>
To: "JiaLong.Yang" <jialong.yang@shingroup.cn>
Cc: Mark Rutland <mark.rutland@arm.com>, shenghui.qu@shingroup.cn,
	ke.zhao@shingroup.cn, zhijie.ren@shingroup.cn,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/arm_smmuv3: Omit the two judgements which done in
 framework
Message-ID: <20240209160905.GA24565@willie-the-truck>
References: <20231221093802.20612-1-jialong.yang@shingroup.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231221093802.20612-1-jialong.yang@shingroup.cn>
User-Agent: Mutt/1.10.1 (2018-07-13)

On Thu, Dec 21, 2023 at 05:38:01PM +0800, JiaLong.Yang wrote:
> 'event->attr.type != event->pmu->type' has been done in
> core.c::perf_init_event() ,core.c::perf_event_modify_attr(), etc.
>
> This PMU is an uncore one. The core framework has disallowed
> uncore-task events. So the judgement to event->cpu < 0 is no mean.

It would be great to refer to the changes which added those checks to
the perf core code. From reading the code myself, I can't convince myself
that perf_try_init_event() won't call into the driver.

> 
> The two judgements have been done in kernel/events/core.c
> 
> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
> ---
>  drivers/perf/arm_smmuv3_pmu.c | 8 --------
>  1 file changed, 8 deletions(-)

It looks like _many_ perf drivers have these checks, so if they really
aren't needed, we can clean this up bveyond SMMU. However, as I said
above, I'm not quite convinced we can drop them.

Will