Received-SPF: pass (google.com: domain of linux-kernel+bounces-59552-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <23361410-3b56-42fb-aea8-3be53bfe5ae1@amd.com>
Date: Fri, 9 Feb 2024 09:48:57 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iommu/amd: Mark interrupt as managed
Content-Language: en-US
To: Joerg Roedel <joro@8bytes.org>
Cc: suravee.suthikulpanit@amd.com, Vasant.Hegde@amd.com, will@kernel.org,
 robin.murphy@arm.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20240122233400.1802-1-mario.limonciello@amd.com>
 <de66890b-a42c-4d8b-8079-fcfff0007aeb@amd.com> <ZcXhMNZDOHstOP5k@8bytes.org>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <ZcXhMNZDOHstOP5k@8bytes.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZFJxNllKYS9GNVo2Yjk3OXBrZXI5YlRpSG85WU5MQjJNR212azRPZURjRExG?=
 =?utf-8?B?K0YyVGhoZDF1MmN4NVdTU2hNaU55QUR0OEVSMGdHUkxNZlI4MjB1MkZ2UFV3?=
 =?utf-8?B?WXRQTVRwNEpIQ01Vc0EvdHVJMEh4SDRWWURaRERRK3ZJYWQ4RTBBUTIvdlZh?=
 =?utf-8?B?MndOU0duMWovMjkxRUY5LzNBdnIxNllJR0xDWnhQZFFUaFZadTFJNXhOY2Vn?=
 =?utf-8?B?V3VCVWlzcEFlRHF4ZXdlOUZCTWU5VVJXcC8rTi9yQmhoekczZFJDdGN1SlpE?=
 =?utf-8?B?ZGhYZ1F6MnZwNGZzZlZzYVB0TDEya2hvTmhnN0YzUGlZSk45UE1kcXg0dFJO?=
 =?utf-8?B?U3c3TEJydXI5VEk1UFluNXlRSk1ucnZHSW13NmJBbEx2bEVyZEVUSXdkMVh4?=
 =?utf-8?B?OWZXZFFrYU5reEd4TEtKS2ZCeUo3V2pUUHJER1VLL1R5SHlVbWdCYlYzZ3VE?=
 =?utf-8?B?cFJiWjV0Yy9XaFJ2TjMwM3ZjNkl1UFVZNFl5eXFRYXRuYVlaZ29QRFhkRTdI?=
 =?utf-8?B?UEcyZG1OdDRERStzcDYrZkdGV1NaTzgrOTNSVEpPdTBIVzRaVit1QlIrcG9h?=
 =?utf-8?B?cXM4eEhWVnYzTzFoVVQ0ZWprckZqU0FmYm9iRml0UFZXN1JIaENQamdXQWdC?=
 =?utf-8?B?b0xqVEhJdTB6YTRXd1B3WXdpNFI5Y3E1eXE1a1NJcitEb21jWDdhTTFYNlJX?=
 =?utf-8?B?QWtYNDNsdHdtbFptWWJ3MEU1L09qUDh5L3RRSTBuNVNUWGpMdUI3U2YwNEpP?=
 =?utf-8?B?SjJ0d3RjZjM5bGZtR090UzVQZWhNN3BKRUVCQnlTYkpqa0g2ZFVRdC9qRlNx?=
 =?utf-8?B?aWlxZzhBU0p3V2hERTk3UG5tc2NUT3VwRkhtalpUbHh2T0F5R1hDQVlHNnpx?=
 =?utf-8?B?R01QcVgvMHk3d3FoSDZlbzlIbks0TkpTN1pWbnFxZFFxVXdkcGJaNnUyQ0F5?=
 =?utf-8?B?WlU4OG5yc3ZubXMraEhYS241YzRUby9sT1BYMTI4TjltV1ZQUEJFUENCbE94?=
 =?utf-8?B?bjd5TXhzdE9iTktwdVpBbkRsaEd3aEt5TU9jVVFnb0VHdk1xeXdQRzgvWFg3?=
 =?utf-8?B?aHE3bmJLTFRIWHdPQlozT3orOHoxVExPdFE2cHI4V0JIRG0vU3Vqdi92d0ht?=
 =?utf-8?B?WVB6OFJlQlA0YXJkR1dMNFVGYWM5K1hQZ0h2UndSdGZhWWpiYWFqY2xZQnU3?=
 =?utf-8?B?ZWhhL1NjZTZSVHI5VllTRzRzeWRYSmtaMXlHd2ZmOUF5OGJNam54bi9VZGlX?=
 =?utf-8?B?cmxPZWZscS9ET1ZtOThaT3JJYUEwdVRpZXNtRUY1dExFZlg2dUYwL29zZHQz?=
 =?utf-8?B?NE5PWkNraThxUXgvREliVm10aHY3MnUyNlQwakh6MGxLd0FOL2RuZW4rSmNK?=
 =?utf-8?B?VVVkWWhPOTZMaW5UOWpjSXJnZkdBM292NDNaUktCYzI0NTEwMXhYSEpqcm4z?=
 =?utf-8?B?NGE2STZ1cjNlUGVubVlGb3BFSU84Nk9ueXh1WVZvQiswS2pnK0Jua2NmcFdv?=
 =?utf-8?B?ejlIZ0hJVVdjL28rQjEvOWpuYzIyMXEyUlNNS20rYzR0cGpsbjlKVE1iOE1D?=
 =?utf-8?B?TytOS3I4cmlMcVVoNXUzOW90dTBZOTBvN1ArYWtPOXBKdHdOTFFzQUFuc2Nz?=
 =?utf-8?B?REdzMXZjWU5KRGttbWcvUTUzeGl6RFo0OWdFTUhoSUIrTk83MldoM0E3WmZn?=
 =?utf-8?B?SjNzTGNiNm5rU3ZabXIyZmRVK0JCMmhuRnphNktaK0JnUkE1MldoejByNjI4?=
 =?utf-8?B?NGd1SzhIc2t2R0RUNUd1Qkg3eSsvajZIV21YZ1JjSWVMb00vdzc3d1htdWZW?=
 =?utf-8?B?WjRvYyt2MlgvdkdNOVg5cnU5S0UvVXYyTEE1cW1HUmR5OFdtM2xEY3o3dkJW?=
 =?utf-8?B?dGtpQ0E4RXEvYkZOR3lDK0t4QTBrNXFFNzJwY3JXL0VZeFBNa3htYnA5eVI4?=
 =?utf-8?B?VHhkajRQYTFpanl4L3JvZDhyRmgvQ1lMNnI2L1QxZldhYnNkMk1lemJLclRN?=
 =?utf-8?B?OGJ6emtPd09jbDVHMmFKWU9BVVBYMEtBckVvcm1NVE1GR1VVaUtVRW5yaHd3?=
 =?utf-8?B?cDRyTU1DbkJHZ0MybzhYTTZacUtLWlhPRkZ3Tk1DYjJxNEhXRFB1Y3lNVlYw?=
 =?utf-8?Q?aqEf11n3RyK3ZRKDgMTYyIRR2?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11be86e5-0d8d-49f8-63dc-08dc2986a1d8
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 15:48:59.9132
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PT/C4LBuayd+AwfSbVESap5hqIY/aE8vi3YLCVtT7KUwpe/1dER5OkLPqck9Bum1pmLZNtXqRJYVmoQpMaq1WA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5837

On 2/9/2024 02:24, Joerg Roedel wrote:
> Hi Mario,
> 
> On Mon, Feb 05, 2024 at 10:31:47AM -0600, Mario Limonciello wrote:
>> Friendly ping on reviewing this patch.
> 
> Thanks for the patch. Since this is a fix the patch should contain a
> Fixes: tag. Also a review from Suravee and/or Vasant would be great.
> 
> Thanks,
> 
> 	Joerg
> 

Thanks!  This problem should go all the way to when MSI support was 
introduced (2.6.28):

a80dc3e0e0dc ("AMD IOMMU: add MSI interrupt support")

But I don't think that's a correct fixes tag because
irq_managed wasn't introduced until 3.19:

cffe0a2b5a34 ("x86, irq: Keep balance of IOAPIC pin reference count")

But then I tried to go off the original introduction of the error 
message, but that's quite ancient.

1da177e4c3f4 ("Linux-2.6.12-rc2")

So which tag do you think is appropriate to use?  I'm tempted to say 
this should just be without a fixes tag just a:

Cc: stable@vger.kernel.org # 3.19+